From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0882BEEB565 for ; Thu, 12 Sep 2024 08:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nlbjGqxPrkeon87/oeRHHfBNj7EM9vRLefgULYdvY+w=; b=2C1eUJ8oQCGKAQkelFYdLvlf2g 42g6gUPudQ7Bi9l5NgQVpu0XEhKkUNoJFGOPSrxowevZ6WYbaJh9xm1NlVxSulSWZl9mwTKvlIJGA jWGf8pIEoAYB825m5ZxeKTD48rTbDfV5eFT4/tpiQ4R7gV3mKysvouI01j2VpbkcEiGWZgzZaqhVO jWVhFTcgwjlviw04/0s4aGwZwh5ht2l6sf44flurqS1p9Jg7oQc/2/j7tvHGAdeTXY/rAWNgxgZBO Y7gkt0Iozg+3ZAdZR15UuPeHhN28FlSwmKjjfj78Ome26aZjAotsqA0N0FxrEiGdOMvU2lVo7Ke/h /QJpOAbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sofXa-0000000CQx8-0BiT; Thu, 12 Sep 2024 08:51:02 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sofWT-0000000CQf1-3AWx for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 08:49:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726130991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlbjGqxPrkeon87/oeRHHfBNj7EM9vRLefgULYdvY+w=; b=gsE0IaFr6/b/7PzRz7hjQQM8j79xxE5UY3iWN18789CFUlB367YLemVWkafDyMcUMV93Ee Bt2Ak2boJ4Mi7f02Md3H0uxIhKX8YhtkAYkc18MhzKNi4ERcfr+YuhOZ+smaUmN4EMCRry fHgsQT+sVpKJGgRPiGBm2+Ht+ekH1eE= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-vAS5P7rQMTyi_zEczgz1eg-1; Thu, 12 Sep 2024 04:49:50 -0400 X-MC-Unique: vAS5P7rQMTyi_zEczgz1eg-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-206e07915c2so7905145ad.3 for ; Thu, 12 Sep 2024 01:49:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726130989; x=1726735789; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nlbjGqxPrkeon87/oeRHHfBNj7EM9vRLefgULYdvY+w=; b=dx5W5K4/fgTqIx3WoZsBtiRlqVYwnPkZvpSfEV8YoCunjEZdw0l/4NhZxq/oqmBzFK 7KJAVbDeqgCTOjEEoQ2X7X7+ObyPsgihxDu0IhwAuiirV18uu9cQFAxA6CbUql1Nk7ky bx4pM0wIdzvBQ2kUTFERX09kMRKYT0qCZmXqDaIZWmfz/erqKbkpuoESclqVNgS46U4x DVowAInu+maQjnHhBf/wl2hpJ/xy0A1YpodXchl2FhwWKv9a9GhpyJ7qpwHwLF9RIvFw 94o6dQQXCxoelgyPmV4jf4E68Fc/WjHFmp//Q0ptA1cxeLaNgVNoeNE7xK8sRh1WcOhe OtUw== X-Forwarded-Encrypted: i=1; AJvYcCVYXWHiUKZ+DLsHSUDI4zucRdTMl3AAoxbHR7SGI076Vslql6AwAMNimjFLmko7XZeKnp4jxtVbaO2ejx+nAGeM@lists.infradead.org X-Gm-Message-State: AOJu0YwK5HnrOHt+NOUpVBm4DNIyr3JryTu6pwdbRR9xj9DThREOhtOB i7VqhPb0S/5m2k6Y28NOCkrqQUG2AEm4YZ2NT+5Cw4qOPq4zUWEvDJREuMxyjtvVnRwK4DYu0NZ W8bHSYEk+QBIjrR69dNUjWjH59Da58QMuSD/JVFv9EfnGwh6EOarpBnTTmBl0PRzAlh6sBu8I X-Received: by 2002:a17:902:da88:b0:206:b250:1e1 with SMTP id d9443c01a7336-2076e4239fdmr35741725ad.45.1726130988825; Thu, 12 Sep 2024 01:49:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPAkVBoX5O51FPnWXRKfp2ysY+5b/bgkEdmVhjUV5BvvY4BoXMPZkD0mwXpBtdC2wzCEryIw== X-Received: by 2002:a17:902:da88:b0:206:b250:1e1 with SMTP id d9443c01a7336-2076e4239fdmr35741415ad.45.1726130988229; Thu, 12 Sep 2024 01:49:48 -0700 (PDT) Received: from [192.168.68.54] ([103.210.27.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076af25117sm10632455ad.39.2024.09.12.01.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 01:49:47 -0700 (PDT) Message-ID: <8e17105a-8732-46df-8f3e-01a168558231@redhat.com> Date: Thu, 12 Sep 2024 18:49:38 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 07/43] arm64: RME: Check for RME support at KVM init To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun References: <20240821153844.60084-1-steven.price@arm.com> <20240821153844.60084-8-steven.price@arm.com> From: Gavin Shan In-Reply-To: <20240821153844.60084-8-steven.price@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_014953_902961_BBAFFD20 X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/22/24 1:38 AM, Steven Price wrote: > Query the RMI version number and check if it is a compatible version. A > static key is also provided to signal that a supported RMM is available. > > Functions are provided to query if a VM or VCPU is a realm (or rec) > which currently will always return false. > > Signed-off-by: Steven Price > --- > Changes since v2: > * Drop return value from kvm_init_rme(), it was always 0. > * Rely on the RMM return value to identify whether the RSI ABI is > compatible. > --- > arch/arm64/include/asm/kvm_emulate.h | 17 +++++++++ > arch/arm64/include/asm/kvm_host.h | 4 ++ > arch/arm64/include/asm/kvm_rme.h | 56 ++++++++++++++++++++++++++++ > arch/arm64/include/asm/virt.h | 1 + > arch/arm64/kvm/Makefile | 3 +- > arch/arm64/kvm/arm.c | 6 +++ > arch/arm64/kvm/rme.c | 50 +++++++++++++++++++++++++ > 7 files changed, 136 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/include/asm/kvm_rme.h > create mode 100644 arch/arm64/kvm/rme.c > [...] > diff --git a/arch/arm64/kvm/rme.c b/arch/arm64/kvm/rme.c > new file mode 100644 > index 000000000000..418685fbf6ed > --- /dev/null > +++ b/arch/arm64/kvm/rme.c > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 ARM Ltd. > + */ > + > +#include > + > +#include > +#include > + > +static int rmi_check_version(void) > +{ > + struct arm_smccc_res res; > + int version_major, version_minor; > + unsigned long host_version = RMI_ABI_VERSION(RMI_ABI_MAJOR_VERSION, > + RMI_ABI_MINOR_VERSION); > + > + arm_smccc_1_1_invoke(SMC_RMI_VERSION, host_version, &res); > + > + if (res.a0 == SMCCC_RET_NOT_SUPPORTED) > + return -ENXIO; > + > + version_major = RMI_ABI_VERSION_GET_MAJOR(res.a1); > + version_minor = RMI_ABI_VERSION_GET_MINOR(res.a1); > + > + if (res.a0 != RMI_SUCCESS) { > + kvm_err("Unsupported RMI ABI (v%d.%d) host supports v%d.%d\n", > + version_major, version_minor, > + RMI_ABI_MAJOR_VERSION, > + RMI_ABI_MINOR_VERSION); This message is perhaps something like below since a range of versions can be supported by one particular RMM release. kvm_err("Unsupported RMI ABI v%d.%d. Host supports v%ld.%ld - v%ld.%ld\n", RMI_ABI_MAJOR_VERSION, RMI_ABI_MINOR_VERSION, RMI_ABI_VERSION_GET_MAJOR(res.a1), RMI_ABI_VERSION_GET_MINOR(res.a1), RMI_ABI_VERSION_GET_MAJOR(res.a2), RMI_ABI_VERSION_GET_MINOR(res.a2)); > + return -ENXIO; > + } > + > + kvm_info("RMI ABI version %d.%d\n", version_major, version_minor); > + We probably need to print the requested version, instead of the lower implemented version, if I'm correct. At present, both of them have been fixed to v1.0 and we don't have a problem though. kvm_info("RMI ABI version v%d.%d\n", RMI_ABI_MAJOR_VERSION, RMI_ABI_MINOR_VERSION); > + return 0; > +} > + Thanks, Gavin