From: Michal Simek <michal.simek@amd.com>
To: <ye.xingchen@zte.com.cn>, <michal.simek@xilinx.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Use devm_platform_get_and_ioremap_resource()
Date: Tue, 31 Jan 2023 13:22:04 +0100 [thread overview]
Message-ID: <8e4ec3a1-e0ac-ad7a-3414-6e213451e276@amd.com> (raw)
In-Reply-To: <202301281453121890132@zte.com.cn>
On 1/28/23 07:53, ye.xingchen@zte.com.cn wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
note: in my part of world name is starting with upper letter
> ---
> drivers/i2c/busses/i2c-xiic.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index bee5a2ef1f22..5114888f2916 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -752,7 +752,6 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> {
> struct xiic_i2c *i2c;
> struct xiic_i2c_platform_data *pdata;
> - struct resource *res;
> int ret, irq;
> u8 i;
> u32 sr;
> @@ -761,8 +760,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> if (!i2c)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(i2c->base))
> return PTR_ERR(i2c->base);
>
> --
> 2.25.1
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-31 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 6:53 [PATCH] i2c: xiic: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-01-31 12:22 ` Michal Simek [this message]
2023-02-12 21:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4ec3a1-e0ac-ad7a-3414-6e213451e276@amd.com \
--to=michal.simek@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox