Re: [PATCH net-next] net: stmmac: add tc-ets qdisc offload

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi Lorenzo,

On 8/4/26 20:17, Lorenzo Bianconi wrote:
> Implement offload of the tc-ets qdisc in the stmmac driver. The number
> of ETS bands cannot exceed the number of TX queues, and mixing strict
> priority bands (zero quanta) with weighted bands is rejected.
> 
> When all bands are strict priority, the MTL scheduler is programmed with
> SP scheduling; otherwise the requested weights are applied to the TX
> queues and the scheduler is switched to DWRR. The TC_ETS_STATS command
> is accepted and handled.
> 
> Export stmmac_set_tx_queue_weight() so the ETS path can reprogram queue
> weights, and wire TC_SETUP_QDISC_ETS into stmmac_setup_tc().
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>

From my very small understanding of ETS, this looks good to me.

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime