From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56419C4707C for ; Fri, 12 Jan 2024 08:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VgHT5IYw79WsElYU0Rd4bGn+6OOObpnzKy9CWPHVVZw=; b=bB+yYXRT6tFb2D uZg/y/bZDRrvJmKIpeqCp0Iaf8YZsi+0ytbC8xBv80hubBjq5PW0543lNusDG+Jq9PsH037XiNqXx fue/RZs8Bl6SgeBQfwM4Kj0fFJCGTnl49q3fKVbXlP0xrOXrTlISQLOx40hiHTRZzq7E0J1rJ7DCq 8whSIxdWMTi0ha3lbeeOGPtNIJSgkGlZ578Og2pnqCbToqWIRGHwfymAZFzXXd0XLsVaSE6Sj3pAl gHJ3/OPBoS/ka5vMeVd/qRldFbOK3DIh6vVZPy/JTDeUTPcC/ob32b6jkrWrZ00FnnX3b1KRhilxI k9OdE9JpurJ709ApiP6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rOCcZ-002AZb-2E; Fri, 12 Jan 2024 08:10:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rOCcV-002AYV-3A; Fri, 12 Jan 2024 08:10:29 +0000 X-UUID: 0836b2fab12211eeafd70d0b34820190-20240112 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=6lbmgbTAS7XJ67sF4PQV1B73RjbDtxh++4IhiQvU5mE=; b=FgTQsiKf5IQwGUL8Avr9TSJzWSRkZQQvZJ9dpFf/j5rJkxOAzMOZiLt9R8Rxm/oxbPj1qsgCle49RhjcaoJ6gctMDJlht2nUL3r5iyHUA7pO5v7v7fTX6dSbOiKPyhAVYBQjlX0Hr+AxKh561UPIyEW4VL5ELk6rc+Y+/eLkoW0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:37223dff-ca0d-49c3-844a-df2f29a0455d,IP:0,U RL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:5d391d7,CLOUDID:8a8fc682-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 0836b2fab12211eeafd70d0b34820190-20240112 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2061126514; Fri, 12 Jan 2024 01:10:21 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 12 Jan 2024 16:09:48 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 12 Jan 2024 16:09:48 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Prguz68q3LjCG9MqgqPWdGPbNzCBn2P/2gZm7uQceYxMUXRMsv+wWmfEM95BW7dPArAvhOWXeP8j8jGMqplXGZd+HC3IMhpPkouj5rq3zkuJXAWRlC38gSKrl/V+NElUY8RJw5IGuxCyTtVFQiAzzIvR8RXmGqh1ypZdIU8M/s7Z7EUEF5KPG2YjuMF7i60IFPeGxEqYzMNkHwEKxN2/L1Ezwa+Qsw1InPaCPiSU82bDl9cFxW6LBzdeZqiC2aGYepw2vTT+RnK92yoOtlgJtw++BsbY8zK6TVBk5/8wauUQRZetJQGz5o6l3Uq+b4rHdOnSmXlMAZ5b+omTB15Jbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6lbmgbTAS7XJ67sF4PQV1B73RjbDtxh++4IhiQvU5mE=; b=Ukaapa/0QWAf/0zrnLasg/hXlrXIBwI5yp6rrke+3mCPo9wJj7ysDF9frZhUVmHR6ew3VWx5DYEO2kvfBKPY/UfqQCjRf9/sFePRjvyaqTy9owktiJDf2QUI2Yfxad4+yb8YET0mns/qsrcFn0Ob+14IANfIc22kCyqZCmd3sebnKbWKWYfJ3YyGpz2hHZlwEoWvnVjL8UJ+0RKTjV2Wr5khvtZGlHbPvVpAa1hHdjTELn9EI8+guhXMBlMIo6A1exUQoSWjHOD2F1GLl7ojRzEKeTMi+5k+6ixjiOgCfYvVebCE/v/Yi/xXIf2/aBV99xmnBgC4r8Vs3m4kRLJfag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lbmgbTAS7XJ67sF4PQV1B73RjbDtxh++4IhiQvU5mE=; b=k5GtEtYEtDKb4meykYgne0n5c6RltrINbbh/hsxQujPExJMDm0mwc3gcRIt/xNGqzt/sRUnZTQ0JDHAGOBca0W8p1EaRZShP7mcB38KJep+xWvhZcNEjA13+ffNJHfAYdGCwU5h8bOuVQpQlr7drjzC4Vi0m8BTMX+9q82hE7h8= Received: from SEYPR03MB7682.apcprd03.prod.outlook.com (2603:1096:101:149::11) by KL1PR03MB8120.apcprd03.prod.outlook.com (2603:1096:820:100::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Fri, 12 Jan 2024 08:09:45 +0000 Received: from SEYPR03MB7682.apcprd03.prod.outlook.com ([fe80::d006:ec9c:ff42:ff60]) by SEYPR03MB7682.apcprd03.prod.outlook.com ([fe80::d006:ec9c:ff42:ff60%5]) with mapi id 15.20.7181.015; Fri, 12 Jan 2024 08:09:43 +0000 From: =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= To: "robh+dt@kernel.org" , "chunkuang.hu@kernel.org" , "krzysztof.kozlowski@linaro.org" , "conor+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "jassisinghbrar@gmail.com" , "angelogioacchino.delregno@collabora.com" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?utf-8?B?Sm9obnNvbiBXYW5nICjnjovogZbpkasp?= , "linux-media@vger.kernel.org" , =?utf-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= , "devicetree@vger.kernel.org" , =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/4] dt-bindings: mailbox: Add mediatek,gce-props.yaml Thread-Topic: [PATCH v2 1/4] dt-bindings: mailbox: Add mediatek,gce-props.yaml Thread-Index: AQHaQ49X0JF8UrUl6UiOk1onHkz4dLDVyIqAgAANuwA= Date: Fri, 12 Jan 2024 08:09:43 +0000 Message-ID: <8e77cfc85ec9b6da9794f988ddc3736cf299388d.camel@mediatek.com> References: <20240110063532.14124-1-jason-jh.lin@mediatek.com> <20240110063532.14124-2-jason-jh.lin@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEYPR03MB7682:EE_|KL1PR03MB8120:EE_ x-ms-office365-filtering-correlation-id: 23e269bf-5000-4fcd-c354-08dc1345d5a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7CaU/TD+twne+Ox3snr1IX38Mec9BV/5YqSkP6MhP1EytXb2QA5QYInpt44akeDhueicIQhJ6iuRSzxq7GPhLq6Z/uh8r933StPKsZqFvXXw84pg/mnkv8oGGxIHuefb+RKMvT8GZZfhTdf7q8K3Vy7iaMJgLv4hNFOcmxNtElLz3TtU2wroZfTvESnH2f+ihCgikTvQdBYyhP++gENThOJ4DLIV/oyutYsJRqOEvwW7vVBm0gOFinl+ym6/urWirsfZ1kiCyrQEDOWCBU8+RGPH0TSoJJVyCKH/NRKIPPEIjwV/94z6DVhDBPGqk5bN6qcs1O13/qiBPSKwYgfr5mql3o1gnC5o8ju7GJ+qUyPlVC27IqAbKVj/ATZSh8E+9Doq8sFCcxc9RX6fEAOsR74BYdMzYXlkYC7r5YDFGYPQaL5F49W/98nmQoUNICGB6XkmGbr6t5vKGXePVY3XJ9kNDSf5RyLjMlIDLw5XUQqQ9o82IRkIRI24oC6+ikjSFSsonamqq0TZgVyQzeu/ixIJBnm8ptGpld8qRSgjnxyjFMhyEGOouBSWEmnwZ2VeoD5sZK4md5novR/lXQagJk/h4CEQy20zFYHFHXfr+iSY7W2YzykGIkqALHeTr/YNwn+NdoupxTAD7Pci4eJP+g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEYPR03MB7682.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(346002)(376002)(366004)(136003)(230173577357003)(230273577357003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(83380400001)(2616005)(26005)(71200400001)(41300700001)(38100700002)(66946007)(66556008)(122000001)(66446008)(76116006)(54906003)(66476007)(64756008)(6506007)(6512007)(316002)(7416002)(5660300002)(15650500001)(8936002)(2906002)(8676002)(91956017)(4326008)(110136005)(53546011)(38070700009)(6486002)(478600001)(966005)(36756003)(86362001)(85182001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R0xuQ2htNXk3NHArbmdZcHdsS0w0M1NDcy9KTVJqbHdGNlRtM3dOK0J6OExv?= =?utf-8?B?Z2FQZmxucWtlUGF5WHVOZGV2U2xsajRTR3daQklwZ1k2UlVhY2doRzlUa3RZ?= =?utf-8?B?UU1rMk5TUUN5MkVWMmFoUEc0QVJjTU1nKzBXT0FzUXpZUWNrZFFXdG9yR1cx?= =?utf-8?B?YTY0TDBMMkNYRkh0eHpSYWJNMCtkS094dHRKZVg4djlrZ2Q4MThaS2JCSW5u?= =?utf-8?B?cWRzMVgrWU55bmd1N2RNVUUvVnZCWEFsTzJodUtEa0hwWEJEVHBIRzZKd05x?= =?utf-8?B?b0duZUI5dXhXMitKa05STmM2OGdtOVYvVStnZVhtRmM1ZVNIc0RqYVl6WlBJ?= =?utf-8?B?N2U5QmpSZVdxWXVNTFdzSTFwWENmeUtpdmNoTVd5Vm5XcWpkZlhWdmlNbHd1?= =?utf-8?B?aXhUTzU1MXRRU0FKL1pNRkd6aHQzTERSSXFtK0FiQWljWWIydkRjV3lVTVNo?= =?utf-8?B?MC9IZG1YaXlCRXRrWUV4YVU2eE0xOVN0Z2JGckFOejNxMVpWem16MWg0MEVw?= =?utf-8?B?czdoQ2p6M29EYXYwbkovSENBRmNUellVYWtwS1RTanJIdnh6WGFjV2cyZmRR?= =?utf-8?B?SUM4RS9lMDBINDRUZ3lPbXdnWTJGSzhjaDg1QUt4TVRXelVuTldyT2gxM0cr?= =?utf-8?B?RUNwOFNpbWsxV0p1VVhuRXRzWmc5OWdGWWZMbUUzSnBQUnhTV0RlNzR2L1Mz?= =?utf-8?B?YUk1WldSK2h0eUZVWGxFRG1QbFJuTWJWbGIrc2txMGg1Q3FBS1ZFOXk2bTdh?= =?utf-8?B?SnM0NWw1TC9tNVpDVDZ4WEV0WjRpYjcwR0c1a3pQT1k5V3MvcHVGTGFadW1G?= =?utf-8?B?OFR2UW5VS2p0cW4xTlZRUlBRVnFKbTM1MWlwYU9UWEszT1hlSURDdWd3Y2V0?= =?utf-8?B?K090NDZDYndNZjRZb0RyN2hvUGVEdEptV1hEaFRpL3Vya0kxdXdnV2JrQlBr?= =?utf-8?B?RDVTQTEvVVJWQmsvTTJYT0pZdmpDcXJXb25WejlidjlUZ2dEZ2Z5ODAybkZ2?= =?utf-8?B?TzhsWExKZkhveEV2R01nMm9mUjR6bWphdUJUNWlTOFFWYUpBeGJnZERIY2ZD?= =?utf-8?B?RGk5OHF5bnNPdWhaTTQxcE5PUUtWV1poV3JZVXR1MlNKeCtKUWhXK1JpSStC?= =?utf-8?B?U0lkOGduS2lpNHpXdUhsZWgvRUhZSHhlZHl4OUlYTHAwMW9UZjJIMVQ2RWo0?= =?utf-8?B?TnNQWVcxZGtBRnpXekxpK3lSK01vZ1IxK1VJTVZoUmVHN3FrMmxjRXdDdzg3?= =?utf-8?B?QThnREJZRGd1cmxrclltRzNwVllXVmY5Vk03eEFPL2x4K3VzWFFaSmI5N0du?= =?utf-8?B?M09pb2tBdkExNGswdG9xQmUrYTNKTTl5ejhaalJ1bFpFS3BTMWJLdjhsSHpr?= =?utf-8?B?dEI3QXNhUFJOa1FHRXB6K1VCR21ISm00ZndCeWpYVlJEa2RsTGRlTEVLUW5B?= =?utf-8?B?L2h6RkhqZFhIdldndGlneFkrNktoZ1lyemg1dWtEdm9ybmVuaDBnMnNwbW9j?= =?utf-8?B?Mnpidkw3aFF5dERoRXc5cXpWckpsQm5nazZQdW5Fekp6YU5XZVVtRUd6MW1w?= =?utf-8?B?dVptelF3enBBZHRlUm1Oa2pYRHpRMHhpOForWXFibytsRUtXM0hiRDdpWm03?= =?utf-8?B?UjkrV3dRZ1lIRitUV25SZ05iN05vQjVxY3lUc1BBRk5QY0E5dDIvZEZDREFt?= =?utf-8?B?NEQwMVVaSnJTbHJnbnZTUGhCbGFTczJsalVMdS9QamRWUzJwMmJyOVpVUEp0?= =?utf-8?B?RG9ObDgrUkJVYVF6NkFHTnlmdTlpMXczeFhaaEJJRjUwVVovU0dlTGkycXFt?= =?utf-8?B?OXNFTFZqK0NSRkZJUDIwNUVQZVkzN1NySGRnSG9pUk82bFVzZW1JSUEvZTJP?= =?utf-8?B?MmZCRjlTUXdNZnFJWG11WEtHUTFsZFNybGY4dmt3VWV5ZVBPTWFPLzFWSUZy?= =?utf-8?B?N1MzSlZIWFF1RlJUV2dRbTFkdjluS0M0YzRkRHRLY0RhTUdqR2RFd3Jpa25H?= =?utf-8?B?MDZmL1pIUEhkVVluaHdXM1lEQjB1Qi9FdUUrTkRoMWMrSStNRU5oUXlOaFFR?= =?utf-8?B?MFVnS0g2ZUlSSExDYXo3dEd2U3licVE1UWhLcUx0cU9XM1loK2s1VEkwWEdh?= =?utf-8?B?Z1piSmsvTGJqTXArcm1GZGh1UUFNcWVmZnJMYnViSVRqMGFHRVRmaUVKampW?= =?utf-8?B?RHc9PQ==?= Content-ID: <819AE56B094F354A9217A99A194EA0B5@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEYPR03MB7682.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23e269bf-5000-4fcd-c354-08dc1345d5a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 08:09:43.7092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BFO8HGXazLw/nAm6BqpgfiBQ65jwsANMGl9Q8xTAHWIPzfydl4YVLCn07L3gEEohFu2qsEUlDVG7oC6ex0OyB2VWx4WgFRzAI3FUbeJyajo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB8120 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240112_001028_028856_3941A982 X-CRM114-Status: GOOD ( 26.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for the reviews. On Fri, 2024-01-12 at 08:20 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 10/01/2024 07:35, Jason-JH.Lin wrote: > > Add mediatek,gce-props.yaml for specific GCE properties for both > > Mailbox Providers and Consumers. > > > > Signed-off-by: Jason-JH.Lin > > --- > > .../bindings/mailbox/mediatek,gce-props.yaml | 41 > +++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > > > > diff --git > a/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > b/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > > new file mode 100644 > > index 000000000000..aac776b74e88 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > props.yaml > > @@ -0,0 +1,41 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/mailbox/mediatek,gce-props.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek Global Command Engine common propertes for both > Mailbox Providers and Consumers. > > That's way too long. Please observe coding style wrapping. Just > MediaTek > Global Command Engine Common Propertes > (pay attention to capitalization) > OK, Thanks for the fixing title text. I'll change it. > > + > > +maintainers: > > + - Houlong Wei > > + > > +description: > > + The Global Command Engine (GCE) is used to implement a Command > Queue (CMDQ) > > + driver using the Linux Mailbox framework. The GCE is an > instruction based, > > + multi-threaded, single-core command dispatcher for MediaTek > hardware. > > + We use GCE Mailbox binding to define GCE core properties for GCE > Mailbox Provider. > > + A device that uses the CMDQ driver to confige its hardware > registers by requesting > > configure? Yes, that typo didn't scan out. Thanks for the correction. > > > + the Linux Mailbox Channels in the GCE Mailbox Controller is a > Mailbox Consumer. > > + This binding defines the common GCE properties for both Mailbox > Providers and Consumers. > > Last four sentences: a lot of text yet absolutely no meaning. I still > do > not understand why same property is shared between provider and > consumer. OK, I'll add more description for that. The main reason is that the property is used for GCE HW event ID corresponding to a HW event signal. If the provider wants to get or set an event value of the event ID by operating GCE HW register. It needs to know what the event ID is. > > Also, wrap according to Linux coding style. > OK, I'll shrink them to less then 80 columns. > > + > > +properties: > > + mediatek,gce-events: > > + description: > > + Each gce-events is an event id corresponding to a specific > hardware event > > + signal sent to GCE. The event id is defined in the GCE > header > > + include/dt-bindings/gce/-gce.h of each chips. > > + CMDQ client drivers have two usage of GCE event signals, > > + one is sfotware tokens and the other is hardware events. > > + Software tokens refer to GCE event signals triggered by > drivers. > > + e.g. software drivers append GCE commands to set a GCE event > after specific > > + GCE commands. Or CMDQ client driver uses the CPU to write > the event id > > + into GCE register to trigger the GCE event corresponding to > the event id. > > + Hardware events refer to GCE event signals triggered by > hardware engines. > > + e.g. When OVL fetches all the data in the frame buffer, OVL > will send > > There is no full stop before "e.g." and no new sentence. Please run > this > through grammar check, like Google, ChatGPT or human. > OK. Thanks for the suggestion. I'll correct them. Regards, Jason-JH.Lin > > + a frame done irq and send a frame done GCE event via > hardware bus directly > > + at the same time. > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 1024 > > > Best regards, > Krzysztof > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel