From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1D69C001DF for ; Tue, 8 Aug 2023 14:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5z20TJcNZbiY3j7spQlxK0K40SoR/eWXPKKchWwwT5M=; b=iMGPMW5wDKPQal 4uxBubITwdPEg3hrp4ME3dn7Nvx91lh3L0BYXmEtn767wWuzmK+g9eilK/SU0G3Y/GwcWAdJOXQMC jR0OY9IUXAnL1s5Jog+cLYmOwkitnFx54MswhzorZOCLYOx/ugDj9IprU9dNTPcH421choLZG4gP7 UTj81vrA2v7VFLGg5A2wgVb8YebZRizP4JfjS63W7FVuVaHEx9bcB9wEIrtgtrrEjvU+yDA0nZN0T BPTlIusxYRuIo+5+F7TutH/14oMsaHxYGr5V1wi90hrFM7UliUwov06V7FMMkUqc7McDzkd5OqIWj h824HTlxjKKyAKh4GbUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTO5x-002mQA-0G; Tue, 08 Aug 2023 14:54:01 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTO5u-002mPi-0x for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 14:53:59 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52256241c50so8259984a12.3 for ; Tue, 08 Aug 2023 07:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691506434; x=1692111234; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q6MY1hiBmbwXLoucjEj2Xi2SFMUgMZzIdibN/5/2L+I=; b=I730GYb/nimgEnWk5DAPEpb+5x5xFRmgXdDJHKtFmkgxwm9BLcM3M3Lgb3VqMLePC4 vIXQWFCp1ZUKxz1pdyahh6wS5F60cR297nsluMMSYAi124o/sesA3LzKUtK7yCgIG9Bk qCksDhK5ucxZfWtoiV2kkUsf0ZDLbtkzbvnRsE+FiRHH+/zMlIauTjy6sZjlsxARZk4n Tx/ae9C3Ar89bGFrEjMawXmeqpPyjzGjbOMIuOEeMe4o8/XuBwjIL9Syu+wm9dgX2Sca 45beBJsLcojSYMpe/PHALvOY5VF+x0yC3w/EvyAte/L/YcbFkED5aaS+eepO3p5xFUg4 Gs4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691506434; x=1692111234; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6MY1hiBmbwXLoucjEj2Xi2SFMUgMZzIdibN/5/2L+I=; b=dp/3lQKdLAqczHDDpeh+HT86QIxqg2X7fBMyea79m0yZPl+2S78r36RFIJLqlnYU/3 Q1Ja4Y1VLdDQDOfuYvHe090mYMikfxmlWrkGxACuK2CqRJsjPp0KkcfMDvtnPhx1PuHE BepNAA+YLBf3UqeXDj6nyAvnZfKFUapXzzPWjblH+G40MAXyzee+nZLb0cCFPH5dhWFq 029jTfgXs5ze8+gKDasOxV/N6iat7l/k1wU1q4ghanrQzXE3GsvoBiK+nNfDrXsQpdDT 3O4PU9hlbDXVqL37ES2QVJF5Hb28MN2emLkRoxtNEDes2LDxv/c+jydgHIZcfbvcEIz4 m/tw== X-Gm-Message-State: AOJu0Yyy0AZFMmtcYEmvmsaE4NGFeOh/lrdI+AMNrBwgbuCdbbwkbKlw pWC2zpyfnoN9PJP4NfbKf8PyVA== X-Google-Smtp-Source: AGHT+IEFM3DwvG4gSvRW8WGApgoleljA2c2Cr/zQIjyrhjF0UV2hAUM2hKy+et7OFD1S77hBApF2qg== X-Received: by 2002:a17:906:54:b0:999:26d3:b815 with SMTP id 20-20020a170906005400b0099926d3b815mr13144104ejg.64.1691506434441; Tue, 08 Aug 2023 07:53:54 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id rk22-20020a170907215600b00982a92a849asm6796311ejb.91.2023.08.08.07.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 07:53:53 -0700 (PDT) Message-ID: <8e7cf088-e206-746d-0360-16479b1a33c3@linaro.org> Date: Tue, 8 Aug 2023 16:53:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property Content-Language: en-US To: Md Danish Anwar , Conor Dooley , MD Danish Anwar References: <20230807110836.2612730-1-danishanwar@ti.com> <20230807-euphemism-trailing-ef4130dc7437@spud> <910a4a98-712a-5517-5a5b-ffb962f83463@ti.com> <1ade44f5-b3d1-dcde-6819-9e944f3b115d@linaro.org> <5ca41ad1-4f42-f71a-4b5f-f2b6def42cb1@ti.com> From: Krzysztof Kozlowski In-Reply-To: <5ca41ad1-4f42-f71a-4b5f-f2b6def42cb1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_075358_381428_CEC47752 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: srk@ti.com, devicetree@vger.kernel.org, Conor Dooley , linux-omap@vger.kernel.org, vigneshr@ti.com, Mathieu Poirier , Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, nm@ti.com, Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 12:57, Md Danish Anwar wrote: > On 08/08/23 3:48 pm, Krzysztof Kozlowski wrote: >> On 08/08/2023 11:44, Md Danish Anwar wrote: >>>>> properties: >>>>> compatible: >>>>> @@ -171,6 +181,9 @@ examples: >>>>> <0x22400 0x100>; >>>>> reg-names = "iram", "control", "debug"; >>>>> firmware-name = "am65x-pru0_0-fw"; >>>>> + interrupt-parent = <&icssg0_intc>; >>>>> + interrupts = <16 2 2>; >>>>> + interrupt-names = "vring"; >>>>> }; >>>> >>>> These examples would probably be more helpful if they used the >>>> appropriate defines, no? >>>> >>> >>> PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't >>> use GIC so defines from arm-gic.h can not be used here. These are specific to >>> PRUSS INTC. >>> >>> I think these example are OK. Please let me know if this is OK to you. >> >> But isn't "2" type of the interrupt? >> >> Best regards, >> Krzysztof >> > > As per the description of interrupts property in ti,pruss-intc.yaml [1] > > Cell 1 is PRU System event number, cell 2 is PRU channel and cell 3 is PRU > host_event (target). None of them is type of interrupt. So that's why they all > are hardcoded. I don't think we can use IRQ_TYPE macros here. OK, thanks for clarifying this. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel