From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15171C433EF for ; Fri, 22 Apr 2022 02:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7E5LYAg7a5nbM2hBOWjrGdMUl6RIzw5MlHpUpOeWqsI=; b=ARmKiKRETOUpHm xT8dy2Mz7GlKlWpbB448c6OeCFxgFS0TywAW5G0AxoXDZHwkyGlyE5dz6t6Xe8njpcfPFL91QQjlq 2OKuIHEfWXsG6zdyu4vBku8LxRZWUyCQEGnk2CLfr7xt307j5nFZV4PCHIzjcLNVWQgt5JVhdEajQ SwLDitYr9ClzCBToiC/voPdaMsU0sufjqRNUw4T9VYyXJ+Hy8faAiomxkaasce99RX+MoH8kKBER+ KTTt8Q9OdJXv8KuyrJfIIxsyCZO8znLKTyPEIFZcOYcSD5XzxGuDOkogleS99sBEJ7Rfc06PuI6yq MNup/DPT6xCCmMKFLkDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhiar-00Feje-3a; Fri, 22 Apr 2022 02:00:21 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhian-00FeiT-Tu for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 02:00:19 +0000 Received: by mail-pg1-x52b.google.com with SMTP id h5so6161673pgc.7 for ; Thu, 21 Apr 2022 19:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=64m28fBryaa/0LokFVk4B8cMevkIz2gMYP82HTmvutw=; b=Rcr/31RNS0r5SCKGGMwWmIxQv8IW1Y4db6TclnbUeN0Kw20gfWTdHHjDvJZ7SFnvXB IUXtYwmFCB/ovV8mGOj1s+xXqA7SDoW74lU5hEGBAFLklRFInVbUeRWJTRPlNzBOwUE4 gjH1CyHoRSz10/6qCb3H0QnuyorJ+ozpBg42jdEWaxAKAf9yMtu7Ch8pX1tZ6vRYlX3p utR+xraG0gjPS5q7+SxccJq0L0xA5B2gOe/FsM5vFq+riSDUf/OZf9RncPAwKiM2ITtV 5RiGkTT37O03nvst0BlN9CLoHOEmBoi3SVLMLr38nsBzPkJpyBFVzk6O+lRUfxo6lxll 6uVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=64m28fBryaa/0LokFVk4B8cMevkIz2gMYP82HTmvutw=; b=fCrv1fPOaDm1plLAk8dLeFrNVPeBOJizgtW9SqKA2ULLxTwzH3Lw8hZbJbKjAwBGJn X7aJQP/RPtZPIdCN3eYjlKRc6nCSpctl5TgvPDGRtVpVRD5+LaRQ39lyR1qQ17atzOJx lf7SW8si++rb0rEV4MhAjMhga2y8cIAFE0PoLnZnb1zUqS9nonvELJTU4OjIxfA4o5Ty bOBufDnm0bEzPGD3pF7Odp8Gv0GeZlFEOYnzYBQw/x6boMekamHIwiOe9aeo3y4FXDkD TuiBXH95Bnwb0UC5qregMqEpWBG6o6FUR50iFLz3pzeUTByNONszhWqAawJagt8OeSBL ouOQ== X-Gm-Message-State: AOAM530d+NyFniJSyDwTK3nWPDesUDP2WTObX73gGRrV/+i5QOskWij8 UoTOojnTEkYKZ2RExiAhYF8= X-Google-Smtp-Source: ABdhPJzFAWyBCdn951bBPGFgOuZyTdWDZQBjgBFBLLXESwJ8SnJjeDwVU119HyzOasnAI4M2loDWdA== X-Received: by 2002:a63:a551:0:b0:3aa:5150:a94a with SMTP id r17-20020a63a551000000b003aa5150a94amr1987597pgu.144.1650592816370; Thu, 21 Apr 2022 19:00:16 -0700 (PDT) Received: from [192.168.1.100] ([159.226.95.33]) by smtp.gmail.com with ESMTPSA id y9-20020aa79429000000b0050ad02027d9sm396208pfo.197.2022.04.21.19.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 19:00:16 -0700 (PDT) Message-ID: <8e893363-3e47-2abe-7111-b3fb0888d4fc@gmail.com> Date: Fri, 22 Apr 2022 09:59:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage Content-Language: en-US To: Stephen Boyd , Abel Vesa , Dong Aisheng , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220422012059.52267C385A5@smtp.kernel.org> <20220422013317.30362-1-linmq006@gmail.com> <20220422014411.4F96BC385A7@smtp.kernel.org> From: Miaoqian Lin In-Reply-To: <20220422014411.4F96BC385A7@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_190018_016223_D377513F X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/4/22 9:44, Stephen Boyd wrote: > Quoting Miaoqian Lin (2022-04-21 18:33:16) >> If the device is already in a runtime PM enabled state >> pm_runtime_get_sync() will return 1. >> >> Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() >> fails, so use pm_runtime_resume_and_get() instead. this function >> will handle this. >> >> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") >> Signed-off-by: Miaoqian Lin >> --- > Please don't send patches as replies to previous versions of the patch. Sorry, I thought I should keep them in one thread, to provide the context for other people to follow up. Am I suppose to resend it? >> drivers/clk/imx/clk-scu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c >> index 083da31dc3ea..2044e62980e3 100644 >> --- a/drivers/clk/imx/clk-scu.c >> +++ b/drivers/clk/imx/clk-scu.c >> @@ -528,7 +528,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev) >> pm_runtime_use_autosuspend(&pdev->dev); >> pm_runtime_enable(dev); >> >> - ret = pm_runtime_get_sync(dev); >> + ret = pm_runtime_resume_and_get(dev); >> if (ret) { >> pm_genpd_remove_device(dev); >> pm_runtime_disable(dev); >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel