From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] drm/mediatek/hdmi: Simplify with dev_err_probe
Date: Mon, 13 Jan 2025 14:48:09 +0100 [thread overview]
Message-ID: <8e8e3eca-dee0-43ab-95d9-aebd636245c7@collabora.com> (raw)
In-Reply-To: <59f8a02e-a716-40a8-bf73-111ad2a7af79@linaro.org>
Il 13/01/25 14:07, Krzysztof Kozlowski ha scritto:
> On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote:
>> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto:
>>> Use dev_err_probe() to make error code and deferred probe handling
>>> simpler.
>>>
>>
>> That's already done in [1] so you can drop this commit.
>>
>> [1]:
>> https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com
>>
> Eh, this was first in v3 in the middle of Dec, so why you cannot get it
> merged first? Creating such 34-behemoths causes simple cleanups to
> unnecessarily wait.
>
Getting the series partially merged is okay for me, no complaints about that,
but then ... in v4, there are two minor comments to address (one of which
is a one-char nitpick!) that might as well be done while applying, depending
on what CK thinks about that, so there's no real benefit in getting 28 commits
out of 34 picked instead of, well, just everything...
Cheers!
Angelo
next prev parent reply other threads:[~2025-01-13 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 13:47 [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args Krzysztof Kozlowski
2025-01-12 13:47 ` [PATCH 2/2] drm/mediatek/hdmi: Simplify with dev_err_probe Krzysztof Kozlowski
2025-01-13 12:41 ` AngeloGioacchino Del Regno
2025-01-13 13:07 ` Krzysztof Kozlowski
2025-01-13 13:48 ` AngeloGioacchino Del Regno [this message]
2025-02-12 20:33 ` Krzysztof Kozlowski
2025-02-13 10:07 ` Krzysztof Kozlowski
2025-02-13 10:39 ` AngeloGioacchino Del Regno
2025-01-13 12:41 ` [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args AngeloGioacchino Del Regno
2025-01-13 13:05 ` Krzysztof Kozlowski
2025-01-13 13:58 ` AngeloGioacchino Del Regno
2025-01-13 14:27 ` Krzysztof Kozlowski
2025-01-13 14:31 ` Krzysztof Kozlowski
2025-01-13 15:02 ` AngeloGioacchino Del Regno
2025-02-13 6:39 ` CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8e3eca-dee0-43ab-95d9-aebd636245c7@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox