Re: [PATCH v3 0/2] Add Meta (Facebook) SanMiguel BMC (AST2620)

[Andrew Jeffery <andrew@codeconstruct.com.au>]

Hi Potin,

On Wed, 2026-03-11 at 14:19 +0800, Potin Lai wrote:
> Add Linux device tree entries for Meta (Facebook) SanMiguel specific
> devices connected to the AST2620 BMC SoC.
> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
> Changes in v3:
> - Update the model name to "Facebook SanMiguel BMC".
> - Remove CP2112 and downstream IOEXP nodes as the upstream driver
>   is not yet available.
> - Remove the following EEPROM nodes until the bus numbers and
>   addresses are confirmed:
>   - 3-0051: HMC FRU EEPROM
>   - 3-0052: HPM0 FRU EEPROM
>   - 3-0053: HPM1 FRU EEPROM
> - Change the compatible property of the following EEPROM nodes
>   from 24c02 to 24c128:
>   - 5-0050: SMM FRU EEPROM
>   - 9-0050: PDB FRU EEPROM
>   - 13-0055: SMM EXT FRU EEPROM
> - Fix the smm_temp node address typo (0x4e -> 0x48).
> - Remove nodes that no longer exist in the latest board design:
>   - 19-006f: RTC (nct3018y)
>   - 9-0075: IO expander (pca9555)
> - Update linenames to match the reference design:
>   - B0_M0_AIC_USB_EN-O -> B0_M0_CPU_L0_RST_IND_L-O
>   - B0_M0_BRD_ID_2-I -> B0_M0_BMC_TO_GPU_MCU_I2C_EN-O
>   - B1_M0_AIC_USB_EN-O -> B1_M0_CPU_L0_RST_IND_L-O
>   - B1_M0_BRD_ID_2-I -> B1_M0_BMC_TO_GPU_MCU_I2C_EN-O
>   - IOX_GPIO_P16_TP -> USB2_BMC_HUB2_RST_L-O
>   - I2C_PDB_ALERT_L-I -> X86_TPM_RST_SEL_L-O
> - Remove unexpected or unsupported properties from SSIF and IOEXP
>   nodes.
> - Change all status values from "ok" to "okay" for consistency.
> - Link to v2: https://lore.kernel.org/r/20260203-sanmiguel_init_dts-v2-0-6a5682c32b38@gmail.com

Can you please discuss these proposed changes in the context of my
reply to Kevin below?

https://lore.kernel.org/all/d7794f74b26bbc1ee0a70e39c5671acc018f80eb.camel@codeconstruct.com.au/

Thanks,

Andrew