Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Artem Novak <artem122novak@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
	florian.fainelli@broadcom.com, hemanth.selam@gmail.com,
	john.garry@linux.dev, kraxel@redhat.com,
	linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, rjui@broadcom.com,
	sbranden@broadcom.com, ulfh@kernel.org
Subject: Re: [PATCH v2] mmc: bcm2835: restore scatterlist after DMA setup failure
Date: Sun, 22 Nov 2026 13:39:01 +0100	[thread overview]
Message-ID: <8ea10aa4-71fd-4894-b80f-e94a41f7e4f3@gmx.net> (raw)
In-Reply-To: <20261122075814.162099-1-artem122novak@gmail.com>

Am 22.11.26 um 08:58 schrieb Artem Novak:
> The DMA preparation path shortens the final scatterlist entry
> to reserve space for FIFO drain words.
>
> If DMA mapping or descriptor preparation fails, the request
> falls back to PIO, but the shortened scatterlist entry is left
> unchanged. As a result, the PIO transfer may omit part of the
> data, potentially causing corrupted or incomplete I/O.
>
> Restore the entry's original length and clear drain_words
> before returning to the fallback path.
>
> This issue was found while investigating a kernel panic on
> my Raspberry Pi server.
>
> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
> Signed-off-by: Artem Novak <artem122novak@gmail.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>


      reply	other threads:[~2026-11-22 12:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  5:10 [PATCH] mmc: bcm2835: restore scatterlist after DMA setup failure Artem Novak
2026-11-14  9:50 ` Stefan Wahren
2026-11-14 18:16   ` Artem Novak
2026-11-14 18:32     ` Stefan Wahren
2026-11-22  7:58       ` [PATCH v2] " Artem Novak
2026-11-22 12:39         ` Stefan Wahren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ea10aa4-71fd-4894-b80f-e94a41f7e4f3@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=artem122novak@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=hemanth.selam@gmail.com \
    --cc=john.garry@linux.dev \
    --cc=kraxel@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox