From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFD30CAC5B8 for ; Mon, 6 Oct 2025 16:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5w7gvHcMRhTYb/A+IePZt5v4pvg+0ST8/ZoHNlbWB9c=; b=TNvr9MQaqpwOxOn+3zIpUWrx0N V2RraTfLXzo4+ejUVHspbqLS076ddXQvG5UXTAek98+2HHvYGHSHuwY+SRuhDiLvuBy3EBswIY5gp Dv/t6uHVjCMAcOpYodYp/FzMhDdCjFd6KskhDfbRv7e9hjrfMBP2PX1i1ObGaGaHrtD3G1C3BtyiA yfRxWgyCZQcyM8bcNKFP6VaZuJDjDcuT5H68n0lE/gaxdJj7s4qYr/Gz3b1dFX1hrP9ynTrQef1wd NGJqGW+6a74husQpZC1TQsY1BnhDNUi2BDWZcdAaF5ZNeyR1YkWYk9UnBmklKQc7sSmMjOTjJhtU1 pbzmCLXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5ndA-00000000L5J-1IAf; Mon, 06 Oct 2025 16:00:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v5nd6-00000000L48-41Lr for linux-arm-kernel@lists.infradead.org; Mon, 06 Oct 2025 16:00:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 422A21515; Mon, 6 Oct 2025 08:59:56 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 577313F738; Mon, 6 Oct 2025 08:59:58 -0700 (PDT) Message-ID: <8ecfb414-dc3d-4e66-90cf-427b22d4a949@arm.com> Date: Mon, 6 Oct 2025 16:59:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 23/29] arm_mpam: Add mpam_msmon_read() to read monitor value To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-24-james.morse@arm.com> <1344b395-66aa-4714-b1fc-9c970c0fd0bf@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <1344b395-66aa-4714-b1fc-9c970c0fd0bf@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251006_090005_566729_109871FA X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 11/09/2025 16:46, Ben Horgan wrote: > On 9/10/25 21:43, James Morse wrote: >> Reading a monitor involves configuring what you want to monitor, and >> reading the value. Components made up of multiple MSC may need values >> from each MSC. MSCs may take time to configure, returning 'not ready'. >> The maximum 'not ready' time should have been provided by firmware. >> >> Add mpam_msmon_read() to hide all this. If (one of) the MSC returns >> not ready, then wait the full timeout value before trying again. >> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >> index cf190f896de1..1543c33c5d6a 100644 >> --- a/drivers/resctrl/mpam_devices.c >> +++ b/drivers/resctrl/mpam_devices.c >> @@ -898,6 +898,232 @@ static int mpam_msc_hw_probe(struct mpam_msc *msc) >> +static int _msmon_read(struct mpam_component *comp, struct mon_read *arg) >> +{ >> + int err, idx; >> + struct mpam_msc *msc; >> + struct mpam_vmsc *vmsc; >> + struct mpam_msc_ris *ris; >> + >> + idx = srcu_read_lock(&mpam_srcu); >> + list_for_each_entry_rcu(vmsc, &comp->vmsc, comp_list) { > > This can be list_for_each_entry_srcu(). (I thought I'd already commented > but turns out that was on another patch.) > >> + msc = vmsc->msc; >> + >> + list_for_each_entry_rcu(ris, &vmsc->ris, vmsc_list) { > > Also here. Yup - thanks I missed these. Fixed. I bet I went cross-eyed between here and mpam_apply_config() as they are structurally similar. Thanks, James