From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8CBBCAC587 for ; Thu, 11 Sep 2025 15:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dtiwqfLbp3GtprxteMFiX6t05bVcKl84hrmmLTqYYlY=; b=jEhwp8vLNokg1gNUcDjyTR0F6I 9SZo/Tww9XS7pSFFu5Ul5gT2zTjUBwXvCBixueBWuJ93ntdIDZRNa352MTmczEElDV1SI40KmhUc/ l0qfarbdqQ4c1Zbjrhqw1EEQk1ukiSi4U7QohBi3eSCqdggaAeiA3E9nYOzty6e5WMgDUVLixd9wz 6oig1Bnn7i7CRZXLd21haNGFQ3fJDBzsXKJf5svQgzYMkDDNiqpG1oUY9Mxw9T70T/xFYjeNr87ap +mYxhbnmaMr92ntNV2bEFU453QmRLs4GnJe50C8VcG2/IJCw3Jtc5BUNFPQ89yEBm1x/eCDU4vLF0 tjXVuxuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwjMy-00000003wZt-1dNM; Thu, 11 Sep 2025 15:37:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwjMv-00000003wZU-3m2T for linux-arm-kernel@lists.infradead.org; Thu, 11 Sep 2025 15:37:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69F29153B; Thu, 11 Sep 2025 08:37:44 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3E3363F63F; Thu, 11 Sep 2025 08:37:48 -0700 (PDT) Message-ID: <8ed9fbe9-1075-4abb-91d0-20203906a4dc@arm.com> Date: Thu, 11 Sep 2025 16:37:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/29] arm_mpam: Probe the hardware features resctrl supports To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-14-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250910204309.20751-14-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250911_083753_979992_3286B9C7 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 9/10/25 21:42, James Morse wrote: > Expand the probing support with the control and monitor types > we can use with resctrl. > > CC: Dave Martin > Signed-off-by: James Morse > --- > Changes since v1: > * added an underscore to a variable name. > > Changes since RFC: > * Made mpam_ris_hw_probe_hw_nrdy() more in C. > * Added static assert on features bitmap size. > --- > drivers/resctrl/mpam_devices.c | 151 ++++++++++++++++++++++++++++++++ > drivers/resctrl/mpam_internal.h | 53 +++++++++++ > 2 files changed, 204 insertions(+) > [snip] > > spin_lock(&partid_max_lock); > diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h > index 4cc44d4e21c4..5ae5d4eee8ec 100644 > --- a/drivers/resctrl/mpam_internal.h > +++ b/drivers/resctrl/mpam_internal.h > @@ -112,6 +112,55 @@ static inline void mpam_mon_sel_lock_init(struct mpam_msc *msc) > raw_spin_lock_init(&msc->_mon_sel_lock); > } > > +/* > + * When we compact the supported features, we don't care what they are. > + * Storing them as a bitmap makes life easy. > + */ > +typedef u16 mpam_features_t; > + > +/* Bits for mpam_features_t */ > +enum mpam_device_features { > + mpam_feat_ccap_part = 0, > + mpam_feat_cpor_part, > + mpam_feat_mbw_part, > + mpam_feat_mbw_min, > + mpam_feat_mbw_max, > + mpam_feat_mbw_prop, > + mpam_feat_msmon, > + mpam_feat_msmon_csu, > + mpam_feat_msmon_csu_capture, > + mpam_feat_msmon_csu_hw_nrdy, > + mpam_feat_msmon_mbwu, > + mpam_feat_msmon_mbwu_capture, > + mpam_feat_msmon_mbwu_rwbw, > + mpam_feat_msmon_mbwu_hw_nrdy, > + mpam_feat_msmon_capt, > + MPAM_FEATURE_LAST, > +}; I added a garbled comment about this for v1. What I was trying to say is that I don't think this quite matches what resctrl supports. For instance, I don't think mpam_feat_ccap_part matches a resctrl feature. Thanks, Ben