From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Badhri Jagan Sridharan" <badhri@google.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Amit Sunil Dhamne" <amitsd@google.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: exynos: gs101: Enable AVS APDO
Date: Thu, 26 Feb 2026 07:51:06 +0100 [thread overview]
Message-ID: <8eeadb7a-5075-4444-8714-45e589dda47f@kernel.org> (raw)
In-Reply-To: <20260226061053.2596167-1-badhri@google.com>
On 26/02/2026 07:10, Badhri Jagan Sridharan wrote:
> Enable USB PD SPR AVS for gs101 by adding SPR AVS APDO to the sink caps
> pusblished by gs101.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> Depends-on:https://lore.kernel.org/lkml/20260226055311.2591357-1-badhri@google.com/
Really, how? If it depends on that, it is wrong and cannot be applied.
DTS cannot depend on the hardware. NAK.
>
> arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> index 93892adaa679..5a689be61432 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> @@ -174,6 +174,7 @@ connector {
> | PDO_FIXED_HIGHER_CAP
> | PDO_FIXED_DUAL_ROLE))
> PDO_FIXED(9000, 2200, 0)
> + PDO_SPR_AVS_SNK_APDO(3000, 3000)
> PDO_PPS_APDO(5000, 11000, 3000)>;
> sink-vdos = <VDO_IDH(1, 1, IDH_PTYPE_PERIPH, 0,
> IDH_PTYPE_DFP_HOST, 2, 0x18d1)
>
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> prerequisite-patch-id: 4dacd8bc550e317d67134d030814765fb9f4c6e1
> prerequisite-patch-id: e863378fc602b6bee2e9fdd8c568003c00b2a38e
> prerequisite-patch-id: 202a9e1e9cf27a0b9ff7ebea76eb45cdac2cb581
> prerequisite-patch-id: f3817c560d0e701d7499fa1fb9ee40d22816c09e
> prerequisite-patch-id: c071913307a6eaa417d1345485d7a9c165d40834
5 patches here. This is confusing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-26 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 6:10 [PATCH v1] arm64: dts: exynos: gs101: Enable AVS APDO Badhri Jagan Sridharan
2026-02-26 6:51 ` Krzysztof Kozlowski [this message]
2026-02-26 6:51 ` Krzysztof Kozlowski
2026-02-27 6:51 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eeadb7a-5075-4444-8714-45e589dda47f@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=amitsd@google.com \
--cc=andre.draszik@linaro.org \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox