From: Michal Simek <michal.simek@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rosen Penev <rosenp@gmail.com>,
linux-sound@vger.kernel.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] ASoC: xilinx: formatter_pcm: use more devm in probe
Date: Wed, 12 Aug 2026 13:22:33 +0200 [thread overview]
Message-ID: <8ef668c5-e66b-4750-9fb9-54d8025a9c90@amd.com> (raw)
In-Reply-To: <c22c308d-ce38-4327-a9d9-19ea995584e5@sirena.org.uk>
Hi Mark.
On 8/12/26 12:16, Mark Brown wrote:
> On Wed, Aug 12, 2026 at 07:58:23AM +0200, Michal Simek wrote:
>>
>>
>> On 8/11/26 20:50, Rosen Penev wrote:
>>> Use devm_clk_get_enabled() to let the clock be enabled automatically
>>> and cleaned up on unbind, dropping the manual clk_prepare_enable() and
>>> clk_disable_unprepare() calls in probe and remove. As a result, move the
>>> clk struct member into probe, which is the only place it's used.
>
> Please delete unneeded context from mails when replying. Doing this
> makes it much easier to find your reply in the message, helping ensure
> it won't be missed by people scrolling through the irrelevant quoted
> material.
Do you mean patch content in this case?
Thanks,
Michal
next prev parent reply other threads:[~2026-08-12 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 18:50 [PATCHv2] ASoC: xilinx: formatter_pcm: use more devm in probe Rosen Penev
2026-08-12 5:58 ` Michal Simek
2026-08-12 10:16 ` Mark Brown
2026-08-12 11:22 ` Michal Simek [this message]
2026-08-12 16:00 ` Mark Brown
2026-08-12 6:13 ` Vincenzo Frascino
2026-08-12 16:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef668c5-e66b-4750-9fb9-54d8025a9c90@amd.com \
--to=michal.simek@amd.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox