From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C33ACC2BB41 for ; Wed, 17 Aug 2022 08:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4AFV4eJIluYLsvZPg9JUz0wR3jPPBHPQ4noy9C8UHl4=; b=Ja6u0wjwGX72MjiQNChWDaoPH9 st/QJGdB9/W9PfFYKFW93ZLUbRfVW43nTJLCvNgIMKA6j8h0miFWkveotjLwSpvdbFfT5tTQh4jxc ANlUsyFKKHiuoYBQVBWE4zYpZuqm3ruvKClV0yqtk5aKKD2EQ2qLQoOsiG+S4M3fvR9m6P4iZU3rX DLRN7eUknYj/+eYui+CSUBJD1p5dSNxLuNWaoFnHWtbdUlA93aRpip6wPZohAAF9RbSqncfm9Z4MH ziPWJnBDaCsGBPQTBZ64VzaT5AMebui/em1NQegMZzZgc5vhao3qsHzyJo3LlLJnkLQKZHs1VhIgH +kUF1K4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOEaJ-00FRmB-64; Wed, 17 Aug 2022 08:39:31 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOEaF-00FRio-Rk for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2022 08:39:29 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F40A85C015C; Wed, 17 Aug 2022 04:39:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 17 Aug 2022 04:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660725566; x= 1660811966; bh=1XgksyqqOpjmG5LRrLM6xA1+iwp2OMLWZWBQsySSgeI=; b=s Xx2BlpjDk+EXCp1fpwwAcWPw0H6ob4T8XOP1COeMB7VEi4LH30S7gj6lxZn69oHo p88YfKLxTYFU+S+bogQUDV0Ko/efYev4g1RnuDXwY0rdC1ubkgb0zTKihwnFMdw5 7prlhqwTbRooLsksUfZpXU44jjJdq63EhwSRE6psISFn2fIsJFlfe8cd51J9rO2G NNHICZNlSwlAadCjOYDKz8nFLJIM3hnuWgiCcDCoIVxDIO+y2ATaHnmPXGL01Lv5 0D8pKJNzAdTAiHwpNkVuEbYA1q1ojf5qJqH5PdrLZU1yLJlN4B/m0vgNTcs2Zkhr nvBnrIWIfi3YWujqwG2WA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660725566; x= 1660811966; bh=1XgksyqqOpjmG5LRrLM6xA1+iwp2OMLWZWBQsySSgeI=; b=b ntu4LsVEXqMEwtw6BIeHooL5R5nY/EuiUxc5IUfzHyYkMq0S+mdvIUl4cvdadMqx +YNdCx7eQOHidWKUdu1brtHqZSyjgbXmGm600L3qUXkrqORV0owMLYXgCgc4C9GY v/WxZAQ0PUi657cS3ACtxO0McTKvPq4pB2u+qRV4FQ8+r/+51gq5/YvcUN4ynNkT yoODzCvigK1yktb/6/OcvRwLRQm2ZeB0sH8+CzY7Nx1K7446ianxY7PQrsklCmlD 9oEdvnuewbN9qqp1Dr1X8TXZw4S4/Xrm7nsoaVqZMi7TFK+JGb8XOQC+jmIV5stw w9ul19O4NQVfs2NnvfsQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvvehfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpefftdevkedvgeekueeutefgteffieelvedukeeuhfehledvhfei tdehudfhudehhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 04:39:25 -0400 (EDT) Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs To: Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring Cc: Liam Girdwood , Mark Brown , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220815043436.20170-1-samuel@sholland.org> <20220815043436.20170-2-samuel@sholland.org> <03de0f7b-9251-a5c0-91a1-5f2b5d41d8a0@sholland.org> <29e6a293-29c4-a9ab-0767-9adfa982226b@linaro.org> From: Samuel Holland Message-ID: <8f133166-dff8-e376-3ac4-a464724d5421@sholland.org> Date: Wed, 17 Aug 2022 03:39:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <29e6a293-29c4-a9ab-0767-9adfa982226b@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220817_013928_018255_51B92282 X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/17/22 3:27 AM, Krzysztof Kozlowski wrote: > On 17/08/2022 11:15, Samuel Holland wrote: >>>> +examples: >>>> + - | >>>> + audio-codec@2030000 { >>>> + compatible = "simple-mfd", "syscon"; >>> >>> This cannot be on its own. Both require device specific compatible. >> >> Again, the device-specific compatible does not exist, because the binding for >> the audio codec has not been written (and it will be quite nontrivial). >> >> So I can: >> 1) Leave the example as-is until the audio codec binding gets written, >> and fill in the specific compatible at that time. >> 2) Remove the example, with the reasoning that the example really >> belongs with the MFD parent (like for the other regulator). Then >> there will be no example until the audio codec binding is written. >> 3) Drop the analog LDOs from this series entirely, and some parts >> of the SoC (like thermal monitoring) cannot be added to the DTSI >> until the audio codec binding is written. >> >> What do you think? > > How about just removing the audio-codec node? The schema is about > regulators, not audio-codec. That works for me. I put the extra node there to signify that this is a MFD child and requires some parent node to work, but I suppose it is not that helpful to have. > OTOH, if you have parent device schema, you could put the example only > there. But as I understand, you don't have, right? Right. >> The same question applies for the D1 SoC DTSI, where I use this same construct. > > This is not correct and should be fixed. Either you add the schema with > compatible or please drop the device node from the DTSI. That's what I was afraid of. Regards, Samuel >> (And technically this does validate with the current schema.) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel