Re: [PATCH] leds: Move MODULE_DEVICE_TABLE next to the table itself

Florian Fainelli
2026-05-05T15:34:56Z

On 5/5/26 03:28, 'Krzysztof Kozlowski' via BCM-KERNEL-FEEDBACK-LIST,PDL
wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify. It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Most of the privers already have this correctly placed, so adjust
> the missing ones. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/leds/blink/leds-bcm63138.c | 2 +-

For the above:

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian