Re: [PATCH] leds: Move MODULE_DEVICE_TABLE next to the table itself

Tzung-Bi Shih
2026-05-06T02:50:13Z

On Tue, May 05, 2026 at 12:28:45PM +0200, Krzysztof Kozlowski wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify. It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Most of the privers already have this correctly placed, so adjust
^ d

> the missing ones. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/leds/blink/leds-bcm63138.c | 2 +-
> drivers/leds/leds-cros_ec.c | 2 +-

For leds-cros_ec.c,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>