From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 361D2ECAAA3 for ; Fri, 26 Aug 2022 02:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v+iemcN+8taaP2/axpxibeYENfjptYauf90hSIvBsHg=; b=pAxhplgp8ABm99 8N6DRS/tUTsAu/25pN1ovbsb+39I+a+65ns2H7kac0TecDVLE2axyN/MuFaoMpFdQu7Xmn2T8WlkK /7i5ova2iZogynQEjFXNeNTa/pzrbveBCuXsQXVILy4DMnThAeoLgfQBE2aYSkXtJrAXZ/2INNHnB mxwF8K/ZMPPN6uvJeodRJdVsTOMw337/JnVkx5398mQOwnyBI7YSkWZ3p8J54br3sZ8ykYU9VJGuu lDHR31e5/6hz4ow9ZDmrbP/WulzHmmzHK5ci9YeGh/GE0VN3/BI7CHmJmilRVaJ5DsWnqbZIVomzt 8pOTy57shd3pWGfzJfUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRP5Y-005G4m-IP; Fri, 26 Aug 2022 02:28:52 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRP5U-005G1a-RU; Fri, 26 Aug 2022 02:28:50 +0000 X-UUID: ea6b9df2a4454c698c5897dc2b7aebe2-20220825 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=KgBpaU7vRZoDlQXa+zssEHDfGBzr1B9I2Bio6kdXfOU=; b=U5qNUb/ICHSrFGDajBga2+HPy+9PZsQdnNX6o4BZiWyETFZzfZh7SBA8tBHl+j9wRSkqhrosZqhWUqnbXDsCnRb43+WEDitaJ3xbcau/ztr5esBLjwwVa0DMcMnCfgHlX3RjzWbTgLuKSEhDyD5b7V1T0btTOLVDo/ZL/21QsHY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:19039612-8ae0-4a96-b011-1ed7e5cfbf41,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_ Ham,ACTION:release,TS:0 X-CID-META: VersionHash:84eae18,CLOUDID:76c79d55-e800-47dc-8adf-0c936acf4f1b,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: ea6b9df2a4454c698c5897dc2b7aebe2-20220825 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2006607620; Thu, 25 Aug 2022 19:28:38 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 26 Aug 2022 10:07:57 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 26 Aug 2022 10:07:57 +0800 Message-ID: <8f3dba943170361211d9bb4c8bf1be12bbfdec20.camel@mediatek.com> Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 From: Bo-Chen Chen To: Matthias Brugger , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" CC: Jason-JH Lin =?UTF-8?Q?=28=E6=9E=97=E7=9D=BF=E7=A5=A5=29?= , Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?= , "CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?=" , "chunkuang.hu@kernel.org" , "angelogioacchino.delregno@collabora.com" , "hsinyi@google.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Date: Fri, 26 Aug 2022 10:07:56 +0800 In-Reply-To: <3ed3d73a-1671-708e-7c42-498cca6aaf1d@gmail.com> References: <20220825091448.14008-1-rex-bc.chen@mediatek.com> <3ed3d73a-1671-708e-7c42-498cca6aaf1d@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_192848_930909_B485C886 X-CRM114-Status: GOOD ( 30.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2022-08-25 at 22:57 +0800, Matthias Brugger wrote: > > On 25/08/2022 11:14, Bo-Chen Chen wrote: > > From: "Jason-JH.Lin" > > > > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > > pipelines binding to 1 mmsys with the same power domain, the same > > clock driver and the same mediatek-drm driver. > > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding > > to > > 2 different power domains, different clock drivers and different > > mediatek-drm drivers. > > > > Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR, > > CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture > > Quality) > > and they makes VDOSYS0 supports PQ function while they are not > > including in VDOSYS1. > > > > Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related > > component). It makes VDOSYS1 supports the HDR function while it's > > not > > including in VDOSYS0. > > > > To summarize0: > > Only VDOSYS0 can support PQ adjustment. > > Only VDOSYS1 can support HDR adjustment. > > > > Therefore, we need to separate these two different mmsys hardwares > > to > > 2 different compatibles for MT8195. > > > > Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add mt8195 > > SoC binding") > > Signed-off-by: Jason-JH.Lin > > Signed-off-by: Bo-Chen Chen > > --- > > Changes for v2: > > 1. Add hardware difference for VDOSYS0 and VDOSYS1 in commit > > message. > > --- > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | > > 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > index 6ad023eec193..bfbdd30d2092 100644 > > --- > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > +++ > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > @@ -31,7 +31,8 @@ properties: > > - mediatek,mt8183-mmsys > > - mediatek,mt8186-mmsys > > - mediatek,mt8192-mmsys > > - - mediatek,mt8195-mmsys > > + - mediatek,mt8195-vdosys0 > > Thanks for you patch. As I mentioned on v1, I propose to set > mediatek,mt8195-mmsys as fallback for mediatek,mt8195-vdosys0 to not > break > backwards compatibility. > > Apart from that, the binding change will need some changes to support > the new > binding. Please provide these together with this patch. > > Regards, > Matthias > Hello Matthias, Thanks for your comments. The purpose of this patch is to confirm we can separate mt8195 mmsys into two compatibles. I think this modification is accepted. After this, I think Jason-JH will push another series with this binding patch. In Jason-JH's series, we will modify mmsys driver based on this. And I think we don't need to keep "mediatek,mt8195-mmsys" if we also modify mmsys drivers in the same series. Is it ok that postpones to pick this patch until we finish review follow-up series? BRs, Bo-Chen > > + - mediatek,mt8195-vdosys > - > > mediatek,mt8365-mmsys > > - const: syscon > > - items: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel