From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71541C05027 for ; Thu, 9 Feb 2023 13:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F0tmvh9JHpLYZnSouzifA5C2C+C1qNOpEmd59sLekhI=; b=rxkPH9bZTPuYQD tuZbuGZdtlgcFIsnzakYOfeRMiE+JQx/PSNgmNxR5gQE4WBNPuIubLhKwmaJbE660ir+NIg+lXQgY vWTnC/Sr7w1gt2AP2TZ+nhfeoBdKtNzCN41IMbCdfVdUG8vczNv1sZcE7n37AKWknE0Wyq7Rv4B9k 6r+lOXjwQq6EozHgfMOdSmFyckiOrD+RW47T1Uduvw7YSFi2wIdChZ+gPrXRQC2xhY2eZ0bW5CY7I C2h4OpGAoOP16fts/ESXuoF5Djro9d2ysIGGtUS0MReyDvHO3XpxiPIBJH69OrCLwc1Uw+Ml8T5R6 OjtJTNtITIKgnzQvqPAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ78Q-001kmX-58; Thu, 09 Feb 2023 13:38:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ73e-001iFs-KY for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 13:33:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2326061A51; Thu, 9 Feb 2023 13:33:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 370A5C433D2; Thu, 9 Feb 2023 13:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675949629; bh=oVN64FqEr+efwuF26PEuL8gATG0G1/6rAPqudX6DOdg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CZExgqAzn+K1qkk9d5dSa5leUc0ZpST/jwUncEouLhp7NN/J8uHtK5XCuwmh9lZaK /HsOXM9rEQ7YBP/RoKFPqIOj2XGZO3B5vauogtdxL+/TVBeWsDyVZCwuaKyrDteVaj 5XPQf1vrk6PQG8MkGsAFlNhRvTVXcaJ3EMUPRuV0Qj4lYnKnvFaNMrYxWpz4nlXg4c SAq54i6sK1Gc2Wx4gdQuZ3o8cNBp5hEBZOBW52yn08M4an9CiJq3xZYtwkiBj8c9xA 2H8QgkOgarYPlRbkgF7/ZX3hsKFobItG58MevfAKuQSxrurSKR5VwaejAguXrQCusf i7rBN5w4ThlOw== Message-ID: <8f8039d1-e344-ff84-a503-a944b0df6e58@kernel.org> Date: Thu, 9 Feb 2023 15:33:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: Add RX DMA Channel Teardown Quirk Content-Language: en-US To: Siddharth Vadapalli , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com References: <20230209084432.189222-1-s-vadapalli@ti.com> From: Roger Quadros In-Reply-To: <20230209084432.189222-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_053350_761258_B162CC4D X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/02/2023 10:44, Siddharth Vadapalli wrote: > In TI's AM62x/AM64x SoCs, successful teardown of RX DMA Channel raises an > interrupt. The process of servicing this interrupt involves flushing all > pending RX DMA descriptors and clearing the teardown completion marker > (TDCM). The am65_cpsw_nuss_rx_packets() function invoked from the RX > NAPI callback services the interrupt. Thus, it is necessary to wait for > this handler to run, drain all packets and clear TDCM, before calling > napi_disable() in am65_cpsw_nuss_common_stop() function post channel > teardown. If napi_disable() executes before ensuring that TDCM is > cleared, the TDCM remains set when the interfaces are down, resulting in > an interrupt storm when the interfaces are brought up again. > > Since the interrupt raised to indicate the RX DMA Channel teardown is > specific to the AM62x and AM64x SoCs, add a quirk for it. > > Fixes: 4f7cce272403 ("net: ethernet: ti: am65-cpsw: add support for am64x cpsw3g") > Co-developed-by: Vignesh Raghavendra > Signed-off-by: Vignesh Raghavendra > Signed-off-by: Siddharth Vadapalli Reviewed-by: Roger Quadros _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel