From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72197C433DF for ; Wed, 1 Jul 2020 17:34:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E51E20771 for ; Wed, 1 Jul 2020 17:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o9H+1D/a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pO/d3N3X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E51E20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i7RyoTH2ZIVPtVGF85LmqZjeL35HKIqa/5BYllCi4vY=; b=o9H+1D/aigMxWDaFawPF3AfMO HGsCevKSZ2t131MCZCd9cRkRTctXOtUZJTZK5j2SH5vXGTUSIJXfGsNbaf67TcyVc/vH6jyqLh13h HSnYSbEa0MBt5vC2mJ5+D062unjSPJtFe+DegvM8cOQ8VKCP98nmTSoMVOPjzfeOi7l75KiIPdWts Qn29BBQN9PRffA6YrVBtwENElp6KzRbrE8PZb4p7DvxTysVER4edUIXi3EL2T7IYOTFNRv6JYpAMi qLqP9E1O7FK+fV98JaFd/Olf9QwEE9dgPTSrR/KxdGOfpPiofovsejy43uIEvetgJprYdQKEPRKOy U9ARxzmUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqgbS-0000zV-Qf; Wed, 01 Jul 2020 17:32:58 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqgbP-0000x3-65 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 17:32:57 +0000 Received: by mail-qv1-xf43.google.com with SMTP id m8so7159701qvk.7 for ; Wed, 01 Jul 2020 10:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xuCr/BLFRQfPju0k5opNS+uQpQU/MMeebcyxccV+Kjs=; b=pO/d3N3Xg728f4WsB1qavsUXy+ZK7+q7tIJpZ2wzis1KZZD3n2gdYZmIdpvWKbRKZC yQ9LX2Z2PTexABsE16Unr/jZMCtppHaMvfSigdOUGY50DxoiD6uHTEr94W2R5VE1zPhA ws70+fx0zBPuGAtZsX+g4iByAOgveKwVEL0kJroWJEB8rjeSKnBHAdoURcjeY/v4saEB 9ikoMAn7t+3cd9Gm5DaByasl06D/2Axa1jOVQuAk9LguSjFExqJ5euZZbAquA3S0S4Zv E0iZw4bK2S97VcZeQrrsXfcKlkli5N8pc/VFypcjz6TCLUdyOeupY6obkuNaagxVC6Uy iJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xuCr/BLFRQfPju0k5opNS+uQpQU/MMeebcyxccV+Kjs=; b=EjpUGhirZO/nyrdy4S3Kg9XppZUjCzZEDdLCb0ZAc3jNssqvV33o1EiJY8zIoEb9CY WzscRV6VAiHdkn0T2SP3TYxiF5U23Zj+qlXrYZN5pRa4VHgayU/nCC6YiBo5n81vvc3W p3yt372oxUhzfTuasiY3XQOSeva+eBFAzJGqaiUspc/v8i7t3QUOETTyoOG8ih2XQ8kM Z5dz/ZuAn9SAuN/9QaqtETNfykAl6kFzIUUMEtqg6ZtfwyZeA5JXpnxSyTaOyrun3XrW 7ebds+QsIZ6PmWNs8JKJIKeC/okuVrZO2IjJ+xdV4s5l6w+fwPPth2Q+0Oe/q7aVC8pZ F5Zg== X-Gm-Message-State: AOAM531ptvhkpdvlbOmlLQbw8tU0wsXTgc8eicoXkrSmMtBNelLzuJDU HNK72wTgrs4RamUBbElsbsD72Q== X-Google-Smtp-Source: ABdhPJzVVqbDUHvpYLFYeLSni9YkmFljvxbDGK5K5pHm9NyYA/JF8Q5vRLzZ36Ihn+4uCU11q/5lyw== X-Received: by 2002:a0c:b7ad:: with SMTP id l45mr22714066qve.132.1593624771735; Wed, 01 Jul 2020 10:32:51 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:20c3:28c6:c7b3:e1d8:8a2f? ([2804:7f0:8283:20c3:28c6:c7b3:e1d8:8a2f]) by smtp.gmail.com with ESMTPSA id t65sm3418141qkf.119.2020.07.01.10.32.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 10:32:50 -0700 (PDT) Subject: Re: [PATCH v5 19/25] arm64: mte: Add PTRACE_{PEEK,POKE}MTETAGS support To: Catalin Marinas References: <20200624175244.25837-1-catalin.marinas@arm.com> <20200624175244.25837-20-catalin.marinas@arm.com> <7fd536af-f9fa-aa10-a4c3-001e80dd7d7b@linaro.org> <20200701171549.GF5191@gaia> From: Luis Machado Message-ID: <8fa5c891-0f4a-c925-679e-94c41a546490@linaro.org> Date: Wed, 1 Jul 2020 14:32:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200701171549.GF5191@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_133255_304154_2654E4DE X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Omair Javaid , Szabolcs Nagy , Andrey Konovalov , Kevin Brodsky , Peter Collingbourne , linux-mm@kvack.org, Alan Hayward , Andrew Morton , Vincenzo Frascino , Will Deacon , Dave P Martin , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/1/20 2:16 PM, Catalin Marinas wrote: > Hi Luis, > > On Thu, Jun 25, 2020 at 02:10:10PM -0300, Luis Machado wrote: >> I have one point below I wanted to clarify regarding >> PEEKMTETAGS/POKEMTETAGS. >> >> But before that, I've pushed v2 of the MTE series for GDB here: >> >> https://sourceware.org/git/?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/luisgpm/aarch64-mte-v2 >> >> That series adds sctlr and gcr registers to the NT_ARM_MTE (still using a >> dummy value of 0x407) register set. It would be nice if the Linux Kernel and >> the debuggers were in sync in terms of supporting this new register set. GDB >> assumes the register set exists if HWCAP2_MTE is there. >> >> So, if we want to adjust the register set, we should probably consider doing >> that now. That prevents the situation where debuggers would need to do >> another check to confirm NT_ARM_MTE is exported. I'd rather avoid that. > > I'm happy to do this before merging, though we need to agree on the > semantics. > > Do you need both read and write access? Also wondering whether the If I recall the previous discussion correctly, Kevin thought access to both of these would be interesting to the user. It sounded like having read-only access was enough. If so,... > prctl() value would be a better option than the raw register bits (well, > not entirely raw, masking out the irrelevant part). ... then exposing the most useful bits to the user would be better, and up to you to define. I can tweak the GDB patches to turn the sctlr and gcr values into flag fields. Then GDB can just show those in a more meaningful way. I just need to know what the bits would look like. I'd rather not make these values writable if we don't think there is a good use case for it. Better avoid giving developers more knobs than they need? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel