From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB2FC43613 for ; Sun, 23 Jun 2019 14:15:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 720AE20663 for ; Sun, 23 Jun 2019 14:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TdW8sbrB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 720AE20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=katsuster.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Date:Message-ID:Subject:From:To: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=60znvII9P0Jh1AjVlj1V0v1gJw/vJyRcR36fTdmoNwo=; b=TdW8sbrBf5oUw+ZmrgGdIIGJLW D85Estub/pSnpbvNmGp6SB411Zj4Z7bZ791XwZRnz5j6jOadJsfGtfHdBS1PS8Ph02u5AnjyhqjaL LtH80f+BYJRGs9riMymglAl/nVEh8YebPFn1WH84kuhQYinzwvZU2+Cwqad7RMreKq1eSdqI/DPGb RyHKcPz3DPZaoBtroHT29fNqMWp6WmtLcJXam3mT041GUFUuVcKcKjXbs/i/JW13l3gpjOre/Zm4J J6KSf9ZPsgokgobNPxGTbGPKgMOkkJdyqAYU3NV4zqRpcY/+hT+Xr22Q+c48qHIVhEPt5KUx9XGqj R4Rp81sw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hf3Gp-0003Lm-Dm; Sun, 23 Jun 2019 14:15:03 +0000 Received: from www1102.sakura.ne.jp ([219.94.129.142]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hf3Gm-000367-F8 for linux-arm-kernel@lists.infradead.org; Sun, 23 Jun 2019 14:15:01 +0000 Received: from fsav305.sakura.ne.jp (fsav305.sakura.ne.jp [153.120.85.136]) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id x5NEEuE2037688; Sun, 23 Jun 2019 23:14:56 +0900 (JST) (envelope-from katsuhiro@katsuster.net) Received: from www1102.sakura.ne.jp (219.94.129.142) by fsav305.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav305.sakura.ne.jp); Sun, 23 Jun 2019 23:14:55 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav305.sakura.ne.jp) Received: from [192.168.1.2] (118.153.231.153.ap.dti.ne.jp [153.231.153.118]) (authenticated bits=0) by www1102.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id x5NEEtSo037679 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NO); Sun, 23 Jun 2019 23:14:55 +0900 (JST) (envelope-from katsuhiro@katsuster.net) To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org From: Katsuhiro Suzuki Subject: stmmac regression on ASUS TinkerBoard Message-ID: <8fa9ce79-6aa2-d44d-e24d-09cc1b2b70a3@katsuster.net> Date: Sun, 23 Jun 2019 23:14:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190623_071500_732803_871A7BCD X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heiko Stuebner , linux-arm-kernel , Linux Kernel Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello stmmac maintainers, I found this commit and that has some regressions: 74371272f97f net: stmmac: Convert to phylink and remove phylib logic My environment is: - ASUS TinkerBoard - SoC is RK3288 - Using STMMAC driver drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c - Using this device-tree arch/arm/boot/dts/rk3288.dtsi ('gmac: ethernet@ff290000' node) Current linux-next on my environment, 'ifconfig eth0 up' does not work correctly with following message... ----- root@linaro-alip:~# ifconfig eth0 up [ 105.028916] rk_gmac-dwmac ff290000.ethernet eth0: stmmac_open: Cannot attach to PHY (error: -19) SIOCSIFFLAGS: No such device ----- I checked drivers/net/ethernet/stmicro/stmmac/stmmac_main.c and found stmmac_init_phy() is going to fail if ethernet device node does not have following property: - phy-handle - phy - phy-device This commit broke the device-trees such as TinkerBoard. The mdio subnode creating a mdio bus is changed to required or still optional? Best Regards, Katsuhiro Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel