Re: [PATCH 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator for Cool Pi CM5 EVB

Heiko Stübner
2024-01-31T14:24:43Z

Am Mittwoch, 31. Januar 2024, 13:21:56 CET schrieb Andy Yan:
>
> Hi Heiko：
>
> 在 2024-01-27 21:09:46，"Dragan Simic" <dsimic@manjaro.org> 写道：
> >On 2024-01-27 13:15, Andy Yan wrote:
> >> At 2024-01-27 18:36:40, "Heiko Stübner" <heiko@sntech.de> wrote:
> >>> Am Samstag, 27. Januar 2024, 10:20:33 CET schrieb Andy Yan:
> >>>> According to the schematic, this regulator is used both for USB30 and
> >>>> USB20, so give it a more appropriate name.
> >>>
> >>> I don't have the schematics, so I'll need you to answer this, but what
> >>> is the regulator called _in_ the schematics?
> >>
> >> There are two regulators called VCC50_USB_HOST1 and VCC50_USB_HOST2,
> >> and they are both controlled by GPIO1_D5
> >> They both for two usb 2.0 hosts, not usb 30, the schematics make
> >> me a bit confused.
> >
> >In that case, I'd say that renaming the regulator to vcc5v0_usb_host is
> >fine, but there should also be a comment in the board dts file that it's
> >actually two separate regulators.
>
> How do you feel about this ？ Or some other style like：
> vcc5v0_usb_host1: vcc5v0_usb_host2：vcc5v0-usb-host-regulator {

I think we're using such a scheme in some places already, and
yes I really like going this way. So that the phandles follow the
schematic names and we can still grep for things.

Heiko