Re: [PATCH 1/4] arm64: dts: rockchip: aliase sdmmc as mmc1 for Cool Pi 4B

Dragan Simic
2024-01-27T13:07:26Z

On 2024-01-27 10:20, Andy Yan wrote:
> Follow others rk3588 based boards, and u-boot only use mmc0/1
> as mmc boot targets, so aliase sdmmc as mmc1.
>
> Fixes: 3f5d336d64d6 ("arm64: dts: rockchip: Add support for rk3588s
> based board Cool Pi 4B")
> Signed-off-by: Andy Yan <andyshrk@163.com>

Makes sense to me.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> index 3fae40b9ae1b..3b9d21a6f8bf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -20,8 +20,8 @@ / {
>
> aliases {
> mmc0 = &sdhci;
> - mmc1 = &sdio;
> - mmc2 = &sdmmc;
> + mmc1 = &sdmmc;
> + mmc2 = &sdio;
> };
>
> analog-sound {