From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3205AC3DA7F for ; Mon, 5 Aug 2024 16:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UAGmdAA2WtUJS/+pcUyV7r/YI1enF8FhONPxQhPstFU=; b=M8A1s2Hd83QERktT4F/d1X4UiH OXrf1R4gxyWBJNfGWtiXcKcx02oUqYN+cZxiTqPT2CB6P+I/mASI2jEM3JnsN/MjDziNhFdG3EwYv 8x3Tms1Fnlr74JyDs6KmsyWF4B5gVZAtiFtuen5TRJMoPLUYVshca30Q6ATZbXfRq7XF2KI1N4B6S 4IipBenp+p8SKrqGxtoF2cc3ZMSVYCM7syGTa38KX3HIbI0pVSegec1eydxWwm4X5YMxWQWV81YMy oUZQ4lCDQWbzu9cUaOWRBZzNCFRjV3raV6dlV/cnh4kgGi+WFQO/WbRmyCxpKKJnKTl7vEsc2D6HP vsyLYg/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb07m-0000000GQVC-3a0I; Mon, 05 Aug 2024 15:59:54 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb07H-0000000GQND-0bmf for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 15:59:24 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id 0D44E20B7165; Mon, 5 Aug 2024 08:59:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0D44E20B7165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1722873562; bh=UAGmdAA2WtUJS/+pcUyV7r/YI1enF8FhONPxQhPstFU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=UCIUCw+bkrjSXeOdbhMzO/XwwDFYQZESDXytn/4uJccZRsXdwC1lDecS3Df/N+oub AnEILeN8i96cq6EWetu1QKCEaFTS/pLOiFEmwCXMoLwdUVAuUZFT/AS95lnO8b2Oyt NMLv/aPNtgbtCJTPzDK1nRZm5KbywaI3/VBjtXao= Message-ID: <8fc6f934-f8f3-442d-9354-0d1ab3092b63@linux.microsoft.com> Date: Mon, 5 Aug 2024 08:59:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] PCI: hv: Get vPCI MSI IRQ domain from DT From: Roman Kisel To: Wei Liu Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240726225910.1912537-1-romank@linux.microsoft.com> <20240726225910.1912537-8-romank@linux.microsoft.com> <2679199c-3f73-4326-85ee-622541d26153@linux.microsoft.com> Content-Language: en-US In-Reply-To: <2679199c-3f73-4326-85ee-622541d26153@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_085923_374313_7B1E8942 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/5/2024 7:51 AM, Roman Kisel wrote: > > > On 8/2/2024 6:20 PM, Wei Liu wrote: >> On Fri, Jul 26, 2024 at 03:59:10PM -0700, Roman Kisel wrote: >>> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration on >>> arm64. It won't be able to do that in the VTL mode where only DeviceTree >>> can be used. >>> >>> Update the hyperv-pci driver to get vPCI MSI IRQ domain in the >>> DeviceTree >>> case, too. >>> >>> Signed-off-by: Roman Kisel >>> --- >>>   drivers/hv/vmbus_drv.c              | 23 +++++++----- >>>   drivers/pci/controller/pci-hyperv.c | 55 +++++++++++++++++++++++++++-- >>>   include/linux/hyperv.h              |  2 ++ >>>   3 files changed, 69 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c >>> index 7eee7caff5f6..038bd9be64b7 100644 >>> --- a/drivers/hv/vmbus_drv.c >>> +++ b/drivers/hv/vmbus_drv.c >>> @@ -45,7 +45,8 @@ struct vmbus_dynid { >>>       struct hv_vmbus_device_id id; >>>   }; >>> -static struct device  *hv_dev; >>> +/* VMBus Root Device */ >>> +static struct device  *vmbus_root_device; >> >> You're changing the name of the variable. That should preferably be done >> in a separate patch. That's going to make this patch shorter and easier >> to review. >> > Will fix in v4, thanks! > >>>   static int hyperv_cpuhp_online; >>> @@ -80,9 +81,15 @@ static struct resource *fb_mmio; >>>   static struct resource *hyperv_mmio; >>>   static DEFINE_MUTEX(hyperv_mmio_lock); >>> +struct device *get_vmbus_root_device(void) >>> +{ >>> +    return vmbus_root_device; >>> +} >>> +EXPORT_SYMBOL_GPL(get_vmbus_root_device); >> >> I would like you to add "hv_" prefix to this exported symbol, or rename >> it to "vmbus_get_root_device()". >> Will do in v4, missed this suggestion in my first reply. >>> + >>>   static int vmbus_exists(void) >>>   { >>> -    if (hv_dev == NULL) >>> +    if (vmbus_root_device == NULL) >>>           return -ENODEV; >>>       return 0; >>> @@ -861,7 +868,7 @@ static int vmbus_dma_configure(struct device >>> *child_device) >>>        * On x86/x64 coherence is assumed and these calls have no effect. >>>        */ >>>       hv_setup_dma_ops(child_device, >>> -        device_get_dma_attr(hv_dev) == DEV_DMA_COHERENT); >>> +        device_get_dma_attr(vmbus_root_device) == DEV_DMA_COHERENT); >>>       return 0; >>>   } >>> @@ -1892,7 +1899,7 @@ int vmbus_device_register(struct hv_device >>> *child_device_obj) >>>                &child_device_obj->channel->offermsg.offer.if_instance); >>>       child_device_obj->device.bus = &hv_bus; >>> -    child_device_obj->device.parent = hv_dev; >>> +    child_device_obj->device.parent = vmbus_root_device; >>>       child_device_obj->device.release = vmbus_device_release; >>>       child_device_obj->device.dma_parms = &child_device_obj->dma_parms; >>> @@ -2253,7 +2260,7 @@ static int vmbus_acpi_add(struct >>> platform_device *pdev) >>>       struct acpi_device *ancestor; >>>       struct acpi_device *device = ACPI_COMPANION(&pdev->dev); >>> -    hv_dev = &device->dev; >>> +    vmbus_root_device = &device->dev; >>>       /* >>>        * Older versions of Hyper-V for ARM64 fail to include the _CCA >>> @@ -2342,7 +2349,7 @@ static int vmbus_device_add(struct >>> platform_device *pdev) >>>       struct device_node *np = pdev->dev.of_node; >>>       int ret; >>> -    hv_dev = &pdev->dev; >>> +    vmbus_root_device = &pdev->dev; >>>       ret = of_range_parser_init(&parser, np); >>>       if (ret) >>> @@ -2675,7 +2682,7 @@ static int __init hv_acpi_init(void) >>>       if (ret) >>>           return ret; >>> -    if (!hv_dev) { >>> +    if (!vmbus_root_device) { >>>           ret = -ENODEV; >>>           goto cleanup; >>>       } >>> @@ -2706,7 +2713,7 @@ static int __init hv_acpi_init(void) >>>   cleanup: >>>       platform_driver_unregister(&vmbus_platform_driver); >>> -    hv_dev = NULL; >>> +    vmbus_root_device = NULL; >>>       return ret; >>>   } >>> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/ >>> controller/pci-hyperv.c >>> index 5992280e8110..cdecefd1f9bd 100644 >>> --- a/drivers/pci/controller/pci-hyperv.c >>> +++ b/drivers/pci/controller/pci-hyperv.c >>> @@ -50,6 +50,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>   /* >>> @@ -887,6 +888,35 @@ static const struct irq_domain_ops >>> hv_pci_domain_ops = { >>>       .activate = hv_pci_vec_irq_domain_activate, >>>   }; >>> +#ifdef CONFIG_OF >>> + >>> +static struct irq_domain *hv_pci_of_irq_domain_parent(void) >>> +{ >>> +    struct device_node *parent; >>> +    struct irq_domain *domain; >>> + >>> +    parent = >>> of_irq_find_parent(to_platform_device(get_vmbus_root_device())- >>> >dev.of_node); >>> +    domain = NULL; >>> +    if (parent) { >>> +        domain = irq_find_host(parent); >>> +        of_node_put(parent); >>> +    } >>> + >> >> I cannot really comment on the ARM side of things around how this system >> is set up. I will leave that to someone who's more familiar with the >> matter to review. >> >> Thanks, >> Wei. > -- Thank you, Roman