From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E9FCC48BC3 for ; Mon, 19 Feb 2024 06:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zIDCXyedB6Zbx7W1lWx4mOcgKKWTEn8cx+L69bESAYo=; b=1TjX0q75CTpGc5 aDBwnRuLX6ppUwvcWzXZnV5IGcYrgiCdGaNxAtvnftF7LrVQUbyaIgTV29d79Usld8PViVhDRdJ8T KIgaBXEGd96yLjIZMBUCVUi/MLhHQjBAjHvnYIlrJ6hNjaYqphVBvXcw7R85b3RwgzWRIxfMexz74 5vhiEkr4GSyZKSFlvf99Ef0wsrER8JV6Zt3LW2TBDvOC6sTqTzQuN0PU/pUiErmotjPYgRkcKVHvU jL4/wsSY/acuvylSA8ZmuZkeULnLk2gXv/u36z+WIOs/ByqXF/BrwWFSomSSbG0T0s/pT4VJXxlgZ L/r2hou5m5ghUVQwmb1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbxJZ-00000009GzS-1RB3; Mon, 19 Feb 2024 06:39:45 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbxJW-00000009Gxc-069R for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 06:39:43 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55a8fd60af0so5817788a12.1 for ; Sun, 18 Feb 2024 22:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708324780; x=1708929580; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AmJlj9IwjLF3l7fXdAXhun2W1nnG7kbqGQDiD2NuR8k=; b=xaouSaxUWUsjvvDzN61GnybHhIz8JBWjyvzTAy3VPDjMUjhPABWXrpiCR6YdIIf7Ko QVkvg+9xevpMObmu46wek3CaErJzlFjH6KQ41NSt6peiG2MzLHnC9SFV2Z9DtFWCVWRB MeSWbtIbiWYD5HyRzoso2NQD0usL2FzU6CXn1x4rk/+z2OCOJU8+zfpjxJtv4vBmCOem wMk9rUHIV7eiHTR/JX+DBZV7fWDm+vxUUe/ZxBRJ34bONi0jmJwuZWT06S/IDq7jaXJF cj5NHK1XqHogVoVer7OzrFw3hxy1Ot8paJnbCTDOdEPFOkUIfeFWqmja1BPpZCOwumyI msqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708324780; x=1708929580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AmJlj9IwjLF3l7fXdAXhun2W1nnG7kbqGQDiD2NuR8k=; b=Ok6oEjVVhr74eMeHHInFCTBTDTJFvFxjvq7eBAFOmc/9TXb1QeXOCe5jitr2/lQNYJ VoL9O4WpRbOM6LrcgyLsUKaF/tzc0/x9zzjJn5TVRlXM9zEtxV+go+IY3azde3piFzWH IqH3xJxKhN6KoV+Tks+YDqWPzW3fxfLn6q/jZx/cMczOXUsq+Jd/EtRnu3YpirQr3ys6 PjwWrrmzftIJPyz7IpdBwCfjT55ev5ekWOxJ1uN0WVMFXa6Vz4V2twOgHibNuvUxwkXc iWo73e0jAwxEZik60LLzXi3IdUWNreFqdsHTTiQvvaDew5t1OQAB5m4vjirXV3bQY0KN BRgQ== X-Forwarded-Encrypted: i=1; AJvYcCWgoyjpDm7EK3MDCYoqNaDv4TvYToFOGmtB+oLEK6Qxiwp4dZxQyNkiQfroa1j7hZPa0mcXish2bg65SBQVtLb8nFwv/Vzlgn4HWZVivSKUTJkk1uM= X-Gm-Message-State: AOJu0YxmBdF2v65oC8PpFcE16TRLn734etqgR734VylCpPQGnnFi2X95 6AJeZATmyZYj7EBwVpTe2uSXIrDeyx4aG0w/jjBfOBsrjVMBBcchUieO2RhCCM/LbfByRkIccMW 7 X-Google-Smtp-Source: AGHT+IE0lRySbhCpT61lK2s4dp+A3WXUcUSWKSoMrTpO4ff5uUV/6rODCAr8djn3WbbOkL261QrRJg== X-Received: by 2002:a05:6402:784:b0:564:7962:4553 with SMTP id d4-20020a056402078400b0056479624553mr865356edy.16.1708324779644; Sun, 18 Feb 2024 22:39:39 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id eg43-20020a05640228ab00b0056454c668f9sm1279229edb.53.2024.02.18.22.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 22:39:39 -0800 (PST) Date: Mon, 19 Feb 2024 09:39:35 +0300 From: Dan Carpenter To: "Moritz C. Weber" Cc: florian.fainelli@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: vc04_services: bcm2835-camera: fixed several brace coding style checks Message-ID: <8fe8c4bf-5fa3-4bfc-9535-b48df12f80ff@moroto.mountain> References: <20240215220647.4096-1-mo.c.weber@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240215220647.4096-1-mo.c.weber@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240218_223942_086823_597C48D1 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 11:06:47PM +0100, Moritz C. Weber wrote: > @@ -406,12 +405,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, > is_capturing(dev)) { > v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, > "Grab another frame as buffer has EOS"); > - vchiq_mmal_port_parameter_set( > - instance, > - dev->capture.camera_port, > - MMAL_PARAMETER_CAPTURE, > - &dev->capture.frame_count, > - sizeof(dev->capture.frame_count)); > + vchiq_mmal_port_parameter_set(instance, > + dev->capture.camera_port, > + MMAL_PARAMETER_CAPTURE, > + #N(#O(#O(#O(#O(&dev->capture.frame_count, ^^^^^^^^^^^^^^^^ Wut? > + sizeof(dev->capture.frame_count)); > } > } > > @@ -420,11 +418,11 @@ static int enable_camera(struct bcm2835_mmal_dev *dev) > int ret; > > if (!dev->camera_use_count) { > - ret = vchiq_mmal_port_parameter_set( > - dev->instance, > - &dev->component[COMP_CAMERA]->control, > - MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num, > - sizeof(dev->camera_num)); > + ret = vchiq_mmal_port_parameter_set(dev->instance, > + &dev->component[COMP_CAMERA]->control, > + MMAL_PARAMETER_CAMERA_NUM, > + &dev->camera_num, > + **sizeof(dev->camera_num)); Also Wut??? regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel