public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] allow DTB to be appended to the ARM zImage with ATAG conversion
Date: Tue, 21 Jun 2011 14:59:38 -0700	[thread overview]
Message-ID: <8yatybieth1.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1308632955-11070-1-git-send-email-nico@fluxnic.net> (Nicolas Pitre's message of "Tue, 21 Jun 2011 01:09:11 -0400")

On Mon, Jun 20 2011, Nicolas Pitre wrote:

> Yet another resend, this time with a patch to convert some ATAGs and
> fold them into the appended DTB.  Additional ATAgs and their corresponding
> DTB representation is still up for discussion.  In particular,
> ATAG_REVISION and ATAG_SERIAL were mentioned as missing but there is
> no direct DT equivalent for them.  One suggestion was to fold them into
> the kernel cmdline string.  Anything else?
>
> Testing would also be appreciated.
>
> [PATCH 1/4] ARM: zImage: ensure it is always a multiple of 64 bits in size
> [PATCH 2/4] ARM: zImage: Allow the appending of a device tree binary
> [PATCH 3/4] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss
> [PATCH 4/4] ARM: zImage: allow supplementing appended DTB with traditional ATAG data

The first three appear to be in Grant's devicetree/arm branch (as far as
I can tell), so I've tested the last one.

I get the same behavior on MSM8660, this works as long as the DTB has
the attributes with enough padding in them to hold the values written.
If the fdt code tries expanding the tree (I create the DTB sith -p
1024), then my device goes off in the weeds somewhere.  I'm trying to
track this down, it seems to be failing in a memmove, even though that
memmove appears valid to me.  I'm still investigating that.

Otherwise, it looks good.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

      parent reply	other threads:[~2011-06-21 21:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21  5:09 [PATCH 0/4] allow DTB to be appended to the ARM zImage with ATAG conversion Nicolas Pitre
2011-06-21  5:09 ` [PATCH 1/4] ARM: zImage: ensure it is always a multiple of 64 bits in size Nicolas Pitre
2011-06-21  5:09 ` [PATCH 2/4] ARM: zImage: Allow the appending of a device tree binary Nicolas Pitre
2011-06-21  5:09 ` [PATCH 3/4] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss Nicolas Pitre
2011-06-21  5:09 ` [PATCH 4/4] ARM: zImage: allow supplementing appended DTB with traditional ATAG data Nicolas Pitre
2011-06-21  7:00   ` Shawn Guo
2011-06-21 17:32     ` David Brown
2011-06-21 22:58   ` David Brown
2011-06-21 23:13     ` David Brown
2011-06-21 23:22       ` Warner Losh
2011-06-21 23:35       ` Nicolas Pitre
2011-06-21 21:59 ` David Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8yatybieth1.fsf@huya.qualcomm.com \
    --to=davidb@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox