* [PATCH] arm: dts: rockchip: add crypto node for RK322x
@ 2022-10-19 16:47 Michele Zuccalà
2022-10-19 17:39 ` Johan Jonker
0 siblings, 1 reply; 6+ messages in thread
From: Michele Zuccalà @ 2022-10-19 16:47 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, devicetree, Alex Bee
The cryptographic hardware of the rk322x is compatible with the one present in the rk3288.
Add the respective node to the device tree.
Signed-off-by: Alex Bee <knaerzche@gmail.com>
Signed-off-by: Michele Zuccalà <ardutu@gmail.com>
---
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index ffc16d6b9..b381fc2a0 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -132,6 +132,17 @@ display_subsystem: display-subsystem {
ports = <&vop_out>;
};
+ crypto: crypto@100a0000 {
+ compatible = "rockchip,rk3288-crypto";
+ reg = <0x100a0000 0x4000>;
+ interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru HCLK_M_CRYPTO>, <&cru HCLK_S_CRYPTO>,
+ <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC>;
+ clock-names = "aclk", "hclk", "sclk", "apb_pclk";
+ resets = <&cru SRST_CRYPTO>;
+ reset-names = "crypto-rst";
+ };
+
i2s1: i2s1@100b0000 {
compatible = "rockchip,rk3228-i2s", "rockchip,rk3066-i2s";
reg = <0x100b0000 0x4000>;
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
2022-10-19 16:47 [PATCH] arm: dts: rockchip: add crypto node for RK322x Michele Zuccalà
@ 2022-10-19 17:39 ` Johan Jonker
2022-10-20 7:10 ` ilmich
0 siblings, 1 reply; 6+ messages in thread
From: Johan Jonker @ 2022-10-19 17:39 UTC (permalink / raw)
To: Michele Zuccalà, Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, devicetree, Alex Bee, Corentin Labbe
Added Cc: clabbe@baylibre.com
On 10/19/22 18:47, Michele Zuccalà wrote:
> The cryptographic hardware of the rk322x is compatible with the one present in the rk3288.
>
> Add the respective node to the device tree.
>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Michele Zuccalà <ardutu@gmail.com>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index ffc16d6b9..b381fc2a0 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -132,6 +132,17 @@ display_subsystem: display-subsystem {
> ports = <&vop_out>;
> };
>
> + crypto: crypto@100a0000 {
> + compatible = "rockchip,rk3288-crypto";
Hi,
Compatible strings must SoC orientated.
Something like:
compatible = "rockchip,rk3228-crypto", "rockchip,rk3288-crypto";
This string must be add to YAML document:
https://lore.kernel.org/linux-rockchip/20220927075511.3147847-25-clabbe@baylibre.com/
The status of that serie is unknown to me.
Not sure by who or when that is going to be merged.
Johan
> + reg = <0x100a0000 0x4000>;
> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_M_CRYPTO>, <&cru HCLK_S_CRYPTO>,
> + <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC>;
> + clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> + resets = <&cru SRST_CRYPTO>;
> + reset-names = "crypto-rst";
> + };
> +
> i2s1: i2s1@100b0000 {
> compatible = "rockchip,rk3228-i2s", "rockchip,rk3066-i2s";
> reg = <0x100b0000 0x4000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
2022-10-19 17:39 ` Johan Jonker
@ 2022-10-20 7:10 ` ilmich
2022-10-20 8:53 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: ilmich @ 2022-10-20 7:10 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, devicetree, Alex Bee,
Corentin Labbe
> Hi,
Hi Johan,
>
> Compatible strings must SoC orientated.
>
> Something like:
> compatible = "rockchip,rk3228-crypto", "rockchip,rk3288-crypto";
>
> This string must be add to YAML document:
> https://lore.kernel.org/linux-rockchip/20220927075511.3147847-25-clabbe@baylibre.com/
>
> The status of that serie is unknown to me.
> Not sure by who or when that is going to be merged.
>
> Johan
thanks for the feedback, this is my first kernel patch.
Maybe at this point it is worth trying to combine the two jobs !?
Or do I still have to modify my patch asking only to add the string in
the yaml !?
Thank you
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
2022-10-20 7:10 ` ilmich
@ 2022-10-20 8:53 ` Heiko Stuebner
2022-10-20 11:13 ` Michele Zuccalà
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2022-10-20 8:53 UTC (permalink / raw)
To: Johan Jonker, ilmich
Cc: Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, devicetree, Alex Bee, Corentin Labbe
Hi,
Am Donnerstag, 20. Oktober 2022, 09:10:44 CEST schrieb ilmich:
> > Hi,
>
> Hi Johan,
>
> >
> > Compatible strings must SoC orientated.
> >
> > Something like:
> > compatible = "rockchip,rk3228-crypto", "rockchip,rk3288-crypto";
> >
> > This string must be add to YAML document:
> > https://lore.kernel.org/linux-rockchip/20220927075511.3147847-25-clabbe@baylibre.com/
> >
> > The status of that serie is unknown to me.
> > Not sure by who or when that is going to be merged.
> >
> > Johan
>
> thanks for the feedback, this is my first kernel patch.
no worries, we'll get you through it :-)
> Maybe at this point it is worth trying to combine the two jobs !?
> Or do I still have to modify my patch asking only to add the string in
> the yaml !?
actually you want to go the following route:
(1) pick up
- https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
- https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
as a base to work on
(2) create a patch to add your compatible.
I _think_ after that, the compatible block should looks
something like:
compatible:
oneOf:
- const: rockchip,rk3288-crypto
- const: rockchip,rk3328-crypto
- const: rockchip,rk3399-crypto
- items:
- const: rockchip,rk3228-crypto
- const: rockchip,rk3288-crypto
to handle the new dual element compatible.
make dt_binding_check
should tell you about a wrong format.
(3) modify your dts patch to use the two compatibles
(4) export patches by
git format-patch -2 --cover-letter
and mention in the cover-letter the dependency on the
yaml conversion.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
2022-10-20 8:53 ` Heiko Stuebner
@ 2022-10-20 11:13 ` Michele Zuccalà
2022-10-20 11:24 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Michele Zuccalà @ 2022-10-20 11:13 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Johan Jonker, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, devicetree, Alex Bee, Corentin Labbe
Hi Heiko,
>
> no worries, we'll get you through it :-)
>
thank you
>
> actually you want to go the following route:
>
> (1) pick up
> - https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
> - https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
> as a base to work on
>
> (2) create a patch to add your compatible.
> I _think_ after that, the compatible block should looks
> something like:
>
> compatible:
> oneOf:
> - const: rockchip,rk3288-crypto
> - const: rockchip,rk3328-crypto
> - const: rockchip,rk3399-crypto
> - items:
> - const: rockchip,rk3228-crypto
> - const: rockchip,rk3288-crypto
>
> to handle the new dual element compatible.
> make dt_binding_check
> should tell you about a wrong format.
>
> (3) modify your dts patch to use the two compatibles
> (4) export patches by
> git format-patch -2 --cover-letter
> and mention in the cover-letter the dependency on the
> yaml conversion.
very clear. But excuse the stupid question, this way it becomes a new patchset
and not the v2 of this patch, right?! Will this patch be automatically
ignored ?!
Michele
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: rockchip: add crypto node for RK322x
2022-10-20 11:13 ` Michele Zuccalà
@ 2022-10-20 11:24 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2022-10-20 11:24 UTC (permalink / raw)
To: Michele Zuccalà
Cc: Johan Jonker, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, devicetree, Alex Bee, Corentin Labbe
Hi Michele,
Am Donnerstag, 20. Oktober 2022, 13:13:10 CEST schrieb Michele Zuccalà:
> > no worries, we'll get you through it :-)
> >
>
> thank you
>
> >
> > actually you want to go the following route:
> >
> > (1) pick up
> > - https://lore.kernel.org/all/20220927075511.3147847-25-clabbe@baylibre.com/
> > - https://lore.kernel.org/all/20220927075511.3147847-26-clabbe@baylibre.com/
> > as a base to work on
> >
> > (2) create a patch to add your compatible.
> > I _think_ after that, the compatible block should looks
> > something like:
> >
> > compatible:
> > oneOf:
> > - const: rockchip,rk3288-crypto
> > - const: rockchip,rk3328-crypto
> > - const: rockchip,rk3399-crypto
> > - items:
> > - const: rockchip,rk3228-crypto
> > - const: rockchip,rk3288-crypto
> >
> > to handle the new dual element compatible.
> > make dt_binding_check
> > should tell you about a wrong format.
> >
> > (3) modify your dts patch to use the two compatibles
> > (4) export patches by
> > git format-patch -2 --cover-letter
> > and mention in the cover-letter the dependency on the
> > yaml conversion.
>
> very clear. But excuse the stupid question, this way it becomes a new patchset
> and not the v2 of this patch, right?! Will this patch be automatically
> ignored ?!
The new patchset still should become v2, as it still addresses
your overall goal of adding crypto support for the rk3228.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-20 12:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-19 16:47 [PATCH] arm: dts: rockchip: add crypto node for RK322x Michele Zuccalà
2022-10-19 17:39 ` Johan Jonker
2022-10-20 7:10 ` ilmich
2022-10-20 8:53 ` Heiko Stuebner
2022-10-20 11:13 ` Michele Zuccalà
2022-10-20 11:24 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).