From mboxrd@z Thu Jan 1 00:00:00 1970 From: galak@codeaurora.org (Kumar Gala) Date: Thu, 23 Jan 2014 14:17:19 -0600 Subject: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver In-Reply-To: <20140121230103.GA3554@qualcomm.com> References: <1389380874-22753-1-git-send-email-agross@codeaurora.org> <201401172349.28229.arnd@arndb.de> <20140120225245.GA3530@qualcomm.com> <5548936.L46nLkuVIz@wuerfel> <20140121230103.GA3554@qualcomm.com> Message-ID: <9038342A-D629-479C-819B-EF5F4DB52B50@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Jan 21, 2014, at 5:01 PM, Andy Gross wrote: > On Tue, Jan 21, 2014 at 09:03:43AM +0100, Arnd Bergmann wrote: >> On Monday 20 January 2014 16:52:45 Andy Gross wrote: >> >>>>> +#ifdef CONFIG_OF >>>>> +static const struct of_device_id bam_of_match[] = { >>>>> + { .compatible = "qcom,bam-v1.4.0", }, >>>>> + { .compatible = "qcom,bam-v1.4.1", }, >>>>> + {} >>>>> +}; >>>>> +MODULE_DEVICE_TABLE(of, bam_of_match); >>>>> +#endif >>>> >>>> Also, you can remove the #ifdef here and the of_match_ptr() below. >>>> >>> >>> If this is removed, then I'll have to add the OF dependency in the Kconfig, >>> correct? >> >> I believe it will still compile without the CONFIG_OF dependency, but >> having the dependency still makes sense as it's impossible to use the >> driver without CONFIG_OF. >> >> The best dependency line is probably >> >> depends on (ARCH_MSM && OF) || COMPILE_TEST" >> >> If you expect the same driver to be used on non-MSM platforms from >> qualcomm, e.g. some networking or server equipment, you can also just >> drop the ARCH_MSM dependency. > > > Thanks for the clarification. I think I'll probably do: > ARCH_MSM_DT || (COMPILE_TEST && ARM) Didn?t you need it to be: ARCH_MSM_DT || (COMPILE_TEST && OF && ARM) - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation