From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports
Date: Tue, 09 Sep 2014 23:09:36 +0200 [thread overview]
Message-ID: <9042477.aRbAhpkfQ5@wuerfel> (raw)
In-Reply-To: <540F6646.3010607@ti.com>
On Tuesday 09 September 2014 16:42:46 Murali Karicheri wrote:
> >>
> >> /* update the Vendor ID */
> >> - vendor_device_id = readl(ks_pcie->va_reg_pciid);
> >> - writew((vendor_device_id>> 16), pp->dbi_base + PCI_DEVICE_ID);
> >> + writew(ks_pcie->device_id, pp->dbi_base + PCI_DEVICE_ID);
> >>
> >> /* update the DEV_STAT_CTRL to publish right mrrs */
> >> val = readl(pp->dbi_base + PCIE_CAP_BASE + PCI_EXP_DEVCTL);
> >
> > This change must have slipped in accidentally, at least it's not
> > described in the changelog. Should this be another patch?
> > The change seems useful.
> Are you referring to mrrs or update to device id? device id is in a SoC
> register at index2 and is read and updated by the driver here. MRRS
> update was originally in the code.
>
I meant the device id change. Maybe you accidentally did 'git commit
--amend' during a rebase and that replaced the real changelog with
the one of the patch in front of it and merged the two patches?
That happened to me a few times and would explain the strange mix
of two changes.
Arnd
next prev parent reply other threads:[~2014-09-09 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 20:17 [PATCH v2 1/2] PCI: keystone: remove handle of PCI mode configuration Murali Karicheri
2014-09-09 20:17 ` [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports Murali Karicheri
2014-09-09 20:28 ` Arnd Bergmann
2014-09-09 20:42 ` Murali Karicheri
2014-09-09 21:09 ` Arnd Bergmann [this message]
2014-09-09 21:49 ` Murali Karicheri
2014-09-09 21:51 ` Murali Karicheri
2014-09-09 21:52 ` Arnd Bergmann
2014-09-09 22:50 ` Murali Karicheri
2014-09-10 8:22 ` Arnd Bergmann
2014-09-10 14:28 ` Murali Karicheri
2014-09-09 20:22 ` [PATCH v2 1/2] PCI: keystone: remove handle of PCI mode configuration Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9042477.aRbAhpkfQ5@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox