From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A8CEC3DA4A for ; Mon, 19 Aug 2024 11:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g3AsLUqBfKMisCl4I03Q1DAj0/8iriOUEYeW7RNSf2s=; b=YfgzhYFY4eHJjoS0jz9m9U9KpE ov4vsjehPDocNabktqBiMpMnVXtdAdMo5Owvnx6E+WIB1JJZdmrWpTQgVKI8vH8WQs73mJ+b4TQ4U gbQQ1fPdCy5yTAFVHaYGRqWEKv73dF8vQ7xqQVSoFGeCilizAK/IdCFaLUIrT+Y+TkRdpgAjPgP0r ZUXFoPwQrP+BsaxWoLT5GcsNSMocyT0POpZe41z3PyIrO6A6ehKSVug9aslw0NMn04D3VmztriqNr ZOWINWtKlXDnLeUuRkTbMEoZn/9CG0Iyrcd7Id8LLxjIUSNNOZ2hy7ZWm+yB5stp3PsG6eRH3wHJD sX5WV5tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg0ob-00000001GVn-1FCH; Mon, 19 Aug 2024 11:44:49 +0000 Received: from mail.savoirfairelinux.com ([208.88.110.44]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg0nW-00000001GGc-3Uty for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 11:43:45 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 41B869C5BDF; Mon, 19 Aug 2024 07:43:31 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id l0-j1zBEH9ZD; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 4D1A09C5F74; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 4D1A09C5F74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1724067810; bh=g3AsLUqBfKMisCl4I03Q1DAj0/8iriOUEYeW7RNSf2s=; h=Date:From:To:Message-ID:MIME-Version; b=AaMIVeoUp0XGvy58oS1QXH6phQNWz5ic5K/PnB2LvOWK38amBy7c5YOWrudkWD0Vp o4RmMP9VB8zhaet1baBcMCZUWWGHuBnA+M6SZDaP61Bp+yNSalbzTgvVPUV4LN1PQz 92OLI92ya8VTtQA1BtmYKMyxy+AzdNKjXsxi8XldIYouc91GD+WFFtf5a6uxySlY50 vv5ntTjj6Z8w3hFYFimazNvrJEd52F1UpVF2e2BPIx6iEvyvQrZaAwVyuEKVbVEMTm e9cmcUFdt5RoVKhg6s+8b2NJCjQLLQg3JTAUXTNse/Qgb0DWgXWQ/qd5p64rZ65VOR WSPSc2oOYP2Yg== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id G2C6bNsOuPV7; Mon, 19 Aug 2024 07:43:30 -0400 (EDT) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [192.168.48.237]) by mail.savoirfairelinux.com (Postfix) with ESMTP id E8A2E9C5BDF; Mon, 19 Aug 2024 07:43:29 -0400 (EDT) Date: Mon, 19 Aug 2024 07:43:29 -0400 (EDT) From: Elinor Montmasson To: Shawn Guo Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Catalin Marinas , Will Deacon , Jaroslav Kysela , Takashi Iwai , shengjiu wang , Xiubo Lee , Nicolin Chen , Pengutronix Kernel Team , linux-sound , devicetree , imx , linux-arm-kernel , linux-kernel , alsa-devel , linuxppc-dev , Philip-Dylan Gleonec Message-ID: <905560330.155045.1724067809890.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: References: <20240627083104.123357-1-elinor.montmasson@savoirfairelinux.com> <20240627083104.123357-7-elinor.montmasson@savoirfairelinux.com> Subject: Re: [PATCH v6 6/7] arm64: dts: imx8m: update spdif sound card node properties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC112 (Linux)/8.8.15_GA_4581) Thread-Topic: arm64: dts: imx8m: update spdif sound card node properties Thread-Index: LseD1k2NMHpDg9FbVlB5JHSqjmcCfQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_044343_104442_3536EF7C X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: "Shawn Guo" > Sent: Sunday, 4 August, 2024 16:31:11 > On Thu, Jun 27, 2024 at 10:31:03AM +0200, Elinor Montmasson wrote: >> The merge of imx-spdif driver into fsl-asoc-card brought >> new DT properties that can be used with the "fsl,imx-audio-spdif" >> compatible: >> * The "spdif-controller" property from imx-spdif is named "audio-cpu" >> in fsl-asoc-card. >> * fsl-asoc-card uses codecs explicitly declared in DT >> with "audio-codec". >> With an S/PDIF, codec drivers spdif_transmitter and >> spdif_receiver should be used. >> Driver imx-spdif used instead the dummy codec and a pair of >> boolean properties, "spdif-in" and "spdif-out". >> >> While backward compatibility is kept to support properties >> "spdif-controller", "spdif-in" and "spdif-out", using new properties has >> several benefits: >> * "audio-cpu" and "audio-codec" are more generic names reflecting >> that the fsl-asoc-card driver supports multiple hardware. >> They are properties already used by devices using the >> fsl-asoc-card driver. >> They are also similar to properties of simple-card: "cpu" and "codec". >> * "spdif-in" and "spdif-out" imply the use of the dummy codec in the >> driver. However, there are already two codec drivers for the S/PDIF, >> spdif_transmitter and spdif_receiver. >> It is better to declare S/PDIF Tx and Rx devices in a DT, and then >> reference them with "audio-codec" than using the dummy codec. >> >> For those reasons, this commit updates in-tree DTs to use the new >> properties: >> * Rename "spdif-controller" property to "audio-cpu". >> * Declare S/PDIF transmitter and/or receiver devices, and use them with >> the "audio-codec" property instead of "spdif-out" and/or "spdif-in". >> >> These modifications were tested only on an imx8mn-evk board. >> >> Note that out-of-tree and old DTs are still supported. >> >> Signed-off-by: Elinor Montmasson >> --- >> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 15 +++++++++--- >> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 15 +++++++++--- >> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 24 +++++++++++++++---- >> 3 files changed, 43 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> index 90d1901df2b1..348855a41852 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi >> @@ -180,12 +180,21 @@ cpu { >> }; >> }; >> >> + spdif_out: spdif-out { >> + #sound-dai-cells = <0>; >> + compatible = "linux,spdif-dit"; > > It's recommended that the property list begins with 'compatible'. Could > you flip them? > Yes I'll will do this quickly, thank you. Regards, Elinor Montmasson