From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8F9C43461 for ; Fri, 4 Sep 2020 19:39:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B33E42083B for ; Fri, 4 Sep 2020 19:39:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f/5H9M8Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B33E42083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=orHXiiZapyXBB6gmzIAlTSazq/EciMd8FYFNdtGiQd0=; b=f/5H9M8ZYgrXkOn+00QbegqtM QH3xqnW9oAXyDj/trdI3Fuk0eMfG3Gqc60CZjiGX+B/TXSU3mMS+uhpjenR07dd2fvNJQNJb0IN86 y/3sKsFus2iKpNyiZJp1uQzf2i4s34Yklu2EdV4qhPVueClhB8y8BnIv2EGspV1WwB6g+71iBknN4 86lw6zoa17/1MVqBMfQnqJ58I/gHM/l1N0MlnMpVxfB74jlkAXFIr4U0NESQJPg4ekvlUUS375uuS bXLKKMlasuQZu8MYyrrAU5T+fG1wfpQzHAkR0e8JCpmhjQaYDjd+V/U9FW4HvEpGdAqiKEbtxTObz oC1TPCnBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEHWb-0006zj-5H; Fri, 04 Sep 2020 19:37:29 +0000 Received: from smtprelay0007.hostedemail.com ([216.40.44.7] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEHWY-0006zF-F3 for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 19:37:27 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id D6807181D3028; Fri, 4 Sep 2020 19:37:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: meat92_0910680270b4 X-Filterd-Recvd-Size: 2254 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Fri, 4 Sep 2020 19:37:21 +0000 (UTC) Message-ID: <906c2ffb0ef6b2d87d6aecdf60b61833ea79e4fb.camel@perches.com> Subject: Re: [PATCH v6 18/18] crypto: sun8i-ce: fix some style issue From: Joe Perches To: Corentin Labbe , davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Date: Fri, 04 Sep 2020 12:37:19 -0700 In-Reply-To: <1599217803-29755-19-git-send-email-clabbe@baylibre.com> References: <1599217803-29755-1-git-send-email-clabbe@baylibre.com> <1599217803-29755-19-git-send-email-clabbe@baylibre.com> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_153726_528466_562242BC X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-sunxi@googlegroups.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote: > This patch fix a double empty line issue reported by checkpatch. > While at it, since now the maximum line length is now 100, reorder some > wrapped line. [] > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c [] > @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req > goto theend_key; > } > offset = areq->cryptlen - ivsize; > - scatterwalk_map_and_copy(rctx->backup_iv, areq->src, > - offset, ivsize, 0); > + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, offset, ivsize, 0); > } > memcpy(rctx->bounce_iv, areq->iv, ivsize); > - addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, > - DMA_TO_DEVICE); > + addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, DMA_TO_DEVICE); coding-style.rst: Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Do these longer lines make the code significantly more readable? I don't think they do. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel