From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 342B9C48BEB for ; Wed, 21 Feb 2024 15:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L3XS5D64y5IYhks2KAV74+mH0m5mwB4vc/B+q8IFu00=; b=Pr7J1wVee4USAa AjATWqMGZJmlc8dtV2weJN7JJjKkT02nhBF9ZfulYgisTydRaPmysKjYHhZygOpMcSINRoL0noES3 zWVD2as7P02By0nmvrx+Q61CE3RxSoHKOR+nQ5hRQjAWxcQsZdBMZaag/GX5ESWKuUdQHiVqUvb0V /WjwcLiW5m1Dhdl8Qu3ydLzbeCGfxj85qPHnNLG+nTG/jqMhruIgMc4NFXmM2FyRr884MA3/d1th8 BPYOeFehSMpPnd/3B9fgNGUML/x1iL97NqIFOrBzZXvKD4sympcFfxRzHUtlzwO93wjbavpfaE6X0 XyUtedt+tiIAlbxJ3HhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcofl-00000001WHA-40Eh; Wed, 21 Feb 2024 15:38:13 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcofj-00000001WGY-0FQ5 for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 15:38:12 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-563ed3d221aso8823692a12.0 for ; Wed, 21 Feb 2024 07:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708529889; x=1709134689; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hEKlCTLxshJjrR0vzrCVw2fOtfdhkn1op0+oVphqyTY=; b=h+d5rdN1iPTMzWGb81RCkarg3fZ9htOGdJL4DTns5Cc5O+M34s3cecIjDwEwBcewFT CKmB8H/RgkJnu7+7xQeIdD79vKRaejzmMaFcyGeUuUdOSYSfvJLTG5XqWi/DuecQhypz UKN/ypooycNONRhnrDcKyYMK4WQf78ubxWCf+kVqtm7KiR8L9y4oGLQTukemUtcTKFWh Uyx7Xcobh2cX5phWfgnfphoReOzcMw4I6zzfTjHRID8xpCce+gPNguX6UpgKwjLPmxbY EZonOw1OT8TabUGb7YMZHRbjsutcLayqQLPmTjZpPXV9LKKWVSeke3jLVkILh41fYJpS GOjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708529889; x=1709134689; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hEKlCTLxshJjrR0vzrCVw2fOtfdhkn1op0+oVphqyTY=; b=rpPj0ZRAR9XNRiFmY33HmQLPf02FONq+ZrpnyTjDQByjm7gQzkbv2k+tfnlut8p0yJ T0wLHnTpUXPP9tbtpeq0N9K5aIvvCKTc4ySkhieyexoPPLt7BnGm/Y/OuwbYjQe/40nV zbtMPqcOwU+f2Vx2pHjeGDtGYX4i+gF56cqmhFeoV1fbajKA+G6fiNMezV/WJ4usCBky drsQ6oSD/IYGlX6Hr/53Nrh2u/9PFQZzhRUMyimCvQYGL4zDyRnA6iixrYEWqIkxolZE ksAyabvyoHn8UE3u0pjhfmcOakGg+SrxzHif+o2cJZlz7QImDx+4Z4ns0vNyoIMvDbpS BRNw== X-Forwarded-Encrypted: i=1; AJvYcCXpXFw5T6UdRa8mQPGo+mXfJ36BiG0BaPWFM3Va2dQvlWnf7RrcV/e8HfNRYrT6h9coxsInQGAStsKSK/7kHash0dHsiryUgaVvE0pQ/jJW6bPlhMw= X-Gm-Message-State: AOJu0YwLD3V7UBScYip1ZMSMc0934cHvds1IRt0xViP+GILEyuHFdFPw iMXQelTL2hKI5rJVfZDDCyA5c4bvYpGuJc7hx8mEJk7BeTkbMYhBKhs3k9SqgcE= X-Google-Smtp-Source: AGHT+IEgXPNY6KfzFpIIWCqBy8a4c+A0dwKx0vGppcKeYOF5uwpqzsk0YGrWOxXxlUbWaIyBAGxC6g== X-Received: by 2002:a17:907:86a3:b0:a3e:f9ae:4764 with SMTP id qa35-20020a17090786a300b00a3ef9ae4764mr5641304ejc.38.1708529889062; Wed, 21 Feb 2024 07:38:09 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id tb21-20020a1709078b9500b00a3e51df2280sm4090336ejc.223.2024.02.21.07.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 07:38:08 -0800 (PST) Message-ID: <9083c414-62f2-4bff-93ee-13f8ff60eb34@linaro.org> Date: Wed, 21 Feb 2024 16:38:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: defconfig: Enable zram, xfs and loading compressed FW support Content-Language: en-US To: Maxime Ripard Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Enric Balletbo i Serra , Erico Nunes , Brian Masney , Arnd Bergmann , Bjorn Andersson , Catalin Marinas , Geert Uytterhoeven , Konrad Dybcio , Marek Szyprowski , Neil Armstrong , Will Deacon , linux-arm-kernel@lists.infradead.org References: <20240221141350.3740488-1-javierm@redhat.com> <1f28256c-e436-4add-aa67-2cfb2248b220@linaro.org> <6scz7iti3tzzrd4ph3gnuc2pvkcbtuuicgfgujh3pa3c34kdkt@bhfa4xbxeu7t> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_073811_141706_41CE582D X-CRM114-Status: GOOD ( 37.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/02/2024 16:24, Maxime Ripard wrote: > On Wed, Feb 21, 2024 at 04:10:12PM +0100, Krzysztof Kozlowski wrote: >> On 21/02/2024 15:48, Maxime Ripard wrote: >>> On Wed, Feb 21, 2024 at 03:22:38PM +0100, Krzysztof Kozlowski wrote: >>>> On 21/02/2024 15:13, Javier Martinez Canillas wrote: >>>>> These options are needed by some Linux distributions (e.g: Fedora), so >>>> >>>> How ZRAM is needed? Why Fedora cannot boot without it? Debian, which I >>>> use on my arm64 boards, does not have any problem. >>> >>> Is it relevant in any way? >> >> Yes, because it is justification why we are doing it. Each commit is >> supposed to explain "why" and the explanation here is not enough. > > There's a why though: it makes Fedora boot. It might not be enough for I want to know to understand. Maybe it is not really neeed but "nice to have"? People write various vague statements... > you, but that's a different story. So, if it's not enough, please state > exactly what you expect from that patch description so Javier can > provide it. Any explanation what ZRAM is necessary for Fedora to boot. > >>> I'm sure Debian can boot without MEMORY_HOTREMOVE, or BRIDGE, or >>> NUMA_BALANCING, or BPF_JIT, or NFS_FS, yet all of them are enabled. Let >>> me know if you want hundreds more examples. >> >> So if there is any bug, you are allowed to add new one? If there is any >> silly option, you are allowed to add new one? >> >> Feel free to propose dropping of any irrelevant options. > > No, of course you aren't. My point is that Fedora is a distro just as > established and legitimate as Debian is. And apparently "it makes Debian > works" is a reasonable argument, since, well, it does. > > If making Fedora boot with that defconfig is not a legitimate goal, It is, but I asked for more information. > please state why, and document it (with the ack of all the maintainers > involved with that defconfig, obviously) so we don't have the same > argument over and over again. > >>>> I kind of repeat comments from similar patch earlier: >>>> https://lore.kernel.org/all/fe1e74a2-e933-7cd9-f740-86d871076191@linaro.org/ >>>> >>>> About XFS: I don't think it is needed to boot anything. >>> >>> Just like 9P_FS, NFS or UBIFS. >> >> NFS is often used on targets, e.g. my board farm, but also by other people. >> >> UBIFS was added recently because one device was using it - you needed >> it. 9P_FS looks unnecessary. > > So all we need is one person or use case to require it? Sounds like > we've checked that mark here. Use case of given type. I would disagree for SMBFS because we have NFS. UBIFS is hardware requirement. 9P_FS seems like virtio case. > >>>> This is a defconfig, not a distro config. Please don't make it distro. >>>> >>>> I will gladly support things needed by systemd or equivalent, but not >>>> unusual filesystems needed by distro. >>> >>> It's a defconfig. It's whatever people want it to be. Or we need to come >>> up with a clearly defined set of rules of what is acceptable in that >>> defconfig or not, and prune every option that isn't. >> >> So that's the rule I am commenting from time to time. defconfigs are not >> distro configs. These are reference hardware configs and debugging >> configs. > > Supporting a board farm is hardly either. Debugging purpose, but I agree we can drop it. > > And again, I've never heard of such rule for that defconfig in my ~10y > as an ARM platform maintainer. But what do I know, right? > >> I was working in distro so trust me - they do stuff differently >> and they not need XFS in our defconfig for anything. > > Sure, but you're not just arguing for XFS there. I raised need for "why" for ZRAM and un-necessity of XFS. What's wrong with that? I should send separate emails or what? > > What I really don't get is this: this makes the life of people easier. Again: this makes my life harder. I cannot be buying new machines every two years to be able to compile defconfig while testing/working. > > Being able to test an upstream kernel quickly when you have a bug in a > downstream distro is super valuable for any distro developper. And on That's a distro need, not relevant. And even if it was, then your argument would be "let's enable everything distro has!". This is not a distro kernel. > the long run, if we don't make the switch from a kernel distro to a > mainline kernel relatively easy, we're the ones that will lose out. > Because people just won't bother, or be frustrated and thus super > reluctant to do that work. > > That's the part I don't get. Why do we want to make the life of people > harder. This patch has never been about making the defconfig the main Because it makes my life harder and I don't see benefits. Quoting Arnd: "Unfortunately this will increase build time noticeably, but" Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel