From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF85C2BD09 for ; Sat, 6 Jul 2024 09:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:Message-ID:In-Reply-To:Subject:cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hIMBk3gcgtJmsvzVgZYSk+DX15sDxaGd5cW7BACK2aY=; b=EQleTSqrXKDIBGkw347Bk5SY6U ucFw4NLIefy/MPD4D+w4PFLGp+EfJrk01kiRmgJkmwtTijTwfHXXj843kECJwaEu3mJJHvj0xjcEy FmsPgqT02PMVmyhSfah771ngRHfPwZhwf4CsBitLRXa9Af9QK2L+ILo/KVRmQ8SPDRKmtlvDACcjQ Fepf8RyGlDjgl0OYH4uI2/HISxJwWLRPTLgecaNujFEM9hfGqfhHK07cQ0RotUqQgMBwrueH+Y08q 9Sqjatqdg8Z+YbljD5/+9SHWgQPRjL8tDzZPYhhN9a/dUpUinNAUc+Rwjh4Qs/hVClBudpalX0MAc NOiMPh3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ1wP-000000001By-3bST; Sat, 06 Jul 2024 09:42:49 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ1wC-0000000019q-0SMA for linux-arm-kernel@lists.infradead.org; Sat, 06 Jul 2024 09:42:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720258956; x=1751794956; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=EfOH0ee65Mbsv21aaTB5rIxDZK4vVm3UDUvFn9IsodE=; b=RZPYp1ieFQhAvPlSsIxD4acLqAm/At3kqXovIqOCQgerfdfQTVrR0t1q zrvi4ILYsg1L9tg8yhJpbBh4o59AvNXu5Z4+taWLqLBz1mWABU9eac4ty QSYqRyrVvEb4Cgmso7AxHFnpLfoWAPSSqliwY7Y5C5jLm/2vI6ikBmI8m Y94cTWwDiwVjFPjJ8SFq9Zjeg2FvIXiQTN27EdH/OM57QtjC7WXyM2Tg6 /+MI2E0L/RuR089Ai6q5SA4a1g24PeKhWsxnS2hvNHKi0ar8k4AxgfV+V VjmVr5IwixwG1tM6JawTPnxGAje42W9GsjIoFB65cu2/QXKpL8FbpdNEN w==; X-CSE-ConnectionGUID: 5Dg9wyyfTW2jcI3hIGCsjg== X-CSE-MsgGUID: /PLJp9suTr2RPpgpZMJ5Qw== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="17171867" X-IronPort-AV: E=Sophos;i="6.09,187,1716274800"; d="scan'208";a="17171867" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2024 02:42:35 -0700 X-CSE-ConnectionGUID: xeEMCvjbSfafzbH4CUyBUw== X-CSE-MsgGUID: LCQoj60JRuaDZ0dHPelyiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,187,1716274800"; d="scan'208";a="51896563" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.247.111]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2024 02:42:31 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Sat, 6 Jul 2024 12:42:27 +0300 (EEST) To: =?ISO-8859-15?Q?Marek_Beh=FAn?= cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede Subject: Re: [PATCH v2 08/30] irqchip/armada-370-xp: Simplify is_percpu_irq() code In-Reply-To: <20240702114302.22475-9-kabel@kernel.org> Message-ID: <908a5903-dcec-21a8-dc86-667cb920043b@linux.intel.com> References: <20240702114302.22475-1-kabel@kernel.org> <20240702114302.22475-9-kabel@kernel.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-1100769558-1720258947=:1194" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240706_024236_186239_3FE71E37 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1100769558-1720258947=:1194 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Tue, 2 Jul 2024, Marek Beh=C3=BAn wrote: > Simplify the code in the is_percpu_irq() function. Instead of > if (condition) > return true; > return false; > simply return condition. >=20 > Signed-off-by: Marek Beh=C3=BAn > Reviewed-by: Andrew Lunn > --- > drivers/irqchip/irq-armada-370-xp.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-ar= mada-370-xp.c > index b9631cc25c0b..cfd6dc803150 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -201,10 +201,7 @@ static inline unsigned int msi_doorbell_end(void) > =20 > static inline bool is_percpu_irq(irq_hw_number_t irq) > { > -=09if (irq <=3D MPIC_MAX_PER_CPU_IRQS) > -=09=09return true; > - > -=09return false; > +=09return irq <=3D MPIC_MAX_PER_CPU_IRQS; > } > =20 > /* >=20 Reviewed-by: Ilpo J=C3=A4rvinen --=20 i. --8323328-1100769558-1720258947=:1194--