From: Krzysztof Kozlowski <krzk@kernel.org>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Peter Rosin <peda@axentia.se>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Nuno Sa <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, upstream@lists.phytec.de
Subject: Re: [PATCH 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells
Date: Thu, 4 Sep 2025 12:44:28 +0200 [thread overview]
Message-ID: <90aa7f8a-9ce1-425d-a988-3c1f9990ec4d@kernel.org> (raw)
In-Reply-To: <b6006a1b-0b46-4e0d-9d49-6cc0dbe84814@norik.com>
On 04/09/2025 12:15, Primoz Fiser wrote:
> Hi Krzysztof,
>
> On 4. 09. 25 11:17, Krzysztof Kozlowski wrote:
>> On Wed, Sep 03, 2025 at 01:36:59PM +0200, Primoz Fiser wrote:
>>> The current-sense-amplifier is an IIO provider thus can be referenced by
>>> IIO consumers (via "io-channels" property in consumer device node). Such
>>> provider is required to describe number of cells used in phandle lookup
>>> with "io-channel-cells" property, otherwise the following kernel error
>>> is present:
>>>
>>> OF: /iio-hwmon: could not get #io-channel-cells for /current-sense
>>
>> Also, how can I reproduce this error? Do you paste here real errors or
>> just some invented ones from some out of tree code (hint: such would not
>> be relevant).
>
> I get this error if I apply patch #2 without patch #1. See [1] for more
> details.
Then your warning is not relevant here.
You said in your commit there is a bug, expressed with that warning, so
you make this commit. Turns out there is no bug, so all the reasons for
this commit are gone.
Rephrase the commit msg to describe accurate reasons WHY you are doing
this. Drop non-existing warnings and any misleading fixes tag, since
there is no bug being fixed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-04 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 11:36 [PATCH 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Primoz Fiser
2025-09-03 11:37 ` [PATCH 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon Primoz Fiser
2025-09-04 9:16 ` [PATCH 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Krzysztof Kozlowski
2025-09-04 9:17 ` Krzysztof Kozlowski
2025-09-04 10:15 ` Primoz Fiser
2025-09-04 10:44 ` Krzysztof Kozlowski [this message]
2025-09-04 11:20 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90aa7f8a-9ce1-425d-a988-3c1f9990ec4d@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=peda@axentia.se \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox