From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E464DC4332F for ; Sat, 15 Oct 2022 21:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=roFI1gFIsK5nQ5/lNgDgAetaREVr5C4P7st8x/xHjNE=; b=k9CZ0xXl1DEnJ5 8/FevNZwu1JqBiVH1IuBp5shyuv/8PN14JKhOz2pKSPBzif6NCezaS7iFmTegPnjxZU9BEpAA3tP6 nspu9tk7yxbE3c9wbKLzKwkVvjcaf8b/PtZi3UQOh4iSwjgTVack42okXtB0DUOuakqLf2zhbl1D4 ZUbFKhn9PPtxSQumqv7R0Kh7aHp7cHuT8CWbSIvbMA3OCMSMB6yACfAQ7Wfmo0lz2z3Dydv8cuO5Y N7yDJMM51pio+X/M5/NOkM9LuGAII35tZoLq+2d569auu4IoMZZhFWXfepBf/1Jn82uC/wNB0z8IA qS5EOio1geTp8jtT83Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojoqK-0005QY-Uc; Sat, 15 Oct 2022 21:37:17 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojoqH-0005Pt-FS for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 21:37:14 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BA69084C60; Sat, 15 Oct 2022 23:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665869832; bh=uRbP9Pbodg+ge1e9KjYY/y4+n4ffCzR8RDLeg56nY7I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WRgNp22zaL9hseJbLU8PNwQDlqTwV7UBy3YEi1v94gh2I1mGcaq2VLY/1g+4553Ze VtouUnVtCFAjcrHY2WlEjchZ98ffPDUDhzNaH6QqFFZN9JOtBDnBhUrIac7qtME2KJ 3KPWxCZSoukXTxk8fwIY/pqyPt+9hshjJJCwWsL1XwgRNuSKSboTPuyQoOQmIWP6pL Q/L04k6ZCjQUOC3ttidCApAO2G/IPn25bSNMB8xBZZjSWE87SNeil9fX1wNTHdv+Cq KBLY2qKQPDWvc3YAYVmiGPmrfQCE+fw0VdCIKqQ3JDYnGVKJxJBPWHveVQz6pys2yz dvdb9e5B8bn2Q== Message-ID: <90ab7268-ca93-0598-e09b-258030654545@denx.de> Date: Sat, 15 Oct 2022 23:37:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v7 08/10] drm: bridge: samsung-dsim: Add input_bus_flags Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20221005151309.7278-1-jagan@amarulasolutions.com> <20221005151309.7278-9-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20221005151309.7278-9-jagan@amarulasolutions.com> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_143713_697330_CFDC1C0B X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/5/22 17:13, Jagan Teki wrote: [...] > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c > index f714e49c1eab..f5cd80641cea 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -1601,6 +1601,10 @@ static const struct samsung_dsim_host_ops samsung_dsim_generic_host_ops = { > .unregister_host = samsung_dsim_unregister_host, > }; > > +static const struct drm_bridge_timings samsung_dsim_bridge_timings = { > + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, > +}; > + > int samsung_dsim_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -1681,6 +1685,7 @@ int samsung_dsim_probe(struct platform_device *pdev) > > dsi->bridge.funcs = &samsung_dsim_bridge_funcs; > dsi->bridge.of_node = dev->of_node; > + dsi->bridge.timings = &samsung_dsim_bridge_timings; Is this really valid on Exynos too ? My impression is that the DE_LOW requirement is only needed for MX8MM/MN where the LCDIF-DSIM glue logic inverts the HS/VS/DE signals, while on all other platforms (at least MX8MP) the inversion does not take place, so DE is really active HIGH there. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel