From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F486C4332F for ; Wed, 19 Oct 2022 17:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mEdY2dJsRxXLlzD/p1rcggCPsZE6KUFnrBTdr3d8BRg=; b=uziUPE6drrQuXT GJgXVXEeP32vEx5trJyCmZ5riRU52MVnVAUrFfwCQrM3/rM6DR16WgZL1VpVtHlUkEVN0eP1UdsPS SiQKpXG1GSwpfGn6GzckHXXcjP2WJajYB8kIlNkrn7fyj++29wM+iUg76wCWhKcvHwJLFaN7y5EOT syKKScN1MLbNpJXZetYWCmehEfUDhdh17irJ4cdyiDibEfUrO8LUtJq4dU7lio7IUHL5XOe6xiuQo iy63R7FnqY9S5W1GfXjxwBSMgOK8jJeWpdXlKC/X4+lwCXHd2lbPhBA6+bmhQdHTSBuNw56lHfzMB VoflbM7B/Umac2YkIy7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olCq5-004Y1H-ES; Wed, 19 Oct 2022 17:26:45 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olCpz-004Y05-2R for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 17:26:40 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 29JHQXLG116399; Wed, 19 Oct 2022 12:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1666200393; bh=3hvx9pr5K+0guJn4DKXmTSuodCT3VlQZ4faEGDqq4No=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=v2YFb2MRCK2ydlVtJg3M8fj+9tfFUlNJSrR81RTgl+kRfVt+1at2w9sIgjM29DnsB 50HZbFREPlqJ/t4hwfdylSqSedOpk0cA3eRzx4aLjASO4Ez24CNIGO2ApNcGyLXEHa UjTixXMg1pnkfrKjELk/Brh1IpO4hh+kTJBt05sM= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 29JHQXM6047730 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 19 Oct 2022 12:26:33 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Wed, 19 Oct 2022 12:26:33 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Wed, 19 Oct 2022 12:26:32 -0500 Received: from [10.250.33.68] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 29JHQVvj123567; Wed, 19 Oct 2022 12:26:31 -0500 Message-ID: <90cbb65b-389e-95b5-26d8-39bc33f88df6@ti.com> Date: Wed, 19 Oct 2022 12:26:31 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 3/4] arm64: dts: ti: Add initial support for J784S4 SoC Content-Language: en-US To: Apurva Nandan , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Linus Walleij , , , , CC: Hari Nagalla References: <20221014082314.118361-1-a-nandan@ti.com> <20221014082314.118361-4-a-nandan@ti.com> From: Andrew Davis In-Reply-To: <20221014082314.118361-4-a-nandan@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_102639_227973_77485A4C X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/22 3:23 AM, Apurva Nandan wrote: > The J784S4 SoC belongs to the K3 Multicore SoC architecture > platform, providing advanced system integration in automotive, > ADAS and industrial applications requiring AI at the network edge. > This SoC extends the K3 Jacinto 7 family of SoCs with focus on > raising performance and integration while providing interfaces, > memory architecture and compute performance for multi-sensor, high > concurrency applications. > [...] > + > + hwspinlock: hwlock@30e00000 { > + compatible = "ti,am654-hwspinlock"; > + reg = <0x00 0x30e00000 0x00 0x1000>; > + #hwlock-cells = <1>; > + status = "disabled"; Why is this disabled? The node is complete and usable. I do not know if we settled on a set of rules for disabling nodes by default in the dtsi, I couldn't find one if we did, but how does this sound, If a node in a dtsi file is incomplete, or the described hardware unusable, without additional information provided by board-level additions, then the node may be disabled. Otherwise it must be left in the default enabled state. Without something like that, we will end up with the same problem we are trying to fix here, but in reverse, one will have to enable nodes in board files that would not otherwise need to refrenced. Worse that sounds like a configuration setting, not a hardware description, so it would not belong in the device tree. Same for main_ringacc, main_udmap, cpts, and mcu_navss below. > + }; > + [...] > + > +#include > +#include > +#include > +#include > + > +/ { > + Extra newline not needed. Andrew > + model = "Texas Instruments K3 J784S4 SoC"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel