From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E0D8C021B2 for ; Sun, 23 Feb 2025 07:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YO/cwSARohYD9TXD0q8IqQzlCY/DK1djNp+I0Bb/gO0=; b=w6d9YYe8QBLKWXF21HQ/87N2BO 6Fl23TxQ4P0sQY62x0r/JaYyUrVtcPeeuzbZLDjoqoL7uS7vKQ6bcOlg39/pV8ShCpb4EmQVe1SSC 8zUKWgU4/c3p5yRhHqLx1dK46CIwcrpt7EGDjT4szQcQCYqu6ENE4Rg6dx8vd4iziCT02NYj/mezO ZyVx+vYtzGNDDEoMlGkuXLz/vH+qEQ8BEKiFHzYZENVkKxTlvlAqpsV/D6Ao5R/mDiiXKTzi1/EQ6 6G4kBWSJ2ok9t9iG7iMfzerAXrRx0C70YKB/5xli7p5eVWnWoLVcSVB9O9Ge8B/soG1phKecSNoIs UisO5wRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tm6Vh-0000000AbRB-0Ny6; Sun, 23 Feb 2025 07:34:45 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tm6UD-0000000AbFw-1JgC for linux-arm-kernel@lists.infradead.org; Sun, 23 Feb 2025 07:33:15 +0000 Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53]) by mailfout.phl.internal (Postfix) with ESMTP id 02074138098D; Sun, 23 Feb 2025 02:33:10 -0500 (EST) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-13.internal (MEProxy); Sun, 23 Feb 2025 02:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=testtoast.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1740295989; x=1740382389; bh=YO/cwSARohYD9TXD0q8IqQzlCY/DK1dj Np+I0Bb/gO0=; b=B85Pk0aHwQOrsXRWLCJZbxiYDDxHSLrrHPt3K81mN79wkUP/ Tsw9D8bX4J6WRPjHYjWFlT80ErJ8ITWr3JGVF/JGjS9lvhFLOowTpY3XbbNdSeIZ JVxL68NfTI8aKGboE+XqXsGmDl5YrWGKYuwP/K4jX/l3Z+RCRXdEGqpmhlh6Htj9 jlN6sBZymlaE0D/DwHoysrKtOK2gqaOsM2xgnq6RSdZbla07qWS5uOYEIhH5XQqq cRe9aDkRCKJIZ1k81gJal7gWFXaJcPk7d6OHzYWADxOwOuXs9240xLhaz18ZoJtp yZ7xxbYOcmluZZwdVJZM5k3PxN0/iqy3wxD1hg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740295989; x= 1740382389; bh=YO/cwSARohYD9TXD0q8IqQzlCY/DK1djNp+I0Bb/gO0=; b=O OkWfm1qlADVUEjPOFggO5OUEZznUfHAn/OLo62JPh4oIaW+0g/vtuCVP1jQ9NL0f rcBn0tg5BbvZ5OkC47NPux3WJxOjuBx3lQVgAQT65e1D8l2pxGYLVSTGRLSVA5So DfIEf7TO0kwz8Hfsznch7YMDCjU3y4xA3GlByicglwNR9ht+5Y/CxSK8LwjFo1UW RYXhgSAtfDNC1+a88NJ6qj4pdSvIhDq6L1YF3WtKqphi7PtrRaTjrn4hxspRWIYs 3yR9TWLQz6M1LmZFrkGbSqYPDI7scGrG2An6m0/OfTiHjxSZbLimjxIo3hj+3K24 A127Uh6twNK0BHjdTlh4w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejhedvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdfthigrnhcuhggrlhhklhhinhdfuceorhihrghnsehtvghsthhtoh grshhtrdgtohhmqeenucggtffrrghtthgvrhhnpeeghffgkedtueeiudeukedvveevhfdu uefhhedviefgffduheeuieeihefhfefgveenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehrhigrnhesthgvshhtthhorghsthdrtghomhdpnhgs pghrtghpthhtohepvdefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrnhgurh gvrdhprhiihiifrghrrgesrghrmhdrtghomhdprhgtphhtthhopehmthhurhhquhgvthht vgessggrhihlihgsrhgvrdgtohhmpdhrtghpthhtohepfigvnhhssegtshhivgdrohhrgh dprhgtphhtthhopegurghnihgvlhesfhhffihllhdrtghhpdhrtghpthhtoheprghirhhl ihgvugesghhmrghilhdrtghomhdprhgtphhtthhopehjvghrnhgvjhdrshhkrhgrsggvtg esghhmrghilhdrtghomhdprhgtphhtthhopehkihhkuhgthhgrnhelkeesghhmrghilhdr tghomhdprhgtphhtthhopehmrggtrhhorghlphhhrgekvdesghhmrghilhdrtghomhdprh gtphhtthhopehsihhmohhnshdrphhhihhlihhpphgvsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: idc0145fc:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 76A89BA006F; Sun, 23 Feb 2025 02:33:07 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sun, 23 Feb 2025 20:32:46 +1300 From: "Ryan Walklin" To: "Jernej Skrabec" , "Maxime Ripard" , "Chen-Yu Tsai" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Daniel Vetter" , "Samuel Holland" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Michael Turquette" , "Stephen Boyd" Cc: "Andre Przywara" , "Chris Morgan" , "Hironori KIKUCHI" , "Philippe Simons" , "Dmitry Baryshkov" , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Message-Id: <90ecf54e-cd2d-4cf7-96f0-d93448111a7c@app.fastmail.com> In-Reply-To: <15402414.tv2OnDr8pf@jernej-laptop> References: <20250216183710.8443-3-ryan@testtoast.com> <20250216183710.8443-25-ryan@testtoast.com> <15402414.tv2OnDr8pf@jernej-laptop> Subject: Re: [PATCH v7 24/27] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250222_233313_942655_869FC509 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 23 Feb 2025, at 8:15 PM, Jernej =C5=A0krabec wrote: >> + if (mixer->cfg->de_type =3D=3D sun8i_mixer_de33) >> + regmap_write(mixer->top_regs, SUN50I_MIXER_GLOBAL_DBUFF, >> + SUN8I_MIXER_GLOBAL_DBUFF_ENABLE); > > This was my mistake. There is no such thing as=20 > SUN50I_MIXER_GLOBAL_DBUFF in DE33 > anymore. Values are generally applied at vblank time (I think). Above=20 > write actually > writes to RCQ register, which is not great. Just drop this code and fi= x=20 > condition to !=3D. Ah yes, good spotting. >> +static const struct sun8i_mixer_cfg sun50i_h616_mixer0_cfg =3D { >> + .ccsc =3D CCSC_MIXER0_LAYOUT, >> + .de_type =3D sun8i_mixer_de33, >> + .has_formatter =3D 1, >> + .mod_rate =3D 600000000, >> + .scaler_mask =3D 0xf, >> + .scanline_yuv =3D 4096, >> + .ui_num =3D 3, >> + .vi_num =3D 1, >> + .map =3D {0, 6, 7, 8}, >> +}; >> + >> static const struct of_device_id sun8i_mixer_of_table[] =3D { >> { >> .compatible =3D "allwinner,sun8i-a83t-de2-mixer-0", >> @@ -832,6 +907,10 @@ static const struct of_device_id sun8i_mixer_of_= table[] =3D { >> .compatible =3D "allwinner,sun50i-h6-de3-mixer-0", >> .data =3D &sun50i_h6_mixer0_cfg, >> }, >> + { >> + .compatible =3D "allwinner,sun50i-h616-de33-mixer-0", >> + .data =3D &sun50i_h616_mixer0_cfg, >> + }, > > This should go to separate patch, adding feature (DE33) and adding cor= e support > are two distinct things. Thanks, will split those out.=20 Regards, Ryan