From: peda@axentia.se (Peter Rosin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver
Date: Mon, 23 Jul 2018 08:12:17 +0200 [thread overview]
Message-ID: <911dc259-7b30-9c6e-2c82-2f4c032b9d73@axentia.se> (raw)
In-Reply-To: <20180723034025.5763-6-manivannan.sadhasivam@linaro.org>
On 2018-07-23 05:40, Manivannan Sadhasivam wrote:
> + /* Handle the remaining bytes which were not sent */
> + while (!(readl(i2c_dev->base + OWL_I2C_REG_FIFOSTAT) &
> + OWL_I2C_FIFOSTAT_TFF) && i2c_dev->msg_ptr < msg->len) {
You moved the OWL_ line to the left instead of right, so this is still
misaligned and thus not helping the reader.
Cheers,
Peter
> + writel(msg->buf[i2c_dev->msg_ptr++],
> + i2c_dev->base + OWL_I2C_REG_TXDAT);
> + }
next prev parent reply other threads:[~2018-07-23 6:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 3:40 [PATCH v6 0/6] Add Actions Semiconductor Owl S900 I2C support Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 1/6] dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 2/6] arm64: dts: actions: Add pinctrl definition for S900 " Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 3/6] arm64: dts: actions: Add Actions Semiconductor S900 I2C controller nodes Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 4/6] arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver Manivannan Sadhasivam
2018-07-23 6:12 ` Peter Rosin [this message]
2018-07-23 7:24 ` Manivannan Sadhasivam
2018-07-23 7:24 ` Andy Shevchenko
2018-07-23 7:40 ` Peter Rosin
2018-07-23 3:40 ` [PATCH v6 6/6] MAINTAINERS: Add entry for Actions Semiconductor Owl " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=911dc259-7b30-9c6e-2c82-2f4c032b9d73@axentia.se \
--to=peda@axentia.se \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox