From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01095606A31C for ; Tue, 17 Nov 2026 13:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=I4y0X0Ly; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=ERMF1Msp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=JUOdabo39cYI+zW/eEKHZMnZIatTlY+cId8myHDRV2s=; b=I4y0X0LyCfVo4w AKFJ1P+MEIe1qdHiDZKCrlpht2H1WkjGZRtGuv6ISKf1ueEzDFkvc4whArWjNzgRDHzUNBPz3M7MI /koTSeFqx8aWKKYpj32X2Ju0VW3SRdUKoH5W6RPjFTA2TmdlLC9Zmvkdt9qAnZWdndvwPW8T7M21d PSHEgxegOxNu7Vx78jLW+iCrEK4M72zA6lljg68CpdmB7wAoomNX2jDNpAdPeJiLLFkyO9lT2BJ1w Lh86ZhN/xcIFprPsi9QTn8s+DqJDqwD+dYPgTxiI/OvXRGfexjryOnQR7j5/cFcEwt6VYG5RDSE9B X33MxJmfo0b5xKCvLYgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTInt-00000005ng2-13dG; Tue, 17 Nov 2026 13:00:53 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTInd-00000005nUG-01C1; Tue, 17 Nov 2026 13:00:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1794920435; bh=J3o9ngeXHrhSGhzzdLAJVM84tQSLjRDwo0it59TZFqc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ERMF1MspUmEZvVpSORcKjItgszj/8BSvOB7x26APsQ2AQSpzeeccdcBlX7+uLPgbP PxE+G9cS86OImKnO9S3Fx1Urkk1FO3bjGCyuq/yWstbF0Wg2FNF/PBgZhQfAkekTE5 jmeuiIKolKkdeMejklUybPd6XuNbLsTbeI8E7C0lSsf9T95zz9viG/QVv8Hh0kXVHW XaOofoZTYtmUo0DgaTtb4P7bt/S31/+Mxb7E9N8mCDxM6PXcWNDoPGOJo1F4PZIsSN wq+nd1nkUYXI5niB/Kwy2kizEsn4M8Ap5ty5KpVCxzRZgzLTUfDEy4nd9YZxka9AJC 4gSt9pr6OYUKw== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3A52E17E00E8; Tue, 17 Nov 2026 14:00:34 +0100 (CET) Message-ID: <911e4163-8a2c-4ca2-8903-8d3ddb7266e8@collabora.com> Date: Tue, 17 Nov 2026 14:00:33 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: mediatek: mt8167: Add DRM nodes To: Krzysztof Kozlowski , Luca Leonardo Scorcia , linux-mediatek@lists.infradead.org Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , CK Hu , Jitao shi , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260921113914.779393-1-l.scorcia@gmail.com> <20260921113914.779393-5-l.scorcia@gmail.com> <200ef6c1-eced-4c36-832d-3fb409aac866@collabora.com> <5715e9e5-857d-4104-aedd-9662da0fc0ab@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <5715e9e5-857d-4104-aedd-9662da0fc0ab@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_050037_237686_544FB442 X-CRM114-Status: GOOD ( 15.37 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/17/26 13:55, Krzysztof Kozlowski wrote: > On 17/11/2026 13:53, AngeloGioacchino Del Regno wrote: >> On 11/17/26 13:35, Krzysztof Kozlowski wrote: >>> On 21/09/2026 13:38, Luca Leonardo Scorcia wrote: >>>> Add all the DRM nodes required to get DSI and DPI to work on MT8167 SoC. >>>> >>>> Signed-off-by: Luca Leonardo Scorcia >>>> Reviewed-by: AngeloGioacchino Del Regno >>>> --- >>>> arch/arm64/boot/dts/mediatek/mt8167.dtsi | 369 +++++++++++++++++++++++ >>>> 1 file changed, 369 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8167.dtsi b/arch/arm64/boot/dts/mediatek/mt8167.dtsi >>>> index 27cf32d7ae35..a50bae4307c1 100644 >>>> --- a/arch/arm64/boot/dts/mediatek/mt8167.dtsi >>>> +++ b/arch/arm64/boot/dts/mediatek/mt8167.dtsi >>>> @@ -16,6 +16,22 @@ >>>> / { >>>> compatible = "mediatek,mt8167"; >>>> >>>> + aliases { >>>> + aal0 = &aal; >>>> + ccorr0 = &ccorr; >>>> + color0 = &color; >>>> + dither0 = &dither; >>>> + dpi0 = &dpi0; >>>> + dpi1 = &dpi1; >>>> + dsi0 = &dsi; >>>> + gamma0 = γ >>>> + ovl0 = &ovl0; >>>> + pwm0 = &disp_pwm; >>>> + rdma0 = &rdma0; >>>> + rdma1 = &rdma1; >>>> + wdma0 = &wdma; >>> >>> Folks, what is happening here? Why Mediatek is adding bunch of >>> undocumented aliases? This should have never been accepted to Mediatek SoC. >>> >> >> It's always been like this on MediaTek from day 1, what's up with that!? > > I wrote what is wrong - they are undocumented. You were never allowed to > add undocumented ABI, never. Even 10 years ago. > Well, that's right. > I don't know what is day 1 in this context, but for a few (5-8 years?) > we do not allow more custom aliases. Neither new DTS users of these. > That actually poses a severe issue, as mediatek-drm relies on aliases to find out the instance number of the display controller components, on all SoCs. Any advice on how to possibly resolve this without rewriting the entire thing? Mapping that by mmio address in the driver seems too stupid/dirty/bad/etc. Thanks, Angelo