From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F374AC433F5 for ; Tue, 26 Apr 2022 15:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+aKgE9inRWIQCffpMrYGs1o9zYllSb8OIgiEuP0U8a4=; b=NzInAOoFCTBUxp vCfi+vkHfHPjGtMogpNViV+4/knKh5eVkqygm0TY0R1DXW+TRtOvzFMps7SLUKA9Igvo+X0lYtUwP v/YUSuprDO+Lwmhwvi+k/4G3QiF11iBBsnuTeLRmXvW7e2uLfYcvrE0R2yLOLoQGpCAAra2hN3pCc qgVgeQrHdSZL7IBJV3AEQftxI4eWYoHSpMsauWIGh2z3TkD72Z1fC9jC34Bhi/ipY2lhx2yb7CKjZ dQeuEBqbVYXMLmD/MNj96CggwjC0ehX5iy3ip7QnudYwx+c3NW7uoi9dORoWCQkdTYeWP+mSz61Wz 5YKNUmrxWjvaSv90VkIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNT7-00FD3y-Vs; Tue, 26 Apr 2022 15:51:14 +0000 Received: from mail-ed1-f49.google.com ([209.85.208.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNT5-00FD3e-Cw for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 15:51:12 +0000 Received: by mail-ed1-f49.google.com with SMTP id b24so22874575edu.10 for ; Tue, 26 Apr 2022 08:51:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3DcH5qmRZJM8zM4oxn8FmbxTfqplHnMNRmIFYowfm8c=; b=teOvIMdd7jq0ddWE1/jZO3bm83Hm6JEERckOjyE5yiGpJhLJUnPuMHm2P9MCl2inK0 AH5gQa+zFPinOptPNaDgpv/wfyCM2jjpd8HuCBUen9axEIv+dp9J2LIicMR0RmXsy+xv qM54fmyJXDYTP1qMUiQnkktsqKtu9VxXsrWsV2JuLmO3tyaXfeARohzIsZ4u10l2A9FZ 2vyXbgTB2q5Oh+sYmPi5xN/+AJW0vK9zrtuPL/5wSe3rbL5n8Yc+uDGXDhQ61as8IRHB PyqhYvJE9q3phlPwUH4/mPkh65EFQb+cnNLiz6hJzJJ6dUXFlh3OzsybQa2QYcCpYSdG coYg== X-Gm-Message-State: AOAM531ZEijKCnBJqsGHG8CEvl+2ExkWdt8zPVK65Qq0vElB5LAqKiuP 1pKx0tVOEcGH8WIy8v5niSM= X-Google-Smtp-Source: ABdhPJwUvw93fjb0RgD6zKtbnHOLJdmZGy55Vj2lG2xTj4WbyEn08sepS7sk68mOF5G+RtGxWEDnKQ== X-Received: by 2002:a05:6402:27d1:b0:425:ef57:7db2 with SMTP id c17-20020a05640227d100b00425ef577db2mr9627883ede.180.1650988268964; Tue, 26 Apr 2022 08:51:08 -0700 (PDT) Received: from [10.9.0.34] ([46.166.128.205]) by smtp.gmail.com with ESMTPSA id h30-20020a056402095e00b00422eedf16b4sm6491110edz.60.2022.04.26.08.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 08:51:08 -0700 (PDT) Message-ID: <91238500-61a6-1e2e-1dc2-931c0a23cca8@linux.com> Date: Tue, 26 Apr 2022 18:51:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 0/8] stackleak: fixes and rework Content-Language: en-US To: Kees Cook , Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, catalin.marinas@arm.com, luto@kernel.org, will@kernel.org References: <20220425115603.781311-1-mark.rutland@arm.com> <202204251551.0CFE01DF4@keescook> From: Alexander Popov In-Reply-To: <202204251551.0CFE01DF4@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_085111_481752_9F8732B1 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: alex.popov@linux.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26.04.2022 01:54, Kees Cook wrote: > On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: >> This series reworks the stackleak code. The first patch fixes some >> latent issues on arm64, and the subsequent patches improve the code to >> improve clarity and permit better code generation. > > This looks nice; thanks! I'll put this through build testing and get it > applied shortly... > >> While the improvement is small, I think the improvement to clarity and >> code generation is a win regardless. > > Agreed. I also want to manually inspect the resulting memory just to > make sure things didn't accidentally regress. There's also an LKDTM test > for basic functionality. Hi Mark and Kees! Glad to see this patch series. I've looked at it briefly. Mark, I see your questions in the patches that I can answer. Please give me some time, I'm going to work on your patch series next week. I'll return with review and testing. Thanks! Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel