From: Heiko Stuebner <heiko@sntech.de>
To: Soeren Moch <smoch@web.de>
Cc: Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip@lists.infradead.org,
Hugh Cole-Baker <sigmaris@gmail.com>,
arm-linux <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] arm64: dts: rockchip: split rk3399-rockpro64, for v2 and v2.1 boards
Date: Thu, 28 Nov 2019 22:53:03 +0100 [thread overview]
Message-ID: <9133677.cKcSbgiQdr@phil> (raw)
In-Reply-To: <3fa2e3df-221b-99a8-796a-2e21f75cf706@web.de>
Am Donnerstag, 28. November 2019, 20:55:54 CET schrieb Soeren Moch:
> > On Thu, Nov 28, 2019 at 6:02 AM Katsuhiro Suzuki
> > <katsuhiro@katsuster.net> wrote:
> >> This patch splits rk3399-rockpro64 dts file to 2 files for v2 and
> >> v2.1 boards.
> >>
> >> Both v2 and v2.1 boards can use almost same settings but we find a
> >> difference in I2C address of audio CODEC ES8136.
> >>
> >> Reported-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> >>
> >> ---
[...]
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
> >> new file mode 100644
> >> index 000000000000..183eda4ffb9c
> >> --- /dev/null
> If we add this as new file, should we sort handles and properties
> alphabetically, where it is not done yet?
I'm torn here ... on one side, doing missing sorting might be nice
on the other hand, there is the moving without functional changes
paradigm, which is generally nice to adhere to.
But I guess sorting would generally be ok.
> I'm not sure about all the exceptions that usually apply for rockchip
> devicetrees, status property at the end, also the pinctrl node?
In general I don't "enforce" the sorting, so don't reject patches but instead
just do sorting myself if necessary ;-).
The general rule-of-thumb for nodes we came up with during the rk3288-veyron
era is something like:
compatible
reg
interrupts
[alphabetical properties]
status
as this makes it somewhat easier to parse the core properties (compatible,
reg, ints, status] when scrolling through a devicetree :-) .
Pinctrl position is at the discretion of the dt author :-D .
Position at the end has just the advantage that a long pin-group list does
not get in the way so much.
> What about unused references, e.g. "fan"?
Don't change too much when moving stuff around :-)
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-28 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3fa2e3df-221b-99a8-796a-2e21f75cf706@web.de>
2019-11-28 20:02 ` [PATCH v2] arm64: dts: rockchip: split rk3399-rockpro64, for v2 and v2.1 boards Soeren Moch
2019-11-28 21:53 ` Heiko Stuebner [this message]
2019-11-28 22:59 ` Soeren Moch
2019-11-28 14:01 [PATCH v2] arm64: dts: rockchip: split rk3399-rockpro64 " Katsuhiro Suzuki
2019-11-28 19:19 ` Vasily Khoruzhick
2019-12-02 5:59 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9133677.cKcSbgiQdr@phil \
--to=heiko@sntech.de \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sigmaris@gmail.com \
--cc=smoch@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).