From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F750C432C0 for ; Thu, 28 Nov 2019 21:53:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E94512176D for ; Thu, 28 Nov 2019 21:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l9+0w3nB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E94512176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p2fja2pROIF1jSu/iEJ00CcPoKQ6MAG4J+270ntyFUQ=; b=l9+0w3nBXA934X sHq9WW/rXbQK9GaGxMvhjKuhiR9RdAJVLsojsIXAkLC/6bXzpK8vBSV02pwXKZrFis1nHJShtC15Y +qQytdgtHWanBHPguaWNUGxbEt7Vq5FPkThs/ZN2DxLszLxM/pT9ZTjsNpKF6Rkxc/F1dykAu/RjR QwnP89+qyH5VBIdUq1FGQXSpzlSQv5maDsEb4m8evZBxSYDE/uoKVTY9oAcmnuEd/0tO2yEREbI2W 6XMPxrL9A1b87T3k6iIFEquohnLIrjOY5yKfBza3t0nZIp88nJjOUEe7tAD5toi+y/aflFSGzUT0t rcxnelv1EVAQqHWOc34g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaRir-0001Xc-5e; Thu, 28 Nov 2019 21:53:13 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaRio-0001Wd-4D; Thu, 28 Nov 2019 21:53:11 +0000 Received: from p5b127cfe.dip0.t-ipconnect.de ([91.18.124.254] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaRii-0005Hu-IH; Thu, 28 Nov 2019 22:53:04 +0100 From: Heiko Stuebner To: Soeren Moch Subject: Re: [PATCH v2] arm64: dts: rockchip: split rk3399-rockpro64, for v2 and v2.1 boards Date: Thu, 28 Nov 2019 22:53:03 +0100 Message-ID: <9133677.cKcSbgiQdr@phil> In-Reply-To: <3fa2e3df-221b-99a8-796a-2e21f75cf706@web.de> References: <3fa2e3df-221b-99a8-796a-2e21f75cf706@web.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_135310_319457_AC9A3CA7 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Katsuhiro Suzuki , linux-kernel , linux-rockchip@lists.infradead.org, Hugh Cole-Baker , arm-linux Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 28. November 2019, 20:55:54 CET schrieb Soeren Moch: > > On Thu, Nov 28, 2019 at 6:02 AM Katsuhiro Suzuki > > wrote: > >> This patch splits rk3399-rockpro64 dts file to 2 files for v2 and > >> v2.1 boards. > >> > >> Both v2 and v2.1 boards can use almost same settings but we find a > >> difference in I2C address of audio CODEC ES8136. > >> > >> Reported-by: Vasily Khoruzhick > >> Signed-off-by: Katsuhiro Suzuki > >> > >> --- [...] > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > >> new file mode 100644 > >> index 000000000000..183eda4ffb9c > >> --- /dev/null > If we add this as new file, should we sort handles and properties > alphabetically, where it is not done yet? I'm torn here ... on one side, doing missing sorting might be nice on the other hand, there is the moving without functional changes paradigm, which is generally nice to adhere to. But I guess sorting would generally be ok. > I'm not sure about all the exceptions that usually apply for rockchip > devicetrees, status property at the end, also the pinctrl node? In general I don't "enforce" the sorting, so don't reject patches but instead just do sorting myself if necessary ;-). The general rule-of-thumb for nodes we came up with during the rk3288-veyron era is something like: compatible reg interrupts [alphabetical properties] status as this makes it somewhat easier to parse the core properties (compatible, reg, ints, status] when scrolling through a devicetree :-) . Pinctrl position is at the discretion of the dt author :-D . Position at the end has just the advantage that a long pin-group list does not get in the way so much. > What about unused references, e.g. "fan"? Don't change too much when moving stuff around :-) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel