From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFA9C43381 for ; Fri, 8 Mar 2019 12:49:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C5D620684 for ; Fri, 8 Mar 2019 12:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ryExdNwQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C5D620684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P7mugfZGBphMhIE6lOt9CbElBB8uWKJWGa7QdazOWeA=; b=ryExdNwQwtXEfp R0ZtFZJDa+DKJtT0pNVOEyA3IGw7CDa1l7TTm1v0Y5r5S2haO1ca+8lAbfQmeZkrJhMRLczwOlXxK KF5dw0LZhYDMTL9y24TCxXzW0tGR/FD+BUaqMCOFy7bZi8vBhPYBendWL3x7J1ZDcYCX/TydYsh/E PSn3XypQOv6aqxHPUDGj6CAv+EmvetFsoHtvxsTegc+Tf40Xpb7fBicM8guUHTf78/AwstvPXgMO/ 60mlY6eBw2gUZTHD7zpXYzRFCz+cbFQGmzbqbjp/kMpXF0jcHx9L5szco3j3Lp74qcDmk75leo3Hx XbAMncBJQ6N939Uc+t6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2Evt-0006ek-OZ; Fri, 08 Mar 2019 12:49:01 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2Evq-0006dv-EY; Fri, 08 Mar 2019 12:48:59 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2019 04:48:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,455,1544515200"; d="scan'208";a="129923647" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by fmsmga008.fm.intel.com with ESMTP; 08 Mar 2019 04:48:52 -0800 Subject: Re: [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs. To: Christoph Muellner , robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de, shawn.lin@rock-chips.com, ulf.hansson@linaro.org References: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <9136f429-251a-87d3-8d6e-bf07c6882c8a@intel.com> Date: Fri, 8 Mar 2019 14:47:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_044858_540103_73462502 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Emil Renner Berthing , Viresh Kumar , Randy Li , linux-mmc@vger.kernel.org, Michal Simek , Vicente Bergas , Douglas Anderson , linux-rockchip@lists.infradead.org, Tony Xie , Klaus Goger , linux-arm-kernel@lists.infradead.org, Enric Balletbo i Serra , Philipp Tomsich , Ezequiel Garcia , linux-kernel@vger.kernel.org, Lin Huang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/03/19 10:43 AM, Christoph Muellner wrote: > Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > which exposes a control register bit to enable the feature. > The current implementation sets this bit unconditionally. > > This patch allows to suppress the feature activation, > by specifying the property disable-cqe-dcmd. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-of-arasan.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index c9e3e050ccc8..88dc3f00a5be 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > host->mmc_host_ops.start_signal_voltage_switch = > sdhci_arasan_voltage_switch; > sdhci_arasan->has_cqe = true; > - host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; > + host->mmc->caps2 |= MMC_CAP2_CQE; > + > + if (!of_property_read_bool(np, "disable-cqe-dcmd")) > + host->mmc->caps2 |= MMC_CAP2_CQE_DCMD; > } > > ret = sdhci_arasan_add_host(sdhci_arasan); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel