From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask()
Date: Sat, 28 Oct 2017 09:54:07 -0700 [thread overview]
Message-ID: <914591ef-f6b6-8e9b-a3cc-b7ac82391fd6@gmail.com> (raw)
In-Reply-To: <20171024195451.30535-2-opendmb@gmail.com>
On 10/24/2017 12:54 PM, Doug Berger wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The pin2mask() accessor only shuffles BIT ORDER in big endian systems,
> i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or
> bit 15 or bit 31 or so.
>
> The brcmstb only uses big endian BYTE ORDER which will be taken car of
> by the ->write_reg() callback.
>
> Just use BIT(offset) to assign the bit.
>
> Cc: Gregory Fong <gregory.0xf0@gmail.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-10-28 16:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 19:54 [PATCH v2 0/7] gpio: brcmstb: improved interrupt and wake support Doug Berger
2017-10-24 19:54 ` [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask() Doug Berger
2017-10-28 16:54 ` Florian Fainelli [this message]
2017-10-24 19:54 ` [PATCH v2 2/7] gpio: brcmstb: allow all instances to be wakeup sources Doug Berger
2017-10-31 9:28 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 3/7] gpio: brcmstb: release the bgpio lock during irq handlers Doug Berger
2017-10-31 9:29 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 4/7] gpio: brcmstb: switch to handle_level_irq flow Doug Berger
2017-10-31 9:30 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 5/7] gpio: brcmstb: correct the configuration of level interrupts Doug Berger
2017-10-31 9:31 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains Doug Berger
2017-10-26 23:44 ` Gregory Fong
2017-10-28 16:56 ` Florian Fainelli
2017-10-31 9:34 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 7/7] gpio: brcmstb: implement suspend/resume/shutdown Doug Berger
2017-10-26 23:51 ` Gregory Fong
2017-10-28 16:58 ` Florian Fainelli
2017-10-31 9:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=914591ef-f6b6-8e9b-a3cc-b7ac82391fd6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).