From mboxrd@z Thu Jan 1 00:00:00 1970 From: michal.simek@xilinx.com (Michal Simek) Date: Thu, 29 Sep 2016 10:43:19 -0700 Subject: [PATCH v19 05/12] fpga-mgr: add fpga image information struct In-Reply-To: References: <20160928182200.15800-1-atull@opensource.altera.com> <20160928182200.15800-6-atull@opensource.altera.com> Message-ID: <914ed9fb-c219-d034-7a5e-a400b80dfee0@xilinx.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28.9.2016 21:34, Alan Tull wrote: > On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer > wrote: > Hi Moritz, > >> Hi Alan, >> >> generally ok with the change. > > Cool! > >> >> On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull wrote: >> >>> -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, >>> - size_t count) >>> +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info, >>> + const char *buf, size_t count) >> >> Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are >> not part of this commit? >> i.e shouldn't 5,6 and 7 be a single commit? > > Yeah, squashing those would improve bisectability. Improve? :-) Definitely this needs to be the part of this commit. M