From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CECB0C433EF for ; Wed, 8 Jun 2022 10:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y59AznEOrt7G/kYwYw5ybaUn1s+N/3se9e3f2kE05F8=; b=WZxT8fVAg+jjD4 7bLp6O1LKRc4hrt33iLq1P9kHFyTwySDWtJNA22zhcpLxgCHFHTuuOGUxsHbOPsSYWz2D2YROcEpG eWuk44ZQJjX1Nkj6VyMzuhGTEtAdFfWHX1KzghurvMOhWXwvffkCiQfKFHp29EGq/ASOkLBqaMszC tzXZntUgDHY17NPrmFn8h6qyOmy8E2a0nRckt+6vPV5kJBDLjvHYMlpMF0bXjPLFLDuL2xq95oNnA w3U7YNES1hKZXs+L/CGAGHuT+HKx+hdaDR86ysbieCk2imraWFjsd9c4F/tqUreA2WBydv8fVk5jW r4bRffruR1nK1LngKVNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nysea-00CdOY-U4; Wed, 08 Jun 2022 10:11:09 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyscN-00CcKq-UH for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 10:08:53 +0000 Received: by mail-ej1-x62e.google.com with SMTP id kq6so27414695ejb.11 for ; Wed, 08 Jun 2022 03:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0nZ0iMJU6C7UG79cViLeyIi770dja43K/FzVTu1SAO4=; b=HorJq1vsgKHjyX4WFHpymYLZ8u4aemLph5q4pXSNAi73bZXhP2igaMroKFAfnfmfnI IHDbuJeHqxvwMciTuWnPoNwod3JoL/T/3aEf3CvZhw+hrgA2GmCA0sFS0LvA8dPHbXol vCuI0zrNLk4AgVvqyzGt1kbrDuAHy5qj6xWlweQ3/0o9fEZfGdBGXA9za+1vaiM8C3Eg eWzuuA8P8eoAJeoNsseQhLHLXlc2TisoesAPJvS85d3J4MKfauDtylO1TMpfds49WS99 ikDqo/DlDqeo9PN0KajsAnduudZbPn5KNbOFSLgofroMglHMsG0Myw9ju/3WkO98DRdA JJaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0nZ0iMJU6C7UG79cViLeyIi770dja43K/FzVTu1SAO4=; b=TQYkbpDL7+eT71NZI8qtDPXUKsjR9JreofksfSSks6d8MQoGX40o2OtSNhnobBl7H+ R2H/VEgYYSOoSRq4h7V/A9cmLMtuLcPR3HJp6mXY3lUjsgFz8+SxK2YI4T2RNyWO/DOo BfFp2CVKU29vCMoV/sxZ3v7tpawCbHa7jPKz0fTyjQ7PH+u/9j5cn2i8bTAiX9HlJmJ+ E56P87ZV2l0mrtFWIAHBwO+1SO960uYhcnFyPftTq7wnim4ircdyBjfSQUx/0KFmiC8q uIWSxNlIKsBGTq3xXJs0kIzrCCuFmoNQ72vbPIxctv8SX4igIldLNGmCqASFmPF0y4Jm gNnA== X-Gm-Message-State: AOAM532FEK53xHwCH7V0QdrxkjjLyOmnEGJ05wnu2Rafkkz9euryN5mH 0rx3/UzdvCVnDmVlldDs3TzTRg== X-Google-Smtp-Source: ABdhPJwv2k1lCiK72rw9Hy/n4bajQh3E+7H09B6IQPYxA2+JeIsbmwpfmrHi0IrppI52n4fRpSaFGA== X-Received: by 2002:a17:907:d29:b0:711:d215:5a5e with SMTP id gn41-20020a1709070d2900b00711d2155a5emr12740253ejc.697.1654682930680; Wed, 08 Jun 2022 03:08:50 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id d5-20020a170906344500b006fee98045cdsm9027012ejb.10.2022.06.08.03.08.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 03:08:49 -0700 (PDT) Message-ID: <91549b70-08fc-ed6f-c48e-5bcb70ea63d0@linaro.org> Date: Wed, 8 Jun 2022 12:08:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 11/20] reset: npcm: using syscon instead of device data Content-Language: en-US To: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-12-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220608095623.22327-12-tmaimon77@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_030852_036806_5D005F04 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2022 11:56, Tomer Maimon wrote: > Using syscon device tree property instead of > device data to handle the NPCM general control > registers. > Again ignored the comment. > Signed-off-by: Tomer Maimon > --- > drivers/reset/reset-npcm.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c > index 2ea4d3136e15..312c3b594b8f 100644 > --- a/drivers/reset/reset-npcm.c > +++ b/drivers/reset/reset-npcm.c > @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, > } > > static const struct of_device_id npcm_rc_match[] = { > - { .compatible = "nuvoton,npcm750-reset", > - .data = (void *)"nuvoton,npcm750-gcr" }, > + { .compatible = "nuvoton,npcm750-reset"}, > { } > }; > > @@ -155,14 +154,10 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) > u32 ipsrst1_bits = 0; > u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; > u32 ipsrst3_bits = 0; > - const char *gcr_dt; > > - gcr_dt = (const char *) > - of_match_device(dev->driver->of_match_table, dev)->data; > - > - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); > + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "nuvoton,sysgcr"); > if (IS_ERR(gcr_regmap)) { > - dev_err(&pdev->dev, "Failed to find %s\n", gcr_dt); > + dev_err(&pdev->dev, "Failed to find gcr syscon"); > return PTR_ERR(gcr_regmap); Comment still ignored. There is no point in this review if you keep ignoring what we ask to fix. If something is unclear, ask for clarification. Resending without implementing the comment means that you ignore the review which is waste of my time. I am sorry, but this is not acceptable. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel