From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 019CACD128A for ; Sat, 6 Apr 2024 06:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hZKEspGQq89/Xrcnp76Mo1+lf+aFWnX6O000Ni5RwBY=; b=YsFoEACuT1m/6M uT1BHNxcR+YK8lcVIqWO8vyFZJp6ejXKEvlwFIXhi49J7MiO8aFQZQiZuQHYWzAaJWFE/akgRWAA2 THTN6vd1H2QJFhwOqNO+az7Y6wK3op9hcBdPGtq9SX2SdP/jGOmb2jX4GgErnfOXX4LcfDgL3oLo+ FPG6CEyzSOldl3UQdSmCoGCc9uq9ETm/ZYwrgzZxe9ZkUqQmOHgaKfG0YQDR/KtR1FvRBll3hucft KOtSaIxBW/YJHgj+oXiGVsUj9ltYB7wN1raEGFxF0sS1mgfk2r4m+OdaebjbnEh4wRd2nOsIMoe/h 4Sb1ILqOOu0tW1px1gYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rszkc-00000009pAy-1oBb; Sat, 06 Apr 2024 06:42:06 +0000 Received: from mail-108-mta0.mxroute.com ([136.175.108.0]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rszkY-00000009pAW-2UuI for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 06:42:04 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta0.mxroute.com (ZoneMTA) with ESMTPSA id 18eb21fcaf10003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 06 Apr 2024 06:36:51 +0000 X-Zone-Loop: 30e68be9cd2220594ac8ecc31ee6f37d4aa07b76c104 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P6oz8jLcfNyvGaOUeOoCwlqC8Ij6mtZ6/gKuz1gexug=; b=WPhbq6ZEa+mQTnijWaBY6xxs/H cfHYUnpSRs8fOhOb/O4yJffkApW8GbdCsZ9fgpCJBUMa3pysrcREVULO1R/UkyRqIiPc9mObnfXPv YmP7o/tAqB0ayOqkRLxs5fQtXrUia6yJroEUCCB+ckUFpQp8RHDB0YyE7tXXD9rJenqQZDa30Cqkj soLpFl0b5rnHDmjMNbaU+mvK6HOXuMsdAhCIuIT3xhAYVnT6i+9TrIfSP7p+3tjqrOm0eD3oFmOvb FE0z2dqpWXi9w++3zacDwlhzLX9akXx4T0C5yl6+Qkahp/SWJ/+9Q9RvAIcOuf71zbchDNERWMcas kIvWVcdg==; Message-ID: <91621b30-dc6f-49cb-878c-96d39e38d994@luigi311.com> Date: Sat, 6 Apr 2024 00:36:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information To: Pavel Machek Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-12-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_234202_765056_74613D1C X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/3/24 12:46, Pavel Machek wrote: > Hi! > >> Libcamera requires the cropping information for each mode, so >> add this information to the driver. > >> @@ -116,6 +124,9 @@ struct imx258_mode { >> u32 link_freq_index; >> /* Default register values */ >> struct imx258_reg_list reg_list; >> + >> + /* Analog crop rectangle. */ > > No need for "." at the end, as it is not above. > Done >> + struct v4l2_rect crop; >> }; > > If the crop is same in all modes, should we have it in common place? > > Best regards, > Pavel I see the imx219 made a similar change where it was changed from using that .crop format to just setting it in the set_pad_format function so we can do something similar here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel