From: "Arnd Bergmann" <arnd@arndb.de>
To: "Nikita Shubin" <nikita.shubin@maquefel.me>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Cc: "Hartley Sweeten" <hsweeten@visionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Lukasz Majewski" <lukma@denx.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] gpio: ep93xx: Fix port F hwirq numbers in handler
Date: Wed, 25 Jan 2023 10:39:57 +0100 [thread overview]
Message-ID: <918952b8-6687-42ab-82af-b64c8db7e191@app.fastmail.com> (raw)
In-Reply-To: <20230125083026.5399-2-nikita.shubin@maquefel.me>
On Wed, Jan 25, 2023, at 09:30, Nikita Shubin wrote:
> Fix wrong translation of irq numbers in port F handler, as ep93xx hwirqs
> increased by 1, we should simply decrease them by 1 in translation.
>
> Fixes: 482c27273f52 ("ARM: ep93xx: renumber interrupts")
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: stable@vger.kernel.org # v5.19+
Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpio/gpio-ep93xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 2e1779709113..7edcdc575080 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -148,7 +148,7 @@ static void ep93xx_gpio_f_irq_handler(struct irq_desc *desc)
> */
> struct irq_chip *irqchip = irq_desc_get_chip(desc);
> unsigned int irq = irq_desc_get_irq(desc);
> - int port_f_idx = ((irq + 1) & 7) ^ 4; /* {19..22,47..50} -> {0..7} */
> + int port_f_idx = (irq & 7) ^ 4; /* {20..23,48..51} -> {0..7} */
> int gpio_irq = EP93XX_GPIO_F_IRQ_BASE + port_f_idx;
>
> chained_irq_enter(irqchip, desc);
> --
> 2.37.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-25 9:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:08 [PATCH 1/2] gpio: ep93xx: convert driver to DT Nikita Shubin
2023-01-17 10:08 ` [PATCH 2/2] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-17 10:15 ` [PATCH 1/2] gpio: ep93xx: convert driver to DT Arnd Bergmann
2023-01-25 8:33 ` Nikita Shubin
2023-01-18 14:24 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 0/3] gpio-ep93xx: prepare for dt, fixes Nikita Shubin
2023-01-25 8:30 ` [PATCH v1 1/3] gpio: ep93xx: Fix port F hwirq numbers in handler Nikita Shubin
2023-01-25 9:39 ` Arnd Bergmann [this message]
2023-01-25 12:42 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 2/3] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-25 12:45 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 3/3] gpio: ep93xx: split device in multiple Nikita Shubin
2023-01-30 15:16 ` Bartosz Golaszewski
2023-02-01 9:10 ` [PATCH v2] " Nikita Shubin
2023-02-01 9:12 ` Bartosz Golaszewski
2023-02-01 9:18 ` Alexander Sverdlin
2023-02-01 9:26 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918952b8-6687-42ab-82af-b64c8db7e191@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.sverdlin@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox