From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D90DDC197A0 for ; Sat, 18 Nov 2023 01:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IA65/ZK/XuAG7uGtZrb1A4a94TIlQN3d1JwWBjKP+Vo=; b=IdUi6XuFtopYwr jA71471AbaU82mzlUrNS7sy6lHUeTTDVDdHNYri4letID1IwDbFmuanyf7TR7qz3UOsZ5/IPn/gyW 0JLjcviiXbJksivwxTsB8HYZXApgLU1EnbSFvb8Tlb4slw7RYUKbxKayO4YkGnxCaIoRSD3UIjzeU Olbj9u2uqT03N2GoDNDq2mDN5gxZlOClhxmWhCOX5/ypVt50zjBFaWKUOBhsBB4dIkq95Z2/l7gPA PDOT3ZpZQCvcNTjSPvFfPlhQUmKX0RV3gpYmRQPibI4h36j45wFu9r7iBLpF+QU8LExwEt8D8al1S hU+RJowCIKLYa79NO1KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r49n2-007eQa-1S; Sat, 18 Nov 2023 01:06:28 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r49mz-007eQ5-1U for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2023 01:06:26 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9d216597f64so351065166b.3 for ; Fri, 17 Nov 2023 17:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700269582; x=1700874382; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4O9Y1/hJUXa+2KCBVAziPC7SkkcerSExCPCyWU7zFNI=; b=qbZrnLXgrh4umi1DlZYgzS4yWh+J1W4jlJT0L/29e25S3BSrVIkJZbeq2DFFacAtc8 f2FVpalBee6Vwmuesy2Eh7tP3pxMLnZAllW7GrYK0zbMbk8caZQydNL86wjxy670nRp/ z4eFce/k8+gFV4F6mSTReq+esEa2eRTobmJZgUPQArC0bsE5xuE/iwbfuPmYrdaogVKs XOVoECWzb8CI1+FZFXWJ+1vIcHe67hBIAUlhsO9TlsmyEbfn4s8hNUtPfQrSQ98wddWK C5zrawPGgj9TaQgOp5eoCUfCy48+J1vVl4xrGYkD/vdbiSuKrFtsV6wKPTFmu2qB4V7Y C/wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700269582; x=1700874382; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4O9Y1/hJUXa+2KCBVAziPC7SkkcerSExCPCyWU7zFNI=; b=s+T2AGekZu4x6K2uxGHHusbwsMUMZw3r2Z+d8nx5EAB1pjtUOxXWZvvIABcQ+1j3Rz JCcDos0UIWKz1otsBdE7ZP6gvYwnY9hfaxz28UQPJZxW1MAX0XezRGfuwb6Qyip9hsyv XGPHuzjO8B52X193kUt8UnnmR1jI+rPW3P1FUKxzAiK1fnfrILba/9FammeMPZXUUIFE uTnuo19eQs7RcIZVZzEBbvW2gF3JBA8CQpPT4hm7Zpl5+WMnXObje8zIanaOACjIheaD GZyypG5saRbetDifGasb622EyLrtKsfUoov5F8F7aRe+3F0NKe6g3Yd5/+IuHKqWk/+k Vr0A== X-Gm-Message-State: AOJu0Ywj6Vti+mXmBjJiy/wlcI5bB2O2LTxUaY4RUUf0NTU25NNxAkiT QBJ2pOVQKKttaWi9LBUmTSiuww== X-Google-Smtp-Source: AGHT+IGD5VqU/VikH08bv6P2ZemTESCQQPO/BcUy7UKQJCy4Lh6+IFe/6TG47Ps/J21C1Xmse/dYOw== X-Received: by 2002:a17:906:5357:b0:9bf:20e0:bfe9 with SMTP id j23-20020a170906535700b009bf20e0bfe9mr701024ejo.15.1700269581768; Fri, 17 Nov 2023 17:06:21 -0800 (PST) Received: from [192.168.201.100] (178235187040.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.40]) by smtp.gmail.com with ESMTPSA id v12-20020a1709060b4c00b009b928eb8dd3sm1327704ejg.163.2023.11.17.17.06.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 17:06:21 -0800 (PST) Message-ID: <918ff1f5-ce01-43ea-b034-e69fbb31f495@linaro.org> Date: Sat, 18 Nov 2023 02:06:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 3/5] arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts Content-Language: en-US To: Sibi Sankar , andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, ulf.hansson@linaro.org Cc: agross@kernel.org, conor+dt@kernel.org, ayan.kumar.halder@amd.com, j@jannau.net, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, m.szyprowski@samsung.com, u-kumar1@ti.com, peng.fan@nxp.com, lpieralisi@kernel.org, quic_rjendra@quicinc.com, abel.vesa@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_tsoni@quicinc.com, neil.armstrong@linaro.org References: <20231117113931.26660-1-quic_sibis@quicinc.com> <20231117113931.26660-4-quic_sibis@quicinc.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231117113931.26660-4-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231117_170625_553708_0E721B31 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.11.2023 12:39, Sibi Sankar wrote: > From: Rajendra Nayak > > Add base dtsi and QCP board (Qualcomm Compute Platform) dts file for > X1E80100 SoC, describing the CPUs, GCC and RPMHCC clock controllers, > geni UART, interrupt controller, TLMM, reserved memory, interconnects, > SMMU and LLCC nodes. > > Co-developed-by: Abel Vesa > Signed-off-by: Abel Vesa > Signed-off-by: Rajendra Nayak > Co-developed-by: Sibi Sankar > Signed-off-by: Sibi Sankar > --- [...] > +&tlmm { > + gpio-reserved-ranges = <33 3>, <44 4>, /* SPI (TPM) */ Surely SPI doesn't use 7 wires! :D [...] > + L2_0: l2-cache-0 { the cache device is distinguishable by its parent, so "l2-cache" is enough > + compatible = "cache"; > + cache-level = <2>; > + cache-unified; > + }; > + }; > + [...] > + idle-states { > + entry-method = "psci"; > + > + CLUSTER_C4: cpu-sleep-0 { > + compatible = "arm,idle-state"; > + idle-state-name = "ret"; > + arm,psci-suspend-param = <0x00000004>; These suspend parameters look funky.. is this just a PSCI sleep implementation that strays far away from Arm's suggested guidelines? [...] > + CPU_PD11: power-domain-cpu11 { > + #power-domain-cells = <0>; > + power-domains = <&CLUSTER_PD>; > + }; > + > + CLUSTER_PD: power-domain-cpu-cluster { > + #power-domain-cells = <0>; > + domain-idle-states = <&CLUSTER_CL4>, <&CLUSTER_CL5>; > + }; So, can the 3 clusters not shut down their L2 and PLLs (if separate?) on their own? > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + gunyah_hyp_mem: gunyah-hyp@80000000 { > + reg = <0x0 0x80000000 0x0 0x800000>; > + no-map; > + }; > + > + hyp_elf_package_mem: hyp-elf_package@80800000 { no underscores in node names, use hyphens The rest looks OK I think Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel