From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F2A7C7115C for ; Fri, 20 Jun 2025 16:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DJDQ5jsltpJAHqGixOU5/Ni4jPTDl32ucuObQ0mSDyM=; b=NkCkF8zDqsBHpiryT9RQHCeWVK JTgVAXk1UUBsebnnKVksiTNvGfcwPd7Dv8feo/+Akl7u2ucEukT7VTZUv/9WqD/cNYNmcqWb89x/J D1rcStpTXkzu34G4BP4urD43XVxOc8UkGw0QJPlZnTN19nVuHebdFeE6sPpPYmR/qk5uk6Evi+SH7 YTXW9hGl1gwjf3enHnFKiQ/0gmMBy8WRuHyrvgVgUKfxYSELRj3G5kaXqMYjjofYC2WJNL0dbnRIq c2YutkBklO2Jr1YzzGyG+6NM0I4jngbxR0Am5aS8nzGVjpm/J1egrDS3H7mfZkTIqmoAZUcWlBXm/ UlCB+HPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSexr-0000000GAxf-2UM6; Fri, 20 Jun 2025 16:51:43 +0000 Received: from out-178.mta1.migadu.com ([2001:41d0:203:375::b2]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSeJ9-0000000G5zu-11nn for linux-arm-kernel@lists.infradead.org; Fri, 20 Jun 2025 16:09:40 +0000 Message-ID: <91a9e80a-1a45-470b-90cf-12faae67debd@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750435775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DJDQ5jsltpJAHqGixOU5/Ni4jPTDl32ucuObQ0mSDyM=; b=BvVaoDdE4HfZlrhFrGHfLidXQq982iceIFHYawUFS82oIZutrM74DFbTSJO1YVWfqduR9M mUeggRzAA2wPS595IFKDZm9MSrf6DKadVBei1/GDHu/JsDk0RSNnArFH1dYIURgjvzYjT2 BdUHQuD6f3YB0eV9pTofQbziWxGdBDM= Date: Fri, 20 Jun 2025 12:09:29 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net 1/4] auxiliary: Allow empty id To: Greg Kroah-Hartman Cc: Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Michal Simek , Saravana Kannan , Leon Romanovsky , Dave Ertman , linux-kernel@vger.kernel.org, Ira Weiny , linux-arm-kernel@lists.infradead.org, Danilo Krummrich , "Rafael J. Wysocki" References: <20250619200537.260017-1-sean.anderson@linux.dev> <20250619200537.260017-2-sean.anderson@linux.dev> <2025062004-essay-pecan-d5be@gregkh> <8b9662ab-580c-44ea-96ee-b3fe3d4672ff@linux.dev> <2025062006-detergent-spruce-5ae2@gregkh> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <2025062006-detergent-spruce-5ae2@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250620_090939_493922_388E28E3 X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/20/25 12:02, Greg Kroah-Hartman wrote: > On Fri, Jun 20, 2025 at 11:37:40AM -0400, Sean Anderson wrote: >> On 6/20/25 01:13, Greg Kroah-Hartman wrote: >> > On Thu, Jun 19, 2025 at 04:05:34PM -0400, Sean Anderson wrote: >> >> Support creating auxiliary devices with the id included as part of the >> >> name. This allows for non-decimal ids, which may be more appropriate for >> >> auxiliary devices created as children of memory-mapped devices. For >> >> example, a name like "xilinx_emac.mac.802c0000" could be achieved by >> >> setting .name to "mac.802c0000" and .id to AUXILIARY_DEVID_NONE. >> > >> > I don't see the justification for this, sorry. An id is just an id, it >> > doesn't matter what is is and nothing should be relying on it to be the >> > same across reboots or anywhere else. The only requirement is that it >> > be unique at this point in time in the system. >> >> It identifies the device in log messages. Without this you have to read >> sysfs to determine what device is (for example) producing an error. > > That's fine, read sysfs :) I should not have to read sysfs to decode boot output. If there is an error during boot I should be able to determine the offending device. This very important when the boot process fails before init is started, and very convenient otherwise. >> This >> may be inconvenient to do if the error prevents the system from booting. >> This series converts a platform device with a legible ID like >> "802c0000.ethernet" to an auxiliary device, and I believe descriptive >> device names produce a better developer experience. > > You can still have 802c0000.ethernet be the prefix of the name, that's > fine. This is not possible due to how the auxiliary bus works. If device's name is in the form "foo.id", then the driver must have an auxiliary_device_id in its id_table with .name = "foo". So the address *must* come after the last period in the name. --Sean >> This is also shorter and simpler than auto-generated IDs. > > Please stick with auto-generated ids, they will work properly here. > > thanks, > > greg k-h