From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C589C433EF for ; Tue, 12 Oct 2021 13:38:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C940160F92 for ; Tue, 12 Oct 2021 13:38:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C940160F92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+47TPETpr2Ms+FxCps5UHsuI8F+cLGrbNkDCJ8hQrkA=; b=2IC4Ce2uhCA6WX SX11ZY1Ljrc/2eJGDdwC/VL4epP5Ei09EVbKJaWMtz6y5WAKgHL60zDm0f6zpPvPI+7MpBT8A6Tx2 8VANcDa8GgaDnpXNtk2V2cmrGCntjyAgSeawfYfZLqA8PmcWrNiHmiFjZ1/pfXDI15WomUnn4r6mT eCz6AStpjuh73M4krPTSLXKDAO6VmiwwoFSYAIxG+B58VBkQd5nQql7ulPa4pDxJMyfm+XzLlrP3z 0rOH7IIIbKP06jlvhufEDnUG56wq0L/SF7W9Zrk81X7tLOC9+SSj5Ig9OducprRZp38Q+wr97XpVL nNhEQlBZBxiHgGvFwL6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maHwr-00D0NB-1W; Tue, 12 Oct 2021 13:36:05 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maHwj-00D0KT-P0 for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 13:35:59 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maHwV-00025C-Sk; Tue, 12 Oct 2021 15:35:43 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1maHwV-0001ab-Ct; Tue, 12 Oct 2021 15:35:43 +0200 Message-ID: <91ae922d66b4b8c521142c8030bdd1a9f6d2fad1.camel@pengutronix.de> Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add lan966x support From: Philipp Zabel To: Horatiu Vultur , robh+dt@kernel.org, andrew@lunn.ch, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 12 Oct 2021 15:35:43 +0200 In-Reply-To: <20211012114238.2060101-2-horatiu.vultur@microchip.com> References: <20211012114238.2060101-1-horatiu.vultur@microchip.com> <20211012114238.2060101-2-horatiu.vultur@microchip.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_063557_874213_49E3E83D X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Horatiu, On Tue, 2021-10-12 at 13:42 +0200, Horatiu Vultur wrote: > This adds support for lan966x. > > Signed-off-by: Horatiu Vultur > --- > .../devicetree/bindings/reset/microchip,rst.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > index 370579aeeca1..622cf3d0455d 100644 > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > @@ -20,7 +20,11 @@ properties: > pattern: "^reset-controller@[0-9a-f]+$" > > compatible: > - const: microchip,sparx5-switch-reset > + oneOf: > + - items: > + - const: microchip,sparx5-switch-reset > + - items: > + - const: microchip,lan966x-switch-reset > > reg: > items: > @@ -37,6 +41,14 @@ properties: > $ref: "/schemas/types.yaml#/definitions/phandle" > description: syscon used to access CPU reset > > + cuphy-syscon: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: syscon used to access CuPHY > + > + gpios: >From the description I'd expect this to be called phy-reset-gpios. > + description: used for release of reset of the external PHY > + maxItems: 1 > + Shouldn't an external PHY be described as a separate DT node, with its own reset gpio? regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel