From: Florian Fainelli <f.fainelli@gmail.com>
To: Rob Herring <robh@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>
Cc: Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
devicetree@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
bcm-kernel-feedback-list@broadcom.com,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] dt-bindings: pci: Convert iProc PCIe to YAML
Date: Mon, 13 Dec 2021 15:25:15 -0800 [thread overview]
Message-ID: <91c2ad0d-491c-902a-4b12-d96f9cdbbab2@gmail.com> (raw)
In-Reply-To: <1639437829.333710.1773610.nullmailer@robh.at.kernel.org>
On 12/13/21 3:23 PM, Rob Herring wrote:
> On Mon, 13 Dec 2021 11:02:21 -0800, Florian Fainelli wrote:
>> Conver the iProc PCIe controller Device Tree binding to YAML now that
>> all DTS in arch/arm and arch/arm64 have been fixed to be compliant.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/pci/brcm,iproc-pcie.txt | 133 -------------
>> .../bindings/pci/brcm,iproc-pcie.yaml | 184 ++++++++++++++++++
>> 2 files changed, 184 insertions(+), 133 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> create mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml:97:34: [warning] too few spaces after comma (commas)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.example.dt.yaml: pcie@18012000: 'brcm' is a dependency of 'brcm,pcie-ob-axi-offset'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.example.dt.yaml: pcie@18012000: 'pcie-ob' is a dependency of 'brcm,pcie-ob-axi-offset'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
OK, so the dependencies must be quoted, but not the properties
declaration. Thanks!
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1567483
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-13 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:02 [PATCH 0/6] Convert iProc PCIe binding to YAML Florian Fainelli
2021-12-13 19:02 ` [PATCH 1/6] ARM: dts: Cygnus: Fixed iProc PCIe controller properties Florian Fainelli
2021-12-13 19:02 ` [PATCH 2/6] ARM: dts: Cygnus: Update PCIe PHY node unit name(s) Florian Fainelli
2021-12-13 19:02 ` [PATCH 3/6] ARM: dts: HR2: Fixed iProc PCIe MSI sub-node Florian Fainelli
2021-12-13 19:02 ` [PATCH 4/6] ARM: dts: NSP: " Florian Fainelli
2021-12-13 19:02 ` [PATCH 5/6] dt-bindings: phy: Convert Cygnus PCIe PHY to YAML Florian Fainelli
2021-12-13 19:02 ` [PATCH 6/6] dt-bindings: pci: Convert iProc PCIe " Florian Fainelli
2021-12-13 23:23 ` Rob Herring
2021-12-13 23:25 ` Florian Fainelli [this message]
2021-12-13 23:27 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91c2ad0d-491c-902a-4b12-d96f9cdbbab2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox