From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
andersson@kernel.org, mathieu.poirier@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: remoteproc: imx_rproc: add fsl,startup-delay-ms
Date: Wed, 2 Nov 2022 15:01:11 -0400 [thread overview]
Message-ID: <91ebdf1b-d6e2-47a2-ae1c-bc1848bb74c2@linaro.org> (raw)
In-Reply-To: <20221102112451.128110-2-peng.fan@oss.nxp.com>
On 02/11/2022 07:24, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> add fsl,startup-delay-ms property indicating delay some time after just
> kicks remote processor.
Start sentences with capital letter.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index ad3b8d4ccd91..d99d3342ad52 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -76,6 +76,10 @@ properties:
> This property is to specify the resource id of the remote processor in SoC
> which supports SCFW
>
> + fsl,startup-delay-ms:
> + $ref: "/schemas/types.yaml#/definitions/uint32"
Drop quotes.
> + description: Startup time that remote processor ready for communication
Looks quite hacky...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-02 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:24 [PATCH V2 0/2] remoteproc: imx: add start up delay Peng Fan (OSS)
2022-11-02 11:24 ` [PATCH V2 1/2] dt-bindings: remoteproc: imx_rproc: add fsl,startup-delay-ms Peng Fan (OSS)
2022-11-02 19:01 ` Krzysztof Kozlowski [this message]
2022-11-02 11:24 ` [PATCH V2 2/2] remoteproc: imx_rproc: delay after kick remote processor Peng Fan (OSS)
2022-11-02 17:29 ` [PATCH V2 0/2] remoteproc: imx: add start up delay Mathieu Poirier
2022-11-03 5:08 ` Peng Fan
2022-11-04 15:33 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ebdf1b-d6e2-47a2-ae1c-bc1848bb74c2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox